From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] drivers/perf: arm_pmu_acpi: avoid perf IRQ init when guest PMU is off
Date: Thu, 25 May 2017 16:50:42 +0100 [thread overview]
Message-ID: <20170525155042.GS2859@arm.com> (raw)
In-Reply-To: <c11672c5-b167-f50f-2035-40a3db3ec598@redhat.com>
On Thu, May 25, 2017 at 10:49:49AM -0500, Wei Huang wrote:
> On 05/25/2017 10:28 AM, Will Deacon wrote:
> > On Wed, May 24, 2017 at 09:36:41AM -0500, Wei Huang wrote:
> >> if (gicc->flags & ACPI_MADT_PERFORMANCE_IRQ_MODE)
> >> trigger = ACPI_EDGE_SENSITIVE;
> >> else
> >> @@ -58,7 +61,8 @@ static void arm_pmu_acpi_unregister_irq(int cpu)
> >> return;
> >>
> >> gsi = gicc->performance_interrupt;
> >> - acpi_unregister_gsi(gsi);
> >> + if (gsi)
> >> + acpi_unregister_gsi(gsi);
> >
> > ... but then I don't see how we can get here, so I'll drop this hunk.
>
> I am OK to drop it. It was added just to be cautious... Do you need
> another version from me or you will remove this hunk?
I can drop this hunk, no need to repost.
Thanks,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Wei Huang <wei@redhat.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com
Subject: Re: [PATCH 1/1] drivers/perf: arm_pmu_acpi: avoid perf IRQ init when guest PMU is off
Date: Thu, 25 May 2017 16:50:42 +0100 [thread overview]
Message-ID: <20170525155042.GS2859@arm.com> (raw)
In-Reply-To: <c11672c5-b167-f50f-2035-40a3db3ec598@redhat.com>
On Thu, May 25, 2017 at 10:49:49AM -0500, Wei Huang wrote:
> On 05/25/2017 10:28 AM, Will Deacon wrote:
> > On Wed, May 24, 2017 at 09:36:41AM -0500, Wei Huang wrote:
> >> if (gicc->flags & ACPI_MADT_PERFORMANCE_IRQ_MODE)
> >> trigger = ACPI_EDGE_SENSITIVE;
> >> else
> >> @@ -58,7 +61,8 @@ static void arm_pmu_acpi_unregister_irq(int cpu)
> >> return;
> >>
> >> gsi = gicc->performance_interrupt;
> >> - acpi_unregister_gsi(gsi);
> >> + if (gsi)
> >> + acpi_unregister_gsi(gsi);
> >
> > ... but then I don't see how we can get here, so I'll drop this hunk.
>
> I am OK to drop it. It was added just to be cautious... Do you need
> another version from me or you will remove this hunk?
I can drop this hunk, no need to repost.
Thanks,
Will
next prev parent reply other threads:[~2017-05-25 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 14:36 [PATCH 1/1] drivers/perf: arm_pmu_acpi: avoid perf IRQ init when guest PMU is off Wei Huang
2017-05-24 14:36 ` Wei Huang
2017-05-25 15:28 ` Will Deacon
2017-05-25 15:28 ` Will Deacon
2017-05-25 15:49 ` Wei Huang
2017-05-25 15:49 ` Wei Huang
2017-05-25 15:50 ` Will Deacon [this message]
2017-05-25 15:50 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525155042.GS2859@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.