From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Richard Weinberger" <richard@nod.at>,
"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V5 4/4] mtd: extract TRX parser out of bcm47xxpart into a separated module
Date: Thu, 25 May 2017 13:51:54 -0700 [thread overview]
Message-ID: <20170525205154.GD114788@google.com> (raw)
In-Reply-To: <20170524094437.2174-5-zajec5@gmail.com>
On Wed, May 24, 2017 at 11:44:37AM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This makes TRX parsing code reusable with other platforms and parsers.
>
> Please note this patch doesn't really change anything in the existing
> code, just moves it. There is still some place for improvement (e.g.
> working on non-hacky method of checking rootfs format) but it's not
> really a subject of this change.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: A totally rebased & refreshed version.
> V5: Add TRX format verification, improve comment, fix memory leak
> Thanks Brian
I think this looks OK now. I'll wait on resolving the rest of the
infrastucture, so I'll leave this here for now:
Reviewed-by: Brian Norris <computersforpeace@gmail.com>
> ---
> drivers/mtd/Kconfig | 4 ++
> drivers/mtd/Makefile | 1 +
> drivers/mtd/bcm47xxpart.c | 99 ++----------------------------
> drivers/mtd/parsers/Kconfig | 8 +++
> drivers/mtd/parsers/Makefile | 1 +
> drivers/mtd/parsers/parser_trx.c | 126 +++++++++++++++++++++++++++++++++++++++
> 6 files changed, 145 insertions(+), 94 deletions(-)
> create mode 100644 drivers/mtd/parsers/Kconfig
> create mode 100644 drivers/mtd/parsers/Makefile
> create mode 100644 drivers/mtd/parsers/parser_trx.c
>
...
> diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
> new file mode 100644
> index 000000000000..ebb697a52698
> --- /dev/null
> +++ b/drivers/mtd/parsers/Kconfig
> @@ -0,0 +1,8 @@
> +config MTD_PARSER_TRX
> + tristate "Parser for TRX format partitions"
> + depends on MTD && (BCM47XX || ARCH_BCM_5301X)
|| COMPILE_TEST ? Would be nice to be able to build-test things like
this, even if you know they're only used for a few architectures.
> + help
> + TRX is a firmware format used by Broadcom on their devices. It
> + may contain up to 3/4 partitions (depending on the version).
> + This driver will parse TRX header and report at least two partitions:
> + kernel and rootfs.
...
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "David Woodhouse" <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"Boris Brezillon"
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Marek Vasut"
<marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Richard Weinberger" <richard-/L3Ra7n9ekc@public.gmane.org>,
"Cyrille Pitchen"
<cyrille.pitchen-yU5RGvR974pGWvitb5QawA@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
Subject: Re: [PATCH V5 4/4] mtd: extract TRX parser out of bcm47xxpart into a separated module
Date: Thu, 25 May 2017 13:51:54 -0700 [thread overview]
Message-ID: <20170525205154.GD114788@google.com> (raw)
In-Reply-To: <20170524094437.2174-5-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, May 24, 2017 at 11:44:37AM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
>
> This makes TRX parsing code reusable with other platforms and parsers.
>
> Please note this patch doesn't really change anything in the existing
> code, just moves it. There is still some place for improvement (e.g.
> working on non-hacky method of checking rootfs format) but it's not
> really a subject of this change.
>
> Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
> ---
> V2: A totally rebased & refreshed version.
> V5: Add TRX format verification, improve comment, fix memory leak
> Thanks Brian
I think this looks OK now. I'll wait on resolving the rest of the
infrastucture, so I'll leave this here for now:
Reviewed-by: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/mtd/Kconfig | 4 ++
> drivers/mtd/Makefile | 1 +
> drivers/mtd/bcm47xxpart.c | 99 ++----------------------------
> drivers/mtd/parsers/Kconfig | 8 +++
> drivers/mtd/parsers/Makefile | 1 +
> drivers/mtd/parsers/parser_trx.c | 126 +++++++++++++++++++++++++++++++++++++++
> 6 files changed, 145 insertions(+), 94 deletions(-)
> create mode 100644 drivers/mtd/parsers/Kconfig
> create mode 100644 drivers/mtd/parsers/Makefile
> create mode 100644 drivers/mtd/parsers/parser_trx.c
>
...
> diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
> new file mode 100644
> index 000000000000..ebb697a52698
> --- /dev/null
> +++ b/drivers/mtd/parsers/Kconfig
> @@ -0,0 +1,8 @@
> +config MTD_PARSER_TRX
> + tristate "Parser for TRX format partitions"
> + depends on MTD && (BCM47XX || ARCH_BCM_5301X)
|| COMPILE_TEST ? Would be nice to be able to build-test things like
this, even if you know they're only used for a few architectures.
> + help
> + TRX is a firmware format used by Broadcom on their devices. It
> + may contain up to 3/4 partitions (depending on the version).
> + This driver will parse TRX header and report at least two partitions:
> + kernel and rootfs.
...
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-25 20:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 9:44 [PATCH V5 0/4] mtd: add support for subpartitions Rafał Miłecki
2017-05-24 9:44 ` Rafał Miłecki
2017-05-24 9:44 ` [PATCH V5 1/4] mtd: partitions: rename allocate_partition master argument to the parent Rafał Miłecki
2017-05-24 9:44 ` Rafał Miłecki
2017-05-24 9:44 ` [PATCH V5 2/4] mtd: partitions: add support for allocating subpartition Rafał Miłecki
2017-05-24 9:44 ` Rafał Miłecki
2017-05-25 20:25 ` Brian Norris
2017-05-25 20:25 ` Brian Norris
2017-05-24 9:44 ` [PATCH V5 3/4] mtd: partitions: add support for partition parsers Rafał Miłecki
2017-05-24 9:44 ` Rafał Miłecki
2017-05-24 9:44 ` [PATCH V5 4/4] mtd: extract TRX parser out of bcm47xxpart into a separated module Rafał Miłecki
2017-05-24 9:44 ` Rafał Miłecki
2017-05-25 20:51 ` Brian Norris [this message]
2017-05-25 20:51 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525205154.GD114788@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.