From: Jonathan Cameron <jic23@kernel.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
soren.brinkmann@xilinx.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable
Date: Sun, 28 May 2017 15:50:41 +0100 [thread overview]
Message-ID: <20170528155041.478fc87b@kernel.org> (raw)
In-Reply-To: <29dda0d20f714ce828e294f99b7f400e89f5b35a.1495780467.git.arvind.yadav.cs@gmail.com>
On Fri, 26 May 2017 12:07:41 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Straight forward looking so I've applied this to the togreg
branch of iio.git and pushed it out as testing for the autobuilders
to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 56cf590..4a60497 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
> ret = PTR_ERR(xadc->clk);
> goto err_free_samplerate_trigger;
> }
> - clk_prepare_enable(xadc->clk);
> +
> + ret = clk_prepare_enable(xadc->clk);
> + if (ret)
> + goto err_free_samplerate_trigger;
>
> ret = xadc->ops->setup(pdev, indio_dev, irq);
> if (ret)
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable
Date: Sun, 28 May 2017 15:50:41 +0100 [thread overview]
Message-ID: <20170528155041.478fc87b@kernel.org> (raw)
In-Reply-To: <29dda0d20f714ce828e294f99b7f400e89f5b35a.1495780467.git.arvind.yadav.cs@gmail.com>
On Fri, 26 May 2017 12:07:41 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Straight forward looking so I've applied this to the togreg
branch of iio.git and pushed it out as testing for the autobuilders
to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 56cf590..4a60497 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
> ret = PTR_ERR(xadc->clk);
> goto err_free_samplerate_trigger;
> }
> - clk_prepare_enable(xadc->clk);
> +
> + ret = clk_prepare_enable(xadc->clk);
> + if (ret)
> + goto err_free_samplerate_trigger;
>
> ret = xadc->ops->setup(pdev, indio_dev, irq);
> if (ret)
next prev parent reply other threads:[~2017-05-28 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 6:37 [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable Arvind Yadav
2017-05-26 6:37 ` Arvind Yadav
2017-05-28 14:50 ` Jonathan Cameron [this message]
2017-05-28 14:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170528155041.478fc87b@kernel.org \
--to=jic23@kernel.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.