All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ralf Baechle <ralf@linux-mips.org>,
	Stafford Horne <shorne@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
	Jonas Bonn <jonas@southpole.se>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	openrisc@lists.librecores.org, Jamie Iles <jamie.iles@oracle.com>
Subject: Re: [PATCH] kthread: fix boot hang (regression) on MIPS/OpenRISC
Date: Mon, 29 May 2017 18:18:50 +0200	[thread overview]
Message-ID: <20170529161850.GA15236@redhat.com> (raw)
In-Reply-To: <20170529072207.16130-1-vegard.nossum@oracle.com>

On 05/29, Vegard Nossum wrote:
>
> This fixes a regression in commit 4d6501dce079 where I didn't notice
> that MIPS and OpenRISC were reinitialising p->{set,clear}_child_tid to
> NULL after our initialisation in copy_process().

Oh, I didn't even know that arch/ can play with xxx_child_tid,

> We can simply get rid of the arch-specific initialisation here

Agreed. Thanks!

Acked-by: Oleg Nesterov <oleg@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH] kthread: fix boot hang (regression) on MIPS/OpenRISC
Date: Mon, 29 May 2017 18:18:50 +0200	[thread overview]
Message-ID: <20170529161850.GA15236@redhat.com> (raw)
In-Reply-To: <20170529072207.16130-1-vegard.nossum@oracle.com>

On 05/29, Vegard Nossum wrote:
>
> This fixes a regression in commit 4d6501dce079 where I didn't notice
> that MIPS and OpenRISC were reinitialising p->{set,clear}_child_tid to
> NULL after our initialisation in copy_process().

Oh, I didn't even know that arch/ can play with xxx_child_tid,

> We can simply get rid of the arch-specific initialisation here

Agreed. Thanks!

Acked-by: Oleg Nesterov <oleg@redhat.com>


  parent reply	other threads:[~2017-05-29 16:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29  7:22 [PATCH] kthread: fix boot hang (regression) on MIPS/OpenRISC Vegard Nossum
2017-05-29  7:22 ` [OpenRISC] " Vegard Nossum
2017-05-29 12:55 ` Stafford Horne
2017-05-29 12:55   ` [OpenRISC] " Stafford Horne
2017-05-29 16:18 ` Oleg Nesterov [this message]
2017-05-29 16:18   ` Oleg Nesterov
2017-05-29 16:40 ` Linus Torvalds
2017-05-29 16:40   ` [OpenRISC] " Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529161850.GA15236@redhat.com \
    --to=oleg@redhat.com \
    --cc=jamie.iles@oracle.com \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=openrisc@lists.librecores.org \
    --cc=ralf@linux-mips.org \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.