From: Stephen Hemminger <stephen@networkplumber.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: x86@kernel.org, devel@linuxdriverproject.org,
Stephen Hemminger <sthemmin@microsoft.com>,
Jork Loeser <Jork.Loeser@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor
Date: Tue, 30 May 2017 09:59:47 -0700 [thread overview]
Message-ID: <20170530095947.4cc19990@xeon-e3> (raw)
In-Reply-To: <20170530113424.15687-3-vkuznets@redhat.com>
On Tue, 30 May 2017 13:34:16 +0200
Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index 04cb8d3..bdcc433 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -175,9 +175,15 @@ static void __init ms_hyperv_init_platform(void)
> ms_hyperv.misc_features = cpuid_edx(HYPERV_CPUID_FEATURES);
> ms_hyperv.hints = cpuid_eax(HYPERV_CPUID_ENLIGHTMENT_INFO);
>
> - pr_info("HyperV: features 0x%x, hints 0x%x\n",
> + pr_info("Hyper-V: features 0x%x, hints 0x%x\n",
> ms_hyperv.features, ms_hyperv.hints);
>
> + ms_hyperv.max_vp_index = cpuid_eax(HVCPUID_IMPLEMENTATION_LIMITS);
> + ms_hyperv.max_lp_index = cpuid_ebx(HVCPUID_IMPLEMENTATION_LIMITS);
> +
> + pr_info("Hyper-V: max %u virtual processors, %u logical processors\n",
> + ms_hyperv.max_vp_index, ms_hyperv.max_lp_index);
> +
I understand as developer why you may need to log stuff.
Do we really need more logging here? Why not pr_debug()?
next prev parent reply other threads:[~2017-05-30 16:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 11:34 [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set Vitaly Kuznetsov
2017-05-30 16:24 ` Andy Shevchenko
2017-05-31 14:37 ` Vitaly Kuznetsov
2017-05-31 14:51 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor Vitaly Kuznetsov
2017-05-30 16:59 ` Stephen Hemminger [this message]
2017-05-31 14:38 ` Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 03/10] x86/hyper-v: make hv_do_hypercall() inline Vitaly Kuznetsov
2017-05-30 16:29 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 04/10] x86/hyper-v: fast hypercall implementation Vitaly Kuznetsov
2017-05-30 16:31 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 06/10] x86/hyper-v: implement rep hypercalls Vitaly Kuznetsov
2017-05-30 16:33 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 07/10] hyper-v: globalize vp_index Vitaly Kuznetsov
2017-05-30 16:38 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Vitaly Kuznetsov
2017-05-30 16:52 ` Andy Shevchenko
2017-05-30 19:17 ` Jork Loeser
2017-05-30 19:19 ` Andy Shevchenko
2017-05-30 23:04 ` Stephen Hemminger
2017-05-30 11:34 ` [PATCH v5 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls Vitaly Kuznetsov
2017-05-30 17:02 ` Andy Shevchenko
2017-05-30 19:13 ` Jork Loeser
2017-05-31 15:06 ` Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Vitaly Kuznetsov
2017-05-30 17:05 ` [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements Andy Shevchenko
2017-05-31 14:29 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530095947.4cc19990@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Jork.Loeser@microsoft.com \
--cc=andy.shevchenko@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.