From: Stephen Hemminger <stephen@networkplumber.org>
To: Jork Loeser <Jork.Loeser@microsoft.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush
Date: Tue, 30 May 2017 16:04:45 -0700 [thread overview]
Message-ID: <20170530160445.54b29cb8@xeon-e3> (raw)
In-Reply-To: <CY4PR21MB0631FC0D2A80D34081DF3595F1F00@CY4PR21MB0631.namprd21.prod.outlook.com>
On Tue, 30 May 2017 19:17:46 +0000
Jork Loeser <Jork.Loeser@microsoft.com> wrote:
> > -----Original Message-----
> > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> > Sent: Tuesday, May 30, 2017 09:53
> > To: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Cc: x86@kernel.org; devel@linuxdriverproject.org; linux-
> > kernel@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> > Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; H.
> > Peter Anvin <hpa@zytor.com>; Steven Rostedt <rostedt@goodmis.org>; Jork
> > Loeser <Jork.Loeser@microsoft.com>; Simon Xiao <sixiao@microsoft.com>;
> > Andy Lutomirski <luto@kernel.org>
> > Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush
> >
> > On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <vkuznets@redhat.com>
> > wrote:
> > > +#define HV_FLUSH_ALL_PROCESSORS 0x00000001
> > > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES 0x00000002
> > > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY 0x00000004
> > > +#define HV_FLUSH_USE_EXTENDED_RANGE_FORMAT 0x00000008
> >
> > BIT() ?
>
> Certainly a matter of taste. Given that the Hyper-V spec lists these as hex numbers, I find the explicit numbers appropriate.
>
> Regards,
> Jork
Keep the hex numbers, it makes more sense not to change it since rest of arch/x86/hyperv
uses hex values.
next prev parent reply other threads:[~2017-05-30 23:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 11:34 [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set Vitaly Kuznetsov
2017-05-30 16:24 ` Andy Shevchenko
2017-05-31 14:37 ` Vitaly Kuznetsov
2017-05-31 14:51 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor Vitaly Kuznetsov
2017-05-30 16:59 ` Stephen Hemminger
2017-05-31 14:38 ` Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 03/10] x86/hyper-v: make hv_do_hypercall() inline Vitaly Kuznetsov
2017-05-30 16:29 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 04/10] x86/hyper-v: fast hypercall implementation Vitaly Kuznetsov
2017-05-30 16:31 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 06/10] x86/hyper-v: implement rep hypercalls Vitaly Kuznetsov
2017-05-30 16:33 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 07/10] hyper-v: globalize vp_index Vitaly Kuznetsov
2017-05-30 16:38 ` Andy Shevchenko
2017-05-30 11:34 ` [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Vitaly Kuznetsov
2017-05-30 16:52 ` Andy Shevchenko
2017-05-30 19:17 ` Jork Loeser
2017-05-30 19:19 ` Andy Shevchenko
2017-05-30 23:04 ` Stephen Hemminger [this message]
2017-05-30 11:34 ` [PATCH v5 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls Vitaly Kuznetsov
2017-05-30 17:02 ` Andy Shevchenko
2017-05-30 19:13 ` Jork Loeser
2017-05-31 15:06 ` Vitaly Kuznetsov
2017-05-30 11:34 ` [PATCH v5 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() Vitaly Kuznetsov
2017-05-30 17:05 ` [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements Andy Shevchenko
2017-05-31 14:29 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530160445.54b29cb8@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Jork.Loeser@microsoft.com \
--cc=andy.shevchenko@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.