unionmount-testsuite: backward compat support for REDIRECT_DIR=n

unionmount-testsuite: backward compat support for REDIRECT_DIR=n

[Amir Goldstein]

On Tue, Apr 25, 2017 at 5:20 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Tue, Apr 25, 2017 at 4:53 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
>> On Tue, Apr 25, 2017 at 04:49:00PM +0300, Amir Goldstein wrote:
>>> On Tue, Apr 25, 2017 at 4:29 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
...
>>> >
>>> > I will enable it now. I just had an old config and ran into this.
>>> >
>>> > But this does raise the question unionmount-testsuite need to be
>>> > maintained somewhere so that it acts as a baseline to figure out if
>>> > new patches broke some existing tests.
>>> >
>>> > I can go by the tree you are maintaining but currently that's broken too
>>> > with REDIRECT_DIR=n.
>>> >
>>>
>>> Right.
>>> I have given some though about what's the best way to handle this.
>>> Probably need a test flag --noredirect. I'll add this to my TODO...
>>>
>>> BTW, I try to keep the branch overlayfs-devel uptodate for testing
>>> latest features. It could be rebased, but I'll make an effort not to.
>>> If there is a need for a more stable non-rewindable branch, let me know.
>>
>> I think would be good if you maintain "master" branch of your tree up
>> to date and hopefully that's stable so that later git pull does not talk
>> about conflicts. We can then use your tree for setting a baseline and
>> detecting regressions.
>>
>> CCing Dave Howells, in case he is interested in continuing to update his
>> tree as overlayfs kernel development takes place.
>>
>
> OK. declaring branch master on my tree 'ff-only':
> https://github.com/amir73il/unionmount-testsuite/tree/master
>

Vivek,

I added support for running my maser branch with old kernels
or with REDIRECT_DIR=n.

User needs to request backward compat mode explicitly.
When using new command line arg --xdev,
dir rename tests that would return EXDEV are skipped.

User will get a hint to use the new flag when such a test fails, e.g.:

root@kvm-xfstests:~/unionmount-testsuite# ./run --ov rename-empty-dir
***
*** ./run --ov --ts=0 rename-empty-dir
***
TEST rename-empty-dir.py:10: Rename empty dir and rename back
 ./run --rename /mnt/a/empty100 /mnt/a/no_dir100
/mnt/a/empty100: Unexpected error: Invalid cross-device link; Run
tests with --xdev to skip dir rename tests

Updated my master branch.

The new head of the master branch is commit:

  be7354d Use ./run --ov --xdev for backward compat mode

Cheers,
Amir.

Re: unionmount-testsuite: backward compat support for REDIRECT_DIR=n

[Vivek Goyal]

On Sun, May 28, 2017 at 05:43:45PM +0300, Amir Goldstein wrote:
> On Tue, Apr 25, 2017 at 5:20 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> > On Tue, Apr 25, 2017 at 4:53 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
> >> On Tue, Apr 25, 2017 at 04:49:00PM +0300, Amir Goldstein wrote:
> >>> On Tue, Apr 25, 2017 at 4:29 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
> ...
> >>> >
> >>> > I will enable it now. I just had an old config and ran into this.
> >>> >
> >>> > But this does raise the question unionmount-testsuite need to be
> >>> > maintained somewhere so that it acts as a baseline to figure out if
> >>> > new patches broke some existing tests.
> >>> >
> >>> > I can go by the tree you are maintaining but currently that's broken too
> >>> > with REDIRECT_DIR=n.
> >>> >
> >>>
> >>> Right.
> >>> I have given some though about what's the best way to handle this.
> >>> Probably need a test flag --noredirect. I'll add this to my TODO...
> >>>
> >>> BTW, I try to keep the branch overlayfs-devel uptodate for testing
> >>> latest features. It could be rebased, but I'll make an effort not to.
> >>> If there is a need for a more stable non-rewindable branch, let me know.
> >>
> >> I think would be good if you maintain "master" branch of your tree up
> >> to date and hopefully that's stable so that later git pull does not talk
> >> about conflicts. We can then use your tree for setting a baseline and
> >> detecting regressions.
> >>
> >> CCing Dave Howells, in case he is interested in continuing to update his
> >> tree as overlayfs kernel development takes place.
> >>
> >
> > OK. declaring branch master on my tree 'ff-only':
> > https://github.com/amir73il/unionmount-testsuite/tree/master
> >
> 
> Vivek,
> 
> I added support for running my maser branch with old kernels
> or with REDIRECT_DIR=n.
> 
> User needs to request backward compat mode explicitly.
> When using new command line arg --xdev,
> dir rename tests that would return EXDEV are skipped.
> 
> User will get a hint to use the new flag when such a test fails, e.g.:
> 
> root@kvm-xfstests:~/unionmount-testsuite# ./run --ov rename-empty-dir
> ***
> *** ./run --ov --ts=0 rename-empty-dir
> ***
> TEST rename-empty-dir.py:10: Rename empty dir and rename back
>  ./run --rename /mnt/a/empty100 /mnt/a/no_dir100
> /mnt/a/empty100: Unexpected error: Invalid cross-device link; Run
> tests with --xdev to skip dir rename tests
> 
> Updated my master branch.
> 
> The new head of the master branch is commit:
> 
>   be7354d Use ./run --ov --xdev for backward compat mode

Ok, thanks Amir.

So --xdev will skip tests which are not supposed to pass without
REDIRECT_DIR=n?

Would be great if we could automate this. That is test which are not valid
with current kernel/overlay configuration are skipped automatically. It
totally up to you. :-)

Vivek

Re: unionmount-testsuite: backward compat support for REDIRECT_DIR=n

[Amir Goldstein]

On Tue, May 30, 2017 at 11:35 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
> On Sun, May 28, 2017 at 05:43:45PM +0300, Amir Goldstein wrote:
...
>>
>> Vivek,
>>
>> I added support for running my maser branch with old kernels
>> or with REDIRECT_DIR=n.
>>
>> User needs to request backward compat mode explicitly.
>> When using new command line arg --xdev,
>> dir rename tests that would return EXDEV are skipped.
>>
...
>
> So --xdev will skip tests which are not supposed to pass without
> REDIRECT_DIR=n?

Short answer - yes.

Long answer:
Technically, those tests (rename-empty-dir, rename-pop-dir, rename-move-dir)
pass on David's master branch by expecting and getting EXDEV.
My master branch, OTOH, does not verify getting EXDEV with the --xdev
flag, so it will not uncover a hypothetical regression with REDIRECT_DIR=n
where those tests no longer return EXDEV.

The reason I did not revert eae160a ("Relax failure to rename lower directory")
is because I have added more directory rename tests since then, so the revert
itself is not enough and I chose the easier path.

>
> Would be great if we could automate this. That is test which are not valid
> with current kernel/overlay configuration are skipped automatically. It
> totally up to you. :-)
>

Yes, that would be great.
Need to test "`cat /sys/module/overlay/parameters/redirect_dir`" = Y
But need to take care to modprobe overlay before the test.

It's up to me or anyone that wants to send a patch ;-)

Thanks,
Amir.

Re: unionmount-testsuite: backward compat support for REDIRECT_DIR=n

[Amir Goldstein]

On Wed, May 31, 2017 at 10:56 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Tue, May 30, 2017 at 11:35 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
>> On Sun, May 28, 2017 at 05:43:45PM +0300, Amir Goldstein wrote:
> ...
>>>
>>> Vivek,
>>>
>>> I added support for running my maser branch with old kernels
>>> or with REDIRECT_DIR=n.
>>>
>>> User needs to request backward compat mode explicitly.
>>> When using new command line arg --xdev,
>>> dir rename tests that would return EXDEV are skipped.
>>>
> ...
>>
>> So --xdev will skip tests which are not supposed to pass without
>> REDIRECT_DIR=n?
>


> Short answer - yes.
>
> Long answer:
> Technically, those tests (rename-empty-dir, rename-pop-dir, rename-move-dir)
> pass on David's master branch by expecting and getting EXDEV.
> My master branch, OTOH, does not verify getting EXDEV with the --xdev
> flag, so it will not uncover a hypothetical regression with REDIRECT_DIR=n
> where those tests no longer return EXDEV.
>

Pushed to master:
680b310 Add a test to verify EXDEV behavior when OVERLAYFS_REDIRECT_DIR=n

>
>>
>> Would be great if we could automate this. That is test which are not valid
>> with current kernel/overlay configuration are skipped automatically. It
>> totally up to you. :-)
>>
>
> Yes, that would be great.
> Need to test "`cat /sys/module/overlay/parameters/redirect_dir`" = Y
> But need to take care to modprobe overlay before the test.
>

Pushed to master:
7a8bd82 Check if redirect_dir is disabled and skip directory rename tests

Cheers,
Amir.