From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] PCI: ensure the PCI device is locked over ->reset_notify calls
Date: Wed, 31 May 2017 06:58:48 +0200 [thread overview]
Message-ID: <20170531045848.GA4001@lst.de> (raw)
In-Reply-To: <20170530222844.GE14896@bhelgaas-glaptop.roam.corp.google.com>
On Tue, May 30, 2017@05:28:44PM -0500, Bjorn Helgaas wrote:
> [+cc Alex]
>
> On Tue, May 23, 2017@07:42:02AM +0200, Christoph Hellwig wrote:
> > Without this ->notify_reset instance may race with ->remove calls,
>
> Do you mean the .reset_notify() method in struct pci_error_handlers?
> I don't see a "notify_reset" symbol.
Yes.
> Can you elaborate on exactly how this race happens? I'm trying to
> figure out whether this is also a problem or potential problem with
> other reset paths like pci_try_reset_function(), pci_reset_bus(),
> pci_try_reset_bus(), pci_reset_slot(), and pci_try_reset_slot().
>
> What does the race look like when it happens? Oops, panic, etc?
>
> Can this also be triggered via the sysfs "reset" file?
Here is the original bug report:
http://lists.infradead.org/pipermail/linux-nvme/2017-May/010345.html
the issue is triggered through sysfs.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
rakesh@tuxera.com, linux-pci@vger.kernel.org,
linux-nvme@lists.infradead.org,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] PCI: ensure the PCI device is locked over ->reset_notify calls
Date: Wed, 31 May 2017 06:58:48 +0200 [thread overview]
Message-ID: <20170531045848.GA4001@lst.de> (raw)
In-Reply-To: <20170530222844.GE14896@bhelgaas-glaptop.roam.corp.google.com>
On Tue, May 30, 2017 at 05:28:44PM -0500, Bjorn Helgaas wrote:
> [+cc Alex]
>
> On Tue, May 23, 2017 at 07:42:02AM +0200, Christoph Hellwig wrote:
> > Without this ->notify_reset instance may race with ->remove calls,
>
> Do you mean the .reset_notify() method in struct pci_error_handlers?
> I don't see a "notify_reset" symbol.
Yes.
> Can you elaborate on exactly how this race happens? I'm trying to
> figure out whether this is also a problem or potential problem with
> other reset paths like pci_try_reset_function(), pci_reset_bus(),
> pci_try_reset_bus(), pci_reset_slot(), and pci_try_reset_slot().
>
> What does the race look like when it happens? Oops, panic, etc?
>
> Can this also be triggered via the sysfs "reset" file?
Here is the original bug report:
http://lists.infradead.org/pipermail/linux-nvme/2017-May/010345.html
the issue is triggered through sysfs.
next prev parent reply other threads:[~2017-05-31 4:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 5:42 avoid null pointer rereference during FLR Christoph Hellwig
2017-05-23 5:42 ` Christoph Hellwig
2017-05-23 5:42 ` [PATCH] PCI: ensure the PCI device is locked over ->reset_notify calls Christoph Hellwig
2017-05-23 5:42 ` Christoph Hellwig
2017-05-29 9:19 ` Rakesh Pandit
2017-05-29 9:19 ` Rakesh Pandit
2017-05-30 22:28 ` Bjorn Helgaas
2017-05-30 22:28 ` Bjorn Helgaas
2017-05-31 4:58 ` Christoph Hellwig [this message]
2017-05-31 4:58 ` Christoph Hellwig
2017-05-31 16:51 ` Bjorn Helgaas
2017-05-31 16:51 ` Bjorn Helgaas
2017-06-01 10:46 ` Christoph Hellwig
2017-06-01 10:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531045848.GA4001@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.