From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling
Date: Wed, 31 May 2017 12:17:56 -0400 [thread overview]
Message-ID: <20170531161756.GD2845@localhost.localdomain> (raw)
In-Reply-To: <29f66b96-0629-177a-be54-dbd638bf0f49@grimberg.me>
On Tue, May 30, 2017@02:58:06PM +0300, Sagi Grimberg wrote:
> > So, the reason the state is changed when the work is running rather than
> > queueing is for the window when the state may be set to NVME_CTRL_DELETING,
> > and we don't want the reset work to proceed in that case.
> >
> > What do you think about adding a new state, like NVME_CTRL_SCHED_RESET,
> > then leaving the NVME_CTRL_RESETTING state change as-is?
>
> OK, just got to this one.
>
> Instead of adding yet another state, how about making controller delete
> cancel the reset_work (cancel_work_sync)?
Yes, that should also work.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Rakesh Pandit <rakesh@tuxera.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling
Date: Wed, 31 May 2017 12:17:56 -0400 [thread overview]
Message-ID: <20170531161756.GD2845@localhost.localdomain> (raw)
In-Reply-To: <29f66b96-0629-177a-be54-dbd638bf0f49@grimberg.me>
On Tue, May 30, 2017 at 02:58:06PM +0300, Sagi Grimberg wrote:
> > So, the reason the state is changed when the work is running rather than
> > queueing is for the window when the state may be set to NVME_CTRL_DELETING,
> > and we don't want the reset work to proceed in that case.
> >
> > What do you think about adding a new state, like NVME_CTRL_SCHED_RESET,
> > then leaving the NVME_CTRL_RESETTING state change as-is?
>
> OK, just got to this one.
>
> Instead of adding yet another state, how about making controller delete
> cancel the reset_work (cancel_work_sync)?
Yes, that should also work.
next prev parent reply other threads:[~2017-05-31 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 14:26 [PATCH V2 1/1] nvme: fix multiple ctrl removal scheduling Rakesh Pandit
2017-05-24 14:26 ` Rakesh Pandit
2017-05-25 8:30 ` Christoph Hellwig
2017-05-25 8:30 ` Christoph Hellwig
2017-05-26 20:12 ` Rakesh Pandit
2017-05-26 20:12 ` Rakesh Pandit
2017-05-26 10:06 ` Keith Busch
2017-05-26 10:06 ` Keith Busch
2017-05-26 15:28 ` Rakesh Pandit
2017-05-26 15:28 ` Rakesh Pandit
2017-05-30 11:58 ` Sagi Grimberg
2017-05-30 11:58 ` Sagi Grimberg
2017-05-31 16:17 ` Keith Busch [this message]
2017-05-31 16:17 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531161756.GD2845@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.