All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org,
	"Rafael J . Wysocki " <rjw@rjwysocki.net>,
	linux-acpi@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Borislav Petkov <bp@suse.de>,
	intel-gfx@lists.freedesktop.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API
Date: Wed, 31 May 2017 22:41:49 +0300	[thread overview]
Message-ID: <20170531194152.65927-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com>

There are new types and helpers that are supposed to be used in new code.

As a preparation to get rid of legacy types and API functions do
the conversion here.

Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/apei/ghes.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d0855c09f32f..084414a4c5b8 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -431,12 +431,13 @@ static void ghes_do_proc(struct ghes *ghes,
 {
 	int sev, sec_sev;
 	struct acpi_hest_generic_data *gdata;
+	guid_t *sec_type;
 
 	sev = ghes_severity(estatus->error_severity);
 	apei_estatus_for_each_section(estatus, gdata) {
+		sec_type = (guid_t *)gdata->section_type;
 		sec_sev = ghes_severity(gdata->error_severity);
-		if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
-				 CPER_SEC_PLATFORM_MEM)) {
+		if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {
 			struct cper_sec_mem_err *mem_err;
 			mem_err = (struct cper_sec_mem_err *)(gdata+1);
 			ghes_edac_report_mem_error(ghes, sev, mem_err);
@@ -445,8 +446,7 @@ static void ghes_do_proc(struct ghes *ghes,
 			ghes_handle_memory_failure(gdata, sev);
 		}
 #ifdef CONFIG_ACPI_APEI_PCIEAER
-		else if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
-				      CPER_SEC_PCIE)) {
+		else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {
 			struct cper_sec_pcie *pcie_err;
 			pcie_err = (struct cper_sec_pcie *)(gdata+1);
 			if (sev == GHES_SEV_RECOVERABLE &&
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org,
	"Rafael J . Wysocki " <rjw@rjwysocki.net>,
	linux-acpi@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Borislav Petkov <bp@suse.de>,
	intel-gfx@lists.freedesktop.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API
Date: Wed, 31 May 2017 22:41:49 +0300	[thread overview]
Message-ID: <20170531194152.65927-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com>

There are new types and helpers that are supposed to be used in new code.

As a preparation to get rid of legacy types and API functions do
the conversion here.

Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/apei/ghes.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d0855c09f32f..084414a4c5b8 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -431,12 +431,13 @@ static void ghes_do_proc(struct ghes *ghes,
 {
 	int sev, sec_sev;
 	struct acpi_hest_generic_data *gdata;
+	guid_t *sec_type;
 
 	sev = ghes_severity(estatus->error_severity);
 	apei_estatus_for_each_section(estatus, gdata) {
+		sec_type = (guid_t *)gdata->section_type;
 		sec_sev = ghes_severity(gdata->error_severity);
-		if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
-				 CPER_SEC_PLATFORM_MEM)) {
+		if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {
 			struct cper_sec_mem_err *mem_err;
 			mem_err = (struct cper_sec_mem_err *)(gdata+1);
 			ghes_edac_report_mem_error(ghes, sev, mem_err);
@@ -445,8 +446,7 @@ static void ghes_do_proc(struct ghes *ghes,
 			ghes_handle_memory_failure(gdata, sev);
 		}
 #ifdef CONFIG_ACPI_APEI_PCIEAER
-		else if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
-				      CPER_SEC_PCIE)) {
+		else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {
 			struct cper_sec_pcie *pcie_err;
 			pcie_err = (struct cper_sec_pcie *)(gdata+1);
 			if (sev == GHES_SEV_RECOVERABLE &&
-- 
2.11.0

  parent reply	other threads:[~2017-05-31 19:41 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 19:41 [PATCH v2 0/5] ACPI et al: convert to use new UUID API Andy Shevchenko
2017-05-31 19:41 ` Andy Shevchenko
2017-05-31 19:41 ` [PATCH v2 1/5] acpi, nfit: Switch to use new generic " Andy Shevchenko
2017-05-31 19:41   ` Andy Shevchenko
2017-06-01 14:26   ` Dan Williams
2017-06-05 16:01   ` Christoph Hellwig
2017-06-05 16:18     ` Andy Shevchenko
2017-06-05 16:18       ` Andy Shevchenko
2017-05-31 19:41 ` Andy Shevchenko [this message]
2017-05-31 19:41   ` [PATCH v2 2/5] ACPI / APEI: " Andy Shevchenko
2017-05-31 23:56   ` kbuild test robot
2017-05-31 23:56     ` [Intel-gfx] " kbuild test robot
2017-06-01  9:50     ` Andy Shevchenko
2017-06-01  9:50       ` [Intel-gfx] " Andy Shevchenko
2017-06-05 16:01   ` Christoph Hellwig
2017-06-05 16:19     ` Andy Shevchenko
2017-06-05 16:19       ` Andy Shevchenko
2017-06-05 16:22       ` Christoph Hellwig
2017-06-05 16:22         ` Christoph Hellwig
2017-06-05 16:28         ` Andy Shevchenko
2017-06-05 16:28           ` Andy Shevchenko
2017-05-31 19:41 ` [PATCH v2 3/5] ACPI / bus: " Andy Shevchenko
2017-05-31 22:42   ` Rafael J. Wysocki
2017-05-31 23:56   ` kbuild test robot
2017-05-31 23:56     ` kbuild test robot
2017-06-01  0:05   ` kbuild test robot
2017-06-01  0:05     ` kbuild test robot
2017-06-05 16:03   ` Christoph Hellwig
2017-06-05 16:03     ` Christoph Hellwig
2017-06-05 16:20     ` Andy Shevchenko
2017-06-05 16:20       ` Andy Shevchenko
2017-06-05 20:37       ` Rafael J. Wysocki
2017-06-05 20:37         ` Rafael J. Wysocki
2017-06-06  9:58         ` Christoph Hellwig
2017-05-31 19:41 ` [PATCH v2 4/5] ACPI / extlog: " Andy Shevchenko
2017-05-31 19:41   ` Andy Shevchenko
2017-06-05 16:06   ` Christoph Hellwig
2017-06-05 16:23     ` Andy Shevchenko
2017-06-05 16:23       ` Andy Shevchenko
2017-06-05 21:23       ` Christoph Hellwig
2017-05-31 19:41 ` [PATCH v2 5/5] ACPI: Switch to use generic guid_t in acpi_evaluate_dsm() Andy Shevchenko
2017-05-31 20:21   ` Mark Brown
2017-05-31 22:42   ` Rafael J. Wysocki
2017-06-01  6:03     ` Christoph Hellwig
2017-06-01  0:08   ` kbuild test robot
2017-06-01  0:08     ` kbuild test robot
2017-06-01  0:11   ` kbuild test robot
2017-06-01  0:11     ` kbuild test robot
2017-06-01 14:12   ` Jarkko Sakkinen
2017-06-01 14:12     ` Jarkko Sakkinen
2017-06-01 14:24   ` Dan Williams
2017-06-01 14:24     ` Dan Williams
2017-06-02 12:25   ` Adrian Hunter
2017-05-31 19:45 ` [PATCH v2 0/5] ACPI et al: convert to use new UUID API Christoph Hellwig
2017-05-31 19:45 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-05-31 20:07 ` [PATCH v2 0/5] " Andy Shevchenko
2017-05-31 20:07   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531194152.65927-3-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bp@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.