All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Josef Bacik <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>,
	Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>,
	Vladimir Davydov
	<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rik van Riel <riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-team-b10kYP2dOMg@public.gmane.org,
	Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	Russell King <rmk-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Yury Norov
	<ynorov-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>,
	Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure
Date: Wed, 31 May 2017 21:44:25 -0400	[thread overview]
Message-ID: <20170601014425.GA11815@cmpxchg.org> (raw)
In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>

On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote:
> On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> wrote:
> 
> > Andrew, the 0day tester found a crash with this when special pages get
> > faulted. They're not charged to any cgroup and we'll deref NULL.
> > 
> > Can you include the following fix on top of this patch please? Thanks!
> 
> OK.  But this won't fix the init ordering crash which the arm folks are
> seeing?
> 
> I'm wondering if we should ask Stephen to drop
> 
> mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch
> mm-memcontrol-use-the-node-native-slab-memory-counters.patch
> mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch
> mm-memcontrol-per-lruvec-stats-infrastructure.patch
> mm-memcontrol-account-slab-stats-per-lruvec.patch

Sorry about the wreckage.

Dropping these makes sense to me for the time being.

I'll fix up the init ordering issue.

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Josef Bacik <josef@toxicpanda.com>,
	Michal Hocko <mhocko@suse.com>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Rik van Riel <riel@redhat.com>,
	linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-team@fb.com,
	Tony Lindgren <tony@atomide.com>,
	Russell King <rmk@armlinux.org.uk>,
	Yury Norov <ynorov@caviumnetworks.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure
Date: Wed, 31 May 2017 21:44:25 -0400	[thread overview]
Message-ID: <20170601014425.GA11815@cmpxchg.org> (raw)
In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org>

On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote:
> On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> 
> > Andrew, the 0day tester found a crash with this when special pages get
> > faulted. They're not charged to any cgroup and we'll deref NULL.
> > 
> > Can you include the following fix on top of this patch please? Thanks!
> 
> OK.  But this won't fix the init ordering crash which the arm folks are
> seeing?
> 
> I'm wondering if we should ask Stephen to drop
> 
> mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch
> mm-memcontrol-use-the-node-native-slab-memory-counters.patch
> mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch
> mm-memcontrol-per-lruvec-stats-infrastructure.patch
> mm-memcontrol-account-slab-stats-per-lruvec.patch

Sorry about the wreckage.

Dropping these makes sense to me for the time being.

I'll fix up the init ordering issue.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Josef Bacik <josef@toxicpanda.com>,
	Michal Hocko <mhocko@suse.com>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Rik van Riel <riel@redhat.com>,
	linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-team@fb.com,
	Tony Lindgren <tony@atomide.com>,
	Russell King <rmk@armlinux.org.uk>,
	Yury Norov <ynorov@caviumnetworks.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure
Date: Wed, 31 May 2017 21:44:25 -0400	[thread overview]
Message-ID: <20170601014425.GA11815@cmpxchg.org> (raw)
In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org>

On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote:
> On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> 
> > Andrew, the 0day tester found a crash with this when special pages get
> > faulted. They're not charged to any cgroup and we'll deref NULL.
> > 
> > Can you include the following fix on top of this patch please? Thanks!
> 
> OK.  But this won't fix the init ordering crash which the arm folks are
> seeing?
> 
> I'm wondering if we should ask Stephen to drop
> 
> mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch
> mm-memcontrol-use-the-node-native-slab-memory-counters.patch
> mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch
> mm-memcontrol-per-lruvec-stats-infrastructure.patch
> mm-memcontrol-account-slab-stats-per-lruvec.patch

Sorry about the wreckage.

Dropping these makes sense to me for the time being.

I'll fix up the init ordering issue.

  parent reply	other threads:[~2017-06-01  1:44 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 18:17 [PATCH 0/6] mm: per-lruvec slab stats Johannes Weiner
2017-05-30 18:17 ` Johannes Weiner
2017-05-30 18:17 ` [PATCH 1/6] mm: vmscan: delete unused pgdat_reclaimable_pages() Johannes Weiner
2017-05-30 18:17   ` Johannes Weiner
2017-05-30 21:50   ` Andrew Morton
2017-05-30 21:50     ` Andrew Morton
2017-05-30 22:02     ` Johannes Weiner
2017-05-30 22:02       ` Johannes Weiner
2017-05-30 18:17 ` [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Johannes Weiner
2017-05-30 18:17   ` Johannes Weiner
     [not found]   ` <20170530181724.27197-3-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2017-05-31  9:12     ` Heiko Carstens
2017-05-31  9:12       ` Heiko Carstens
2017-05-31  9:12       ` Heiko Carstens
2017-05-31 11:39       ` Heiko Carstens
2017-05-31 11:39         ` Heiko Carstens
2017-05-31 17:11         ` Yury Norov
2017-05-31 17:11           ` Yury Norov
2017-06-01 10:07           ` Michael Ellerman
2017-06-01 10:07             ` Michael Ellerman
2017-06-01 10:07             ` Michael Ellerman
2017-06-05 18:35             ` Johannes Weiner
2017-06-05 18:35               ` Johannes Weiner
2017-06-05 18:35               ` Johannes Weiner
     [not found]               ` <20170605183511.GA8915-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2017-06-05 21:38                 ` Andrew Morton
2017-06-05 21:38                   ` Andrew Morton
2017-06-05 21:38                   ` Andrew Morton
2017-06-07 16:20                   ` Johannes Weiner
2017-06-07 16:20                     ` Johannes Weiner
2017-06-06  4:31                 ` Michael Ellerman
2017-06-06  4:31                   ` Michael Ellerman
2017-06-06  4:31                   ` Michael Ellerman
     [not found]                   ` <87k24prb3u.fsf-W0DJWXSxmBNbyGPkN3NxC2scP1bn1w/D@public.gmane.org>
2017-06-06 11:15                     ` Michael Ellerman
2017-06-06 11:15                       ` Michael Ellerman
2017-06-06 11:15                       ` Michael Ellerman
     [not found]                       ` <87mv9lpdsr.fsf-W0DJWXSxmBNbyGPkN3NxC2scP1bn1w/D@public.gmane.org>
2017-06-06 14:33                         ` Johannes Weiner
2017-06-06 14:33                           ` Johannes Weiner
2017-06-06 14:33                           ` Johannes Weiner
2017-05-30 18:17 ` [PATCH 3/6] mm: memcontrol: use the node-native slab memory counters Johannes Weiner
2017-05-30 18:17   ` Johannes Weiner
     [not found]   ` <20170530181724.27197-4-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2017-06-03 17:39     ` Vladimir Davydov
2017-06-03 17:39       ` Vladimir Davydov
2017-06-03 17:39       ` Vladimir Davydov
2017-05-30 18:17 ` [PATCH 4/6] mm: memcontrol: use generic mod_memcg_page_state for kmem pages Johannes Weiner
2017-05-30 18:17   ` Johannes Weiner
2017-06-03 17:40   ` Vladimir Davydov
2017-06-03 17:40     ` Vladimir Davydov
2017-05-30 18:17 ` [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure Johannes Weiner
2017-05-30 18:17   ` Johannes Weiner
2017-05-31 17:14   ` Johannes Weiner
2017-05-31 17:14     ` Johannes Weiner
2017-05-31 17:14     ` Johannes Weiner
     [not found]     ` <20170531171450.GA10481-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2017-05-31 18:18       ` Andrew Morton
2017-05-31 18:18         ` Andrew Morton
2017-05-31 18:18         ` Andrew Morton
     [not found]         ` <20170531111821.14ebeee4a4181583fe6fac46-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2017-05-31 19:02           ` Tony Lindgren
2017-05-31 19:02             ` Tony Lindgren
2017-05-31 19:02             ` Tony Lindgren
2017-05-31 22:03             ` Stephen Rothwell
2017-05-31 22:03               ` Stephen Rothwell
2017-06-01  1:44           ` Johannes Weiner [this message]
2017-06-01  1:44             ` Johannes Weiner
2017-06-01  1:44             ` Johannes Weiner
     [not found]   ` <20170530181724.27197-6-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2017-06-03 17:50     ` Vladimir Davydov
2017-06-03 17:50       ` Vladimir Davydov
2017-06-03 17:50       ` Vladimir Davydov
2017-06-05 17:53       ` Johannes Weiner
2017-06-05 17:53         ` Johannes Weiner
2017-06-05 17:53         ` Johannes Weiner
2017-05-30 18:17 ` [PATCH 6/6] mm: memcontrol: account slab stats per lruvec Johannes Weiner
2017-05-30 18:17   ` Johannes Weiner
2017-06-03 17:54   ` Vladimir Davydov
2017-06-03 17:54     ` Vladimir Davydov
2017-06-05 16:52   ` [6/6] " Guenter Roeck
2017-06-05 16:52     ` Guenter Roeck
2017-06-05 17:52     ` Johannes Weiner
2017-06-05 17:52       ` Johannes Weiner
2017-06-05 17:52       ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170601014425.GA11815@cmpxchg.org \
    --to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org \
    --cc=kernel-team-b10kYP2dOMg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-IBi9RG/b67k@public.gmane.org \
    --cc=riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=rmk-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ynorov-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.