All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/7] drm/i915: Use a loop for the "three times for luck" DPLL procedure
Date: Thu, 1 Jun 2017 19:14:49 +0300	[thread overview]
Message-ID: <20170601161449.GR12629@intel.com> (raw)
In-Reply-To: <20170601144851.GW11742@nuc-i3427.alporthouse.com>

On Thu, Jun 01, 2017 at 03:48:51PM +0100, Chris Wilson wrote:
> On Thu, Jun 01, 2017 at 05:36:15PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > The magic "enable the  DPLL three times" sequence feels like it
> > deserves a loop.
> 
> Hmm, I thought once upon a time we figured out what the magic was about.
> Or was that another loop?

At least I've never tried to understand this particular loop. The
VGA_MODE_DISABLE thing I did manage to figure out. Whether that might
have been a contributing factor for adding this loop is unclear.

We actually have a couple more DPLL writes just before the loop, so we
might want consider folding those into the loop as well.

> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-06-01 16:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 14:36 [PATCH 0/7] drm/i915: Pipe A quirk rework ville.syrjala
2017-06-01 14:36 ` [PATCH 1/7] drm/i915: Fix deadlock witha the pipe A quirk during resume ville.syrjala
2017-06-01 14:47   ` [Intel-gfx] " Jani Nikula
2017-06-01 16:01     ` Ville Syrjälä
2017-06-01 16:01       ` [Intel-gfx] " Ville Syrjälä
2017-06-02  7:04       ` Jani Nikula
2017-06-02  7:04         ` [Intel-gfx] " Jani Nikula
2017-06-01 14:36 ` [PATCH 2/7] drm/i915: Plumb the correct acquire ctx into intel_crtc_disable_noatomic() ville.syrjala
2017-06-01 14:36   ` ville.syrjala
2017-06-01 14:48   ` [Intel-gfx] " Jani Nikula
2017-06-01 16:05     ` Ville Syrjälä
2017-06-01 16:05       ` [Intel-gfx] " Ville Syrjälä
2017-06-01 17:07       ` Ville Syrjälä
2017-06-01 17:07         ` Ville Syrjälä
2017-06-01 14:36 ` [PATCH 3/7] drm/i915: Use a loop for the "three times for luck" DPLL procedure ville.syrjala
2017-06-01 14:48   ` Chris Wilson
2017-06-01 16:14     ` Ville Syrjälä [this message]
2017-06-01 14:49   ` Jani Nikula
2017-06-01 14:36 ` [PATCH 4/7] drm/i915: Add i830 "pipes power well" ville.syrjala
2017-06-01 14:46   ` Chris Wilson
2017-06-01 16:25     ` Ville Syrjälä
2017-06-06  7:04   ` Maarten Lankhorst
2017-06-06 10:32     ` Ville Syrjälä
2017-06-01 14:36 ` [PATCH 5/7] drm/i915: Drop pipe A quirk for Toshiba Protege R205-S209 ville.syrjala
2017-06-01 14:36 ` [PATCH 6/7] drm/i915: Drop pipe A quirk for Thinkapd T60 ville.syrjala
2017-06-01 14:36 ` [PATCH 7/7] drm/i915: Remove pipe A quirk remnants ville.syrjala
2017-06-01 14:41 ` [PATCH 0/7] drm/i915: Pipe A quirk rework Chris Wilson
2017-06-01 14:59 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-06-15 13:16 ` [PATCH 0/7] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170601161449.GR12629@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.