All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 5/5] ARM: dts: vf-colibri-eval: use IRQ_TYPE_* to specify irq flags
Date: Sun, 4 Jun 2017 11:49:03 +0800	[thread overview]
Message-ID: <20170604034902.GC4094@dragon> (raw)
In-Reply-To: <20170526180609.2699-5-uwe@kleine-koenig.org>

On Fri, May 26, 2017 at 08:06:09PM +0200, Uwe Kleine-K?nig wrote:
> According to the binding documentation and the source code the
> vf610-gpio controller takes IRQ_TYPE_* as its flags values, not
> GPIO_ACTIVE_*.
> 
> This patch uses the right variable type which yields the same result
> when compiled. Note that this might be wrong and actually
> IRQ_TYPE_LEVEL_LOW is intended by the dt author.
> 
> Signed-off-by: Uwe Kleine-K?nig <uwe@kleine-koenig.org>
> ---
> Hello,
> 
> can somebody with the hardware or it's documentation please check which
> flag is the right one?

@Stefan, can you help to confirm?

Shawn

> 
> Best regards
> Uwe
> 
>  arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> index 091b738041a0..3e0c84d79c43 100644
> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> @@ -117,7 +117,7 @@
>  		clocks = <&clk16m>;
>  		spi-max-frequency = <10000000>;
>  		interrupt-parent = <&gpio1>;
> -		interrupts = <11 GPIO_ACTIVE_LOW>;
> +		interrupts = <11 IRQ_TYPE_EDGE_RISING>;
>  	};
>  };
>  
> -- 
> 2.11.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Uwe Kleine-König"
	<uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>,
	"Stefan Agner" <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RFC 5/5] ARM: dts: vf-colibri-eval: use IRQ_TYPE_* to specify irq flags
Date: Sun, 4 Jun 2017 11:49:03 +0800	[thread overview]
Message-ID: <20170604034902.GC4094@dragon> (raw)
In-Reply-To: <20170526180609.2699-5-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>

On Fri, May 26, 2017 at 08:06:09PM +0200, Uwe Kleine-König wrote:
> According to the binding documentation and the source code the
> vf610-gpio controller takes IRQ_TYPE_* as its flags values, not
> GPIO_ACTIVE_*.
> 
> This patch uses the right variable type which yields the same result
> when compiled. Note that this might be wrong and actually
> IRQ_TYPE_LEVEL_LOW is intended by the dt author.
> 
> Signed-off-by: Uwe Kleine-König <uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>
> ---
> Hello,
> 
> can somebody with the hardware or it's documentation please check which
> flag is the right one?

@Stefan, can you help to confirm?

Shawn

> 
> Best regards
> Uwe
> 
>  arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> index 091b738041a0..3e0c84d79c43 100644
> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> @@ -117,7 +117,7 @@
>  		clocks = <&clk16m>;
>  		spi-max-frequency = <10000000>;
>  		interrupt-parent = <&gpio1>;
> -		interrupts = <11 GPIO_ACTIVE_LOW>;
> +		interrupts = <11 IRQ_TYPE_EDGE_RISING>;
>  	};
>  };
>  
> -- 
> 2.11.0
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-06-04  3:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 18:06 [PATCH 1/5] dts: gpio_atmel: adapt binding doc to reality Uwe Kleine-König
2017-05-26 18:06 ` Uwe Kleine-König
     [not found] ` <20170526180609.2699-1-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>
2017-05-26 18:06   ` [PATCH RFC 2/5] ARM: dts: am335x-baltos: use IRQ_TYPE_* to specify irq flags Uwe Kleine-König
2017-05-26 18:06     ` Uwe Kleine-König
2017-05-31 17:19     ` Tony Lindgren
2017-05-31 17:19       ` Tony Lindgren
2017-05-31 17:22       ` Yegor Yefremov
2017-05-31 17:22         ` Yegor Yefremov
     [not found]         ` <CAGm1_ktJp+3t9ExuFJhKTmbM63yt-82PGP26KkEHGqK-tnfWRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-06 14:33           ` Yegor Yefremov
2017-06-06 14:33             ` Yegor Yefremov
     [not found]             ` <CAGm1_kuKxVOetzMLdnVO+xQ7egX+paqOHLS+ckz6nFwKD5QBuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-12  7:32               ` Tony Lindgren
2017-06-12  7:32                 ` Tony Lindgren
2017-05-26 18:06   ` [PATCH RFC 4/5] ARM: dts: tegra: " Uwe Kleine-König
2017-05-26 18:06     ` Uwe Kleine-König
2017-05-26 18:06 ` [PATCH RFC 3/5] ARM: dts: at91-sama5d4: " Uwe Kleine-König
2017-05-26 18:06   ` Uwe Kleine-König
2017-05-26 19:17   ` Marek Vasut
2017-05-26 19:17     ` Marek Vasut
2017-05-31  9:52     ` Alexandre Belloni
2017-05-31  9:52       ` Alexandre Belloni
2017-05-26 18:06 ` [PATCH RFC 5/5] ARM: dts: vf-colibri-eval: " Uwe Kleine-König
2017-05-26 18:06   ` Uwe Kleine-König
2017-06-04  3:49   ` Shawn Guo [this message]
2017-06-04  3:49     ` Shawn Guo
2017-06-05  2:17     ` Stefan Agner
2017-06-05  2:17       ` Stefan Agner
2017-05-26 18:52 ` [PATCH 1/5] dts: gpio_atmel: adapt binding doc to reality Andrew Lunn
2017-05-26 18:52   ` Andrew Lunn
2017-05-26 19:07   ` [PATCH v2 " Uwe Kleine-König
2017-05-26 19:07     ` Uwe Kleine-König
2017-05-31  9:52     ` Alexandre Belloni
2017-05-31  9:52       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170604034902.GC4094@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.