From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures
Date: Mon, 5 Jun 2017 07:33:00 +0200 [thread overview]
Message-ID: <20170605053300.GC19480@lst.de> (raw)
In-Reply-To: <fda3105a-706d-0b38-6ff8-8b69749d8374@grimberg.me>
On Sun, Jun 04, 2017@05:59:06PM +0300, Sagi Grimberg wrote:
>> +struct nvme_ns_identifier_hdr {
>> + __u8 nidt;
>> + __u8 nidl;
>> + __le16 reserved;
>> +};
>
> Nit: _hdr is usually associated with a message or alike.
>
> Maybe nvme_ns_id_desc is more consistent with the spec language.
The descriptor itself includes the actual value, that's why
I suggested adding the _hdr prefix. But I'm fine going either way.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
Hannes Reinecke <hare@suse.de>,
maxg@mellanox.com,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures
Date: Mon, 5 Jun 2017 07:33:00 +0200 [thread overview]
Message-ID: <20170605053300.GC19480@lst.de> (raw)
In-Reply-To: <fda3105a-706d-0b38-6ff8-8b69749d8374@grimberg.me>
On Sun, Jun 04, 2017 at 05:59:06PM +0300, Sagi Grimberg wrote:
>> +struct nvme_ns_identifier_hdr {
>> + __u8 nidt;
>> + __u8 nidl;
>> + __le16 reserved;
>> +};
>
> Nit: _hdr is usually associated with a message or alike.
>
> Maybe nvme_ns_id_desc is more consistent with the spec language.
The descriptor itself includes the actual value, that's why
I suggested adding the _hdr prefix. But I'm fine going either way.
next prev parent reply other threads:[~2017-06-05 5:33 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 10:36 [PATCH v4 0/8] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 10:36 ` [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 14:43 ` Sagi Grimberg
2017-06-04 14:43 ` Sagi Grimberg
2017-06-04 14:59 ` Sagi Grimberg
2017-06-04 14:59 ` Sagi Grimberg
2017-06-05 5:33 ` Christoph Hellwig [this message]
2017-06-05 5:33 ` Christoph Hellwig
2017-06-06 6:23 ` Hannes Reinecke
2017-06-06 6:23 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 2/8] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 14:43 ` Sagi Grimberg
2017-06-04 14:43 ` Sagi Grimberg
2017-06-04 10:36 ` [PATCH v4 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 15:00 ` Sagi Grimberg
2017-06-04 15:00 ` Sagi Grimberg
2017-06-05 5:35 ` Christoph Hellwig
2017-06-05 5:35 ` Christoph Hellwig
2017-06-06 12:04 ` Johannes Thumshirn
2017-06-06 12:04 ` Johannes Thumshirn
2017-06-06 6:23 ` Hannes Reinecke
2017-06-06 6:23 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 4/8] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 11:46 ` Max Gurtovoy
2017-06-04 11:46 ` Max Gurtovoy
2017-06-04 15:01 ` Sagi Grimberg
2017-06-04 15:01 ` Sagi Grimberg
2017-06-06 6:24 ` Hannes Reinecke
2017-06-06 6:24 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 5/8] nvme: get list of namespace descriptors Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 15:06 ` Sagi Grimberg
2017-06-04 15:06 ` Sagi Grimberg
2017-06-05 5:38 ` Christoph Hellwig
2017-06-05 5:38 ` Christoph Hellwig
2017-06-06 7:15 ` Sagi Grimberg
2017-06-06 7:15 ` Sagi Grimberg
2017-06-06 6:24 ` Hannes Reinecke
2017-06-06 6:24 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 6/8] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 15:06 ` Sagi Grimberg
2017-06-04 15:06 ` Sagi Grimberg
2017-06-04 10:36 ` [PATCH v4 7/8] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 15:08 ` Sagi Grimberg
2017-06-04 15:08 ` Sagi Grimberg
2017-06-05 5:45 ` Christoph Hellwig
2017-06-05 5:45 ` Christoph Hellwig
2017-06-06 6:25 ` Hannes Reinecke
2017-06-06 6:25 ` Hannes Reinecke
2017-06-04 10:36 ` [PATCH v4 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn
2017-06-04 10:36 ` Johannes Thumshirn
2017-06-04 14:06 ` Max Gurtovoy
2017-06-04 14:06 ` Max Gurtovoy
2017-06-04 15:09 ` Sagi Grimberg
2017-06-04 15:09 ` Sagi Grimberg
2017-06-05 8:37 ` Christoph Hellwig
2017-06-05 8:37 ` Christoph Hellwig
2017-06-06 6:26 ` Hannes Reinecke
2017-06-06 6:26 ` Hannes Reinecke
2017-06-05 5:32 ` [PATCH v4 0/8] Implement NVMe Namespace Descriptor Identification Christoph Hellwig
2017-06-05 5:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605053300.GC19480@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.