From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever
Date: Mon, 5 Jun 2017 10:18:17 +0200 [thread overview]
Message-ID: <20170605081817.GA22122@lst.de> (raw)
In-Reply-To: <bb2780a8-63af-4d58-6c78-b03152de0439@grimberg.me>
On Sun, Jun 04, 2017@06:28:15PM +0300, Sagi Grimberg wrote:
>
>> I think we need the NVME_CTRL_SCHED_RESET state. In fact I'm pretty
>> sure some time in the past I already had it in a local tree as a
>> generalization of rdma and loop already use NVME_CTRL_RESETTING
>> (they set it before queueing the reset work).
>
> I don't remember having it, but I might be wrong...
>
> Can you explain again why you think we need it? Sorry for being
> difficult, but I'm not exactly sure why it makes things better
> or simpler.
Motly that we can treat a controller as under reset before scheduling
the reset work, both to prevent multiple schedules, and to make
checks like the one in nvme_should_reset robus.
But I think something along the lines of the earlier patch from
Rakesh that just sets the RESETTING state earlier + the cancel_work_sync
suggested by you should also work for that purpose. So maybe that's
the way to go after all.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Rakesh Pandit <rakesh@tuxera.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>, Keith Busch <keith.busch@intel.com>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever
Date: Mon, 5 Jun 2017 10:18:17 +0200 [thread overview]
Message-ID: <20170605081817.GA22122@lst.de> (raw)
In-Reply-To: <bb2780a8-63af-4d58-6c78-b03152de0439@grimberg.me>
On Sun, Jun 04, 2017 at 06:28:15PM +0300, Sagi Grimberg wrote:
>
>> I think we need the NVME_CTRL_SCHED_RESET state. In fact I'm pretty
>> sure some time in the past I already had it in a local tree as a
>> generalization of rdma and loop already use NVME_CTRL_RESETTING
>> (they set it before queueing the reset work).
>
> I don't remember having it, but I might be wrong...
>
> Can you explain again why you think we need it? Sorry for being
> difficult, but I'm not exactly sure why it makes things better
> or simpler.
Motly that we can treat a controller as under reset before scheduling
the reset work, both to prevent multiple schedules, and to make
checks like the one in nvme_should_reset robus.
But I think something along the lines of the earlier patch from
Rakesh that just sets the RESETTING state earlier + the cancel_work_sync
suggested by you should also work for that purpose. So maybe that's
the way to go after all.
next prev parent reply other threads:[~2017-06-05 8:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 7:16 [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Rakesh Pandit
2017-05-30 7:16 ` Rakesh Pandit
2017-05-30 9:36 ` Christoph Hellwig
2017-05-30 9:36 ` Christoph Hellwig
2017-05-30 10:18 ` Sagi Grimberg
2017-05-30 10:18 ` Sagi Grimberg
2017-05-30 14:23 ` Rakesh Pandit
2017-05-30 14:23 ` Rakesh Pandit
2017-06-01 11:43 ` Christoph Hellwig
2017-06-01 11:43 ` Christoph Hellwig
2017-06-01 12:28 ` Rakesh Pandit
2017-06-01 12:28 ` Rakesh Pandit
2017-06-01 12:35 ` Christoph Hellwig
2017-06-01 12:35 ` Christoph Hellwig
2017-06-01 12:36 ` Rakesh Pandit
2017-06-01 12:36 ` Rakesh Pandit
2017-06-01 12:46 ` Christoph Hellwig
2017-06-01 12:46 ` Christoph Hellwig
2017-06-01 14:56 ` Ming Lei
2017-06-01 14:56 ` Ming Lei
2017-06-01 19:33 ` Rakesh Pandit
2017-06-01 19:33 ` Rakesh Pandit
2017-06-02 1:42 ` Ming Lei
2017-06-02 1:42 ` Ming Lei
2017-06-04 15:28 ` Sagi Grimberg
2017-06-04 15:28 ` Sagi Grimberg
2017-06-05 8:18 ` Christoph Hellwig [this message]
2017-06-05 8:18 ` Christoph Hellwig
2017-06-05 10:52 ` Rakesh Pandit
2017-06-05 10:52 ` Rakesh Pandit
2017-06-05 11:09 ` Sagi Grimberg
2017-06-05 11:09 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605081817.GA22122@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.