[PATCH] kmscube: add opengl to REQUIRED_DISTRO_FEATURES

[PATCH] kmscube: add opengl to REQUIRED_DISTRO_FEATURES

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

kmscube depends on virtual/libgles2, virtual/egl (provided
by mesa) and gstreamer1.0 which require opengl in DISTRO_FEATURES.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-graphics/kmscube/kmscube_git.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/kmscube/kmscube_git.bb b/meta/recipes-graphics/kmscube/kmscube_git.bb
index 0ec5b2a7fa..9050671ab1 100644
--- a/meta/recipes-graphics/kmscube/kmscube_git.bb
+++ b/meta/recipes-graphics/kmscube/kmscube_git.bb
@@ -11,4 +11,6 @@ SRC_URI = "git://anongit.freedesktop.org/mesa/kmscube;branch=master;protocol=git
 
 S = "${WORKDIR}/git"
 
-inherit autotools pkgconfig
+inherit autotools pkgconfig distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "opengl"
-- 
2.11.0

Re: [PATCH] kmscube: add opengl to REQUIRED_DISTRO_FEATURES

[Denys Dmytriyenko]

On Mon, Jun 05, 2017 at 03:05:57PM +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> kmscube depends on virtual/libgles2, virtual/egl (provided
> by mesa) and gstreamer1.0 which require opengl in DISTRO_FEATURES.

libgles2 and egl are not only provided by mesa!


> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta/recipes-graphics/kmscube/kmscube_git.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/kmscube/kmscube_git.bb b/meta/recipes-graphics/kmscube/kmscube_git.bb
> index 0ec5b2a7fa..9050671ab1 100644
> --- a/meta/recipes-graphics/kmscube/kmscube_git.bb
> +++ b/meta/recipes-graphics/kmscube/kmscube_git.bb
> @@ -11,4 +11,6 @@ SRC_URI = "git://anongit.freedesktop.org/mesa/kmscube;branch=master;protocol=git
>  
>  S = "${WORKDIR}/git"
>  
> -inherit autotools pkgconfig
> +inherit autotools pkgconfig distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES = "opengl"
> -- 
> 2.11.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] kmscube: add opengl to REQUIRED_DISTRO_FEATURES

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denis@denix.org]
> Sent: Tuesday, June 06, 2017 04:39
> To: Huang, Jie (Jackie)
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] kmscube: add opengl to
> REQUIRED_DISTRO_FEATURES
> 
> On Mon, Jun 05, 2017 at 03:05:57PM +0800, jackie.huang@windriver.com
> wrote:
> > From: Jackie Huang <jackie.huang@windriver.com>
> >
> > kmscube depends on virtual/libgles2, virtual/egl (provided
> > by mesa) and gstreamer1.0 which require opengl in DISTRO_FEATURES.
> 
> libgles2 and egl are not only provided by mesa!

Yes, I aware of that, but I only found that they are provided by mesa in oe-core
and mesa is the PREFERRED_PROVIDER in oe-core, so I just mentioned mesa.

Do you think I should mention other providers from other layers or not mention
the provider at all?

Thanks,
Jackie

> 
> 
> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> > ---
> >  meta/recipes-graphics/kmscube/kmscube_git.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-graphics/kmscube/kmscube_git.bb b/meta/recipes-
> graphics/kmscube/kmscube_git.bb
> > index 0ec5b2a7fa..9050671ab1 100644
> > --- a/meta/recipes-graphics/kmscube/kmscube_git.bb
> > +++ b/meta/recipes-graphics/kmscube/kmscube_git.bb
> > @@ -11,4 +11,6 @@ SRC_URI =
> "git://anongit.freedesktop.org/mesa/kmscube;branch=master;protocol=git
> >
> >  S = "${WORKDIR}/git"
> >
> > -inherit autotools pkgconfig
> > +inherit autotools pkgconfig distro_features_check
> > +
> > +REQUIRED_DISTRO_FEATURES = "opengl"
> > --
> > 2.11.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core