From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 1/2] parser: allow ct eventmask set new,related
Date: Wed, 7 Jun 2017 12:37:06 +0200 [thread overview]
Message-ID: <20170607103706.GA9280@salvia> (raw)
In-Reply-To: <20170607102410.21024-1-fw@strlen.de>
On Wed, Jun 07, 2017 at 12:24:09PM +0200, Florian Westphal wrote:
> In case of bitmask types (tcp flags, ct eventmask) nft
> allows to use comma operator to test multiple values, i.e.
> tcp flags syn,ack ct event new,destroy etc.
>
> But currently nft fails to use this when used in a statement, i.e.
> ... ct eventmask set new,destroy
> gives:
> syntax error, unexpected comma
>
> This allows makes this work, it is the same as
> ct eventmask set new|destroy
>
> Suggested-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Much nicer! Thanks for working on this!
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2017-06-07 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 10:24 [PATCH nft 1/2] parser: allow ct eventmask set new,related Florian Westphal
2017-06-07 10:24 ` [PATCH nft 2/2] src: rename ct eventmask to event Florian Westphal
2017-06-07 10:38 ` Pablo Neira Ayuso
2017-06-07 10:38 ` Pablo Neira Ayuso
2017-06-07 11:07 ` Florian Westphal
2017-06-07 11:27 ` Pablo Neira Ayuso
2017-06-07 15:31 ` Florian Westphal
2017-06-07 10:37 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607103706.GA9280@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.