From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] src: rename ct eventmask to event
Date: Wed, 7 Jun 2017 17:31:12 +0200 [thread overview]
Message-ID: <20170607153112.GB23661@strlen.de> (raw)
In-Reply-To: <20170607112750.GA9759@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Jun 07, 2017 at 01:07:51PM +0200, Florian Westphal wrote:
> > I could of course stick a check for the key type into
> > netlink_delinerize.c but thats ugly.
> >
> > Alterntively I could hook into ct_stmt_print and dissect there.
> >
> > Any idea/preference?
>
> I suggest you always use the comma separated one to print this.
I've pushed a revised version of this patch + the 'use comma' patch
to master, thanks!
next prev parent reply other threads:[~2017-06-07 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 10:24 [PATCH nft 1/2] parser: allow ct eventmask set new,related Florian Westphal
2017-06-07 10:24 ` [PATCH nft 2/2] src: rename ct eventmask to event Florian Westphal
2017-06-07 10:38 ` Pablo Neira Ayuso
2017-06-07 10:38 ` Pablo Neira Ayuso
2017-06-07 11:07 ` Florian Westphal
2017-06-07 11:27 ` Pablo Neira Ayuso
2017-06-07 15:31 ` Florian Westphal [this message]
2017-06-07 10:37 ` [PATCH nft 1/2] parser: allow ct eventmask set new,related Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607153112.GB23661@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.