All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Theodore Ts'o <tytso@mit.edu>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Eric Biggers <ebiggers3@gmail.com>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-hardening@lists.openwall.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Miller <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Stephan Mueller <smueller@chronox.de>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [kernel-hardening] Re: [PATCH v3 04/13] crypto/rng: ensure that the RNG is ready before using
Date: Wed, 7 Jun 2017 18:37:50 +0100	[thread overview]
Message-ID: <20170607173749.GC8330@leverpostej> (raw)
In-Reply-To: <20170606170319.5eva2yoxxeru5p74@thunk.org>

On Tue, Jun 06, 2017 at 01:03:19PM -0400, Theodore Ts'o wrote:
> The other approach is to find a way to have initialized "seed" entropy
> which we can count on at every boot.  The problem is that this is very
> much dependent on how the bootloader works.  It's easy to say "store
> it in the kernel", but where the kernel is stored varies greatly from
> architecture to architecture.  In some cases, the kernel can stored in
> ROM, where it can't be modified at all.
> 
> It might be possible, for example, to store a cryptographic key in a
> UEFI boot-services variable, where the key becomes inaccessible after
> the boot-time services terminate.  But you also need either a reliable
> time-of-day clock, or a reliable counter which is incremented each
> time the system that boots, and which can't be messed with by an
> attacker, or trivially reset by a clueless user/sysadmin.

FWIW, EFI has an (optional) EFI_RNG_PROTOCOL, that we currently use to
seed the kernel's entropy pool. The EFI stub creates a config table with
the entropy, which the kernel reads.

This is re-seeded prior to kexec() to avoid the entropy being recycled.

See commits:

636259880a7e7d34 ("efi: Add support for seeding the RNG from a UEFI config table")
568bc4e87033d232 (" efi/arm*/libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table")

Unfortunately, I beleive that support for the protocol is currently rare
in practice.

Thanks,
Mark.

  parent reply	other threads:[~2017-06-07 17:37 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06  0:50 [kernel-hardening] [PATCH v3 00/13] Unseeded In-Kernel Randomness Fixes Jason A. Donenfeld
2017-06-06  0:50 ` Jason A. Donenfeld
2017-06-06  0:50 ` [kernel-hardening] [PATCH v3 01/13] random: add synchronous API for the urandom pool Jason A. Donenfeld
2017-06-06  0:50   ` Jason A. Donenfeld
2017-06-06  0:50 ` [kernel-hardening] [PATCH v3 02/13] random: add get_random_{bytes,u32,u64,int,long,once}_wait family Jason A. Donenfeld
2017-06-06  0:50   ` Jason A. Donenfeld
2017-06-06  5:11   ` [kernel-hardening] " Jeffrey Walton
2017-06-06  5:11     ` Jeffrey Walton
2017-06-06 12:21     ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 12:21       ` Jason A. Donenfeld
2017-06-06  0:50 ` [kernel-hardening] [PATCH v3 03/13] random: invalidate batched entropy after crng init Jason A. Donenfeld
2017-06-06  0:50   ` Jason A. Donenfeld
2017-06-07 17:42   ` [kernel-hardening] " kbuild test robot
2017-06-07 17:42     ` kbuild test robot
2017-06-07 18:16     ` [kernel-hardening] " Jason A. Donenfeld
2017-06-07 18:16       ` Jason A. Donenfeld
2017-06-06  0:50 ` [kernel-hardening] [PATCH v3 04/13] crypto/rng: ensure that the RNG is ready before using Jason A. Donenfeld
2017-06-06  0:50   ` Jason A. Donenfeld
2017-06-06  3:00   ` [kernel-hardening] " Theodore Ts'o
2017-06-06  3:00     ` Theodore Ts'o
2017-06-06  3:56     ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06  3:56       ` Jason A. Donenfeld
2017-06-06  4:44       ` [kernel-hardening] " Eric Biggers
2017-06-06 12:34         ` Jason A. Donenfeld
2017-06-06 15:23           ` Jason A. Donenfeld
2017-06-06 17:26             ` Eric Biggers
2017-06-06 17:30               ` Jason A. Donenfeld
2017-06-06 17:03           ` Theodore Ts'o
2017-06-06 17:28             ` Jason A. Donenfeld
2017-06-06 17:57             ` Stephan Müller
2017-06-06 18:01               ` Jason A. Donenfeld
2017-06-06 22:19             ` Henrique de Moraes Holschuh
2017-06-06 23:14               ` Theodore Ts'o
2017-06-07  5:00               ` Stephan Müller
2017-06-07 14:42                 ` Henrique de Moraes Holschuh
2017-06-07 14:42                   ` Henrique de Moraes Holschuh
2017-06-07 21:27                 ` [kernel-hardening] " Theodore Ts'o
2017-06-07 17:00               ` Daniel Micay
2017-06-07 17:26                 ` Mark Rutland
2017-06-08  3:59                   ` Daniel Micay
2017-06-07 17:37             ` Mark Rutland [this message]
2017-06-08 12:02       ` Kevin Easton
2017-06-08 12:02         ` Kevin Easton
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 05/13] security/keys: ensure RNG is seeded before use Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06 10:08   ` [kernel-hardening] " David Howells
2017-06-06 10:08     ` David Howells
2017-06-06 12:23     ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 12:23       ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 06/13] iscsi: " Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 07/13] ceph: ensure RNG is seeded before using Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 08/13] cifs: use get_random_u32 for 32-bit lock random Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 09/13] rhashtable: use get_random_u32 for hash_rnd Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 10/13] net/neighbor: use get_random_u32 for 32-bit hash random Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 11/13] net/route: use get_random_int for random counter Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 12/13] bluetooth/smp: ensure RNG is properly seeded before ECDH use Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld
2017-06-06  0:51 ` [kernel-hardening] [PATCH v3 13/13] random: warn when kernel uses unseeded randomness Jason A. Donenfeld
2017-06-06  0:51   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607173749.GC8330@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Jason@zx2c4.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=davem@davemloft.net \
    --cc=ebiggers3@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=smueller@chronox.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.