From: David Howells <dhowells@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dhowells@redhat.com, Theodore Ts'o <tytso@mit.edu>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Miller <davem@davemloft.net>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
David Safford <safford@us.ibm.com>
Subject: [kernel-hardening] Re: [PATCH v3 05/13] security/keys: ensure RNG is seeded before use
Date: Tue, 06 Jun 2017 11:08:49 +0100 [thread overview]
Message-ID: <26642.1496743729@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170606005108.5646-6-Jason@zx2c4.com>
Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> + key->serial = get_random_u32() >> 1;
If this may sleep, it must be interruptible.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dhowells@redhat.com, Theodore Ts'o <tytso@mit.edu>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Miller <davem@davemloft.net>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
David Safford <safford@us.ibm.com>
Subject: Re: [PATCH v3 05/13] security/keys: ensure RNG is seeded before use
Date: Tue, 06 Jun 2017 11:08:49 +0100 [thread overview]
Message-ID: <26642.1496743729@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170606005108.5646-6-Jason@zx2c4.com>
Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> + key->serial = get_random_u32() >> 1;
If this may sleep, it must be interruptible.
David
next prev parent reply other threads:[~2017-06-06 10:08 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 0:50 [kernel-hardening] [PATCH v3 00/13] Unseeded In-Kernel Randomness Fixes Jason A. Donenfeld
2017-06-06 0:50 ` Jason A. Donenfeld
2017-06-06 0:50 ` [kernel-hardening] [PATCH v3 01/13] random: add synchronous API for the urandom pool Jason A. Donenfeld
2017-06-06 0:50 ` Jason A. Donenfeld
2017-06-06 0:50 ` [kernel-hardening] [PATCH v3 02/13] random: add get_random_{bytes,u32,u64,int,long,once}_wait family Jason A. Donenfeld
2017-06-06 0:50 ` Jason A. Donenfeld
2017-06-06 5:11 ` [kernel-hardening] " Jeffrey Walton
2017-06-06 5:11 ` Jeffrey Walton
2017-06-06 12:21 ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 12:21 ` Jason A. Donenfeld
2017-06-06 0:50 ` [kernel-hardening] [PATCH v3 03/13] random: invalidate batched entropy after crng init Jason A. Donenfeld
2017-06-06 0:50 ` Jason A. Donenfeld
2017-06-07 17:42 ` [kernel-hardening] " kbuild test robot
2017-06-07 17:42 ` kbuild test robot
2017-06-07 18:16 ` [kernel-hardening] " Jason A. Donenfeld
2017-06-07 18:16 ` Jason A. Donenfeld
2017-06-06 0:50 ` [kernel-hardening] [PATCH v3 04/13] crypto/rng: ensure that the RNG is ready before using Jason A. Donenfeld
2017-06-06 0:50 ` Jason A. Donenfeld
2017-06-06 3:00 ` [kernel-hardening] " Theodore Ts'o
2017-06-06 3:00 ` Theodore Ts'o
2017-06-06 3:56 ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 3:56 ` Jason A. Donenfeld
2017-06-06 4:44 ` [kernel-hardening] " Eric Biggers
2017-06-06 12:34 ` Jason A. Donenfeld
2017-06-06 15:23 ` Jason A. Donenfeld
2017-06-06 17:26 ` Eric Biggers
2017-06-06 17:30 ` Jason A. Donenfeld
2017-06-06 17:03 ` Theodore Ts'o
2017-06-06 17:28 ` Jason A. Donenfeld
2017-06-06 17:57 ` Stephan Müller
2017-06-06 18:01 ` Jason A. Donenfeld
2017-06-06 22:19 ` Henrique de Moraes Holschuh
2017-06-06 23:14 ` Theodore Ts'o
2017-06-07 5:00 ` Stephan Müller
2017-06-07 14:42 ` Henrique de Moraes Holschuh
2017-06-07 14:42 ` Henrique de Moraes Holschuh
2017-06-07 21:27 ` [kernel-hardening] " Theodore Ts'o
2017-06-07 17:00 ` Daniel Micay
2017-06-07 17:26 ` Mark Rutland
2017-06-08 3:59 ` Daniel Micay
2017-06-07 17:37 ` Mark Rutland
2017-06-08 12:02 ` Kevin Easton
2017-06-08 12:02 ` Kevin Easton
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 05/13] security/keys: ensure RNG is seeded before use Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 10:08 ` David Howells [this message]
2017-06-06 10:08 ` David Howells
2017-06-06 12:23 ` [kernel-hardening] " Jason A. Donenfeld
2017-06-06 12:23 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 06/13] iscsi: " Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 07/13] ceph: ensure RNG is seeded before using Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 08/13] cifs: use get_random_u32 for 32-bit lock random Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 09/13] rhashtable: use get_random_u32 for hash_rnd Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 10/13] net/neighbor: use get_random_u32 for 32-bit hash random Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 11/13] net/route: use get_random_int for random counter Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 12/13] bluetooth/smp: ensure RNG is properly seeded before ECDH use Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
2017-06-06 0:51 ` [kernel-hardening] [PATCH v3 13/13] random: warn when kernel uses unseeded randomness Jason A. Donenfeld
2017-06-06 0:51 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26642.1496743729@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=safford@us.ibm.com \
--cc=tytso@mit.edu \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.