All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonsoo Kim <js1304@gmail.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Potapenko <glider@google.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	kernel-team@lge.com
Subject: Re: [PATCH v1 00/11] mm/kasan: support per-page shadow memory to reduce memory consumption
Date: Thu, 8 Jun 2017 11:43:05 +0900	[thread overview]
Message-ID: <20170608024303.GC27998@js1304-desktop> (raw)
In-Reply-To: <80f2f6f7-0a37-53dc-843e-1adbed4377fa@virtuozzo.com>

On Wed, May 31, 2017 at 07:31:53PM +0300, Andrey Ryabinin wrote:
> On 05/31/2017 08:50 AM, Joonsoo Kim wrote:
> >>> But the main win as I see it is that that's basically complete support
> >>> for 32-bit arches. People do ask about arm32 support:
> >>> https://groups.google.com/d/msg/kasan-dev/Sk6BsSPMRRc/Gqh4oD_wAAAJ
> >>> https://groups.google.com/d/msg/kasan-dev/B22vOFp-QWg/EVJPbrsgAgAJ
> >>> and probably mips32 is relevant as well.
> >>
> >> I don't see how above is relevant for 32-bit arches. Current design
> >> is perfectly fine for 32-bit arches. I did some POC arm32 port couple years
> >> ago - https://github.com/aryabinin/linux/commits/kasan/arm_v0_1
> >> It has some ugly hacks and non-critical bugs. AFAIR it also super-slow because I (mistakenly) 
> >> made shadow memory uncached. But otherwise it works.
> > 
> > Could you explain that where is the code to map shadow memory uncached?
> > I don't find anything related to it.
> > 
> 
> I didn't set set any cache policy (L_PTE_MT_*) on shadow mapping (see set_pte_at() calls )
> which means it's L_PTE_MT_UNCACHED 

Thanks for pointing it out.

I did some quick tests and found that it's not super(?) slow on my
QEMU. Maybe, it would be different with real machine.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <js1304@gmail.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Potapenko <glider@google.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	kernel-team@lge.com
Subject: Re: [PATCH v1 00/11] mm/kasan: support per-page shadow memory to reduce memory consumption
Date: Thu, 8 Jun 2017 11:43:05 +0900	[thread overview]
Message-ID: <20170608024303.GC27998@js1304-desktop> (raw)
In-Reply-To: <80f2f6f7-0a37-53dc-843e-1adbed4377fa@virtuozzo.com>

On Wed, May 31, 2017 at 07:31:53PM +0300, Andrey Ryabinin wrote:
> On 05/31/2017 08:50 AM, Joonsoo Kim wrote:
> >>> But the main win as I see it is that that's basically complete support
> >>> for 32-bit arches. People do ask about arm32 support:
> >>> https://groups.google.com/d/msg/kasan-dev/Sk6BsSPMRRc/Gqh4oD_wAAAJ
> >>> https://groups.google.com/d/msg/kasan-dev/B22vOFp-QWg/EVJPbrsgAgAJ
> >>> and probably mips32 is relevant as well.
> >>
> >> I don't see how above is relevant for 32-bit arches. Current design
> >> is perfectly fine for 32-bit arches. I did some POC arm32 port couple years
> >> ago - https://github.com/aryabinin/linux/commits/kasan/arm_v0_1
> >> It has some ugly hacks and non-critical bugs. AFAIR it also super-slow because I (mistakenly) 
> >> made shadow memory uncached. But otherwise it works.
> > 
> > Could you explain that where is the code to map shadow memory uncached?
> > I don't find anything related to it.
> > 
> 
> I didn't set set any cache policy (L_PTE_MT_*) on shadow mapping (see set_pte_at() calls )
> which means it's L_PTE_MT_UNCACHED 

Thanks for pointing it out.

I did some quick tests and found that it's not super(?) slow on my
QEMU. Maybe, it would be different with real machine.

Thanks.

  reply	other threads:[~2017-06-08  2:43 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16  1:16 [PATCH v1 00/11] mm/kasan: support per-page shadow memory to reduce memory consumption js1304
2017-05-16  1:16 ` js1304
2017-05-16  1:16 ` [PATCH v1 01/11] mm/kasan: rename XXX_is_zero to XXX_is_nonzero js1304
2017-05-16  1:16 ` [PATCH v1 02/11] mm/kasan: don't fetch the next shadow value speculartively js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 03/11] mm/kasan: handle unaligned end address in zero_pte_populate js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 04/11] mm/kasan: extend kasan_populate_zero_shadow() js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 05/11] mm/kasan: introduce per-page shadow memory infrastructure js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 06/11] mm/kasan: mark/unmark the target range that is for original shadow memory js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 07/11] x86/kasan: use per-page " js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 08/11] mm/kasan: support on-demand shadow allocation/mapping js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 09/11] x86/kasan: support on-demand shadow mapping js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 10/11] mm/kasan: support dynamic shadow memory free js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:16 ` [PATCH v1 11/11] mm/kasan: change the order of shadow memory check js1304
2017-05-16  1:16   ` js1304
2017-05-16  1:28 ` [PATCH(RE-RESEND) v1 01/11] mm/kasan: rename _is_zero to _is_nonzero Joonsoo Kim
2017-05-16  1:28   ` Joonsoo Kim
2017-05-16  4:34 ` [PATCH v1 00/11] mm/kasan: support per-page shadow memory to reduce memory consumption Dmitry Vyukov
2017-05-16  4:34   ` Dmitry Vyukov
2017-05-16  4:47   ` Dmitry Vyukov
2017-05-16  4:47     ` Dmitry Vyukov
2017-05-16  6:23   ` Joonsoo Kim
2017-05-16  6:23     ` Joonsoo Kim
2017-05-16 20:49     ` Dmitry Vyukov
2017-05-16 20:49       ` Dmitry Vyukov
2017-05-17  7:23       ` Joonsoo Kim
2017-05-17  7:23         ` Joonsoo Kim
2017-05-17  7:25         ` Joonsoo Kim
2017-05-17  7:25           ` Joonsoo Kim
2017-05-24  6:57       ` Dmitry Vyukov
2017-05-24  6:57         ` Dmitry Vyukov
2017-05-24  7:45         ` Joonsoo Kim
2017-05-24  7:45           ` Joonsoo Kim
2017-05-24 17:19           ` Dmitry Vyukov
2017-05-24 17:19             ` Dmitry Vyukov
2017-05-25  0:41             ` Joonsoo Kim
2017-05-25  0:41               ` Joonsoo Kim
2017-05-29 15:07               ` Dmitry Vyukov
2017-05-29 15:07                 ` Dmitry Vyukov
2017-05-29 15:12                 ` Dmitry Vyukov
2017-05-29 15:12                   ` Dmitry Vyukov
2017-05-29 15:29                   ` Dmitry Vyukov
2017-05-29 15:29                     ` Dmitry Vyukov
2017-05-30  7:58                     ` Vladimir Murzin
2017-05-30  7:58                       ` Vladimir Murzin
2017-05-30  8:15                       ` Dmitry Vyukov
2017-05-30  8:15                         ` Dmitry Vyukov
2017-05-30  8:31                         ` Vladimir Murzin
2017-05-30  8:31                           ` Vladimir Murzin
2017-05-30  8:40                           ` Vladimir Murzin
2017-05-30  8:40                             ` Vladimir Murzin
2017-05-30  8:49                             ` Dmitry Vyukov
2017-05-30  8:49                               ` Dmitry Vyukov
2017-05-30  9:08                               ` Vladimir Murzin
2017-05-30  9:08                                 ` Vladimir Murzin
2017-05-30  9:26                                 ` Dmitry Vyukov
2017-05-30  9:26                                   ` Dmitry Vyukov
2017-05-30  9:39                                   ` Vladimir Murzin
2017-05-30  9:39                                     ` Vladimir Murzin
2017-05-30  9:45                                     ` Dmitry Vyukov
2017-05-30  9:45                                       ` Dmitry Vyukov
2017-05-30  9:54                                       ` Vladimir Murzin
2017-05-30  9:54                                         ` Vladimir Murzin
2017-05-30 14:16                     ` Andrey Ryabinin
2017-05-30 14:16                       ` Andrey Ryabinin
2017-05-31  5:50                       ` Joonsoo Kim
2017-05-31  5:50                         ` Joonsoo Kim
2017-05-31 16:31                         ` Andrey Ryabinin
2017-05-31 16:31                           ` Andrey Ryabinin
2017-06-08  2:43                           ` Joonsoo Kim [this message]
2017-06-08  2:43                             ` Joonsoo Kim
2017-06-01 15:16                       ` 王靖天
2017-06-01 18:06                       ` Dmitry Vyukov
2017-06-01 18:06                         ` Dmitry Vyukov
2017-06-08  2:40                         ` Joonsoo Kim
2017-06-08  2:40                           ` Joonsoo Kim
2017-06-13 16:49                           ` Andrey Ryabinin
2017-06-13 16:49                             ` Andrey Ryabinin
2017-06-14  0:12                             ` Joonsoo Kim
2017-06-14  0:12                               ` Joonsoo Kim
2017-05-17 12:17 ` Andrey Ryabinin
2017-05-17 12:17   ` Andrey Ryabinin
2017-05-19  1:53   ` Joonsoo Kim
2017-05-19  1:53     ` Joonsoo Kim
2017-05-22  6:02     ` Dmitry Vyukov
2017-05-22  6:02       ` Dmitry Vyukov
2017-05-24  6:04       ` Joonsoo Kim
2017-05-24  6:04         ` Joonsoo Kim
2017-05-24 16:31         ` Dmitry Vyukov
2017-05-24 16:31           ` Dmitry Vyukov
2017-05-25  0:46           ` Joonsoo Kim
2017-05-25  0:46             ` Joonsoo Kim
2017-05-22 14:00     ` Andrey Ryabinin
2017-05-22 14:00       ` Andrey Ryabinin
2017-05-24  6:18       ` Joonsoo Kim
2017-05-24  6:18         ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608024303.GC27998@js1304-desktop \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=hpa@zytor.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.