From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
Ralph Sennhauser <ralph.sennhauser@gmail.com>
Subject: Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage
Date: Fri, 9 Jun 2017 12:04:35 +0200 [thread overview]
Message-ID: <20170609120435.60191c76@free-electrons.com> (raw)
In-Reply-To: <20170609100318.26450-1-gregory.clement@free-electrons.com>
Hello,
On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote:
> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 1);
> + BIT(pin), BIT(pin));
>
> return 0;
> }
> @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin,
> mvebu_gpio_set(chip, pin, value);
>
> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 0);
> + BIT(pin), BIT(pin));
Are you sure here? We want to clear the bit, so I guess the 0 is
appropriate, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: mvebu: fix regmap_update_bits usage
Date: Fri, 9 Jun 2017 12:04:35 +0200 [thread overview]
Message-ID: <20170609120435.60191c76@free-electrons.com> (raw)
In-Reply-To: <20170609100318.26450-1-gregory.clement@free-electrons.com>
Hello,
On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote:
> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 1);
> + BIT(pin), BIT(pin));
>
> return 0;
> }
> @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin,
> mvebu_gpio_set(chip, pin, value);
>
> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 0);
> + BIT(pin), BIT(pin));
Are you sure here? We want to clear the bit, so I guess the 0 is
appropriate, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-09 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:03 [PATCH] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT
2017-06-09 10:03 ` Gregory CLEMENT
2017-06-09 10:04 ` Thomas Petazzoni [this message]
2017-06-09 10:04 ` Thomas Petazzoni
2017-06-09 10:05 ` Gregory CLEMENT
2017-06-09 10:05 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609120435.60191c76@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralph.sennhauser@gmail.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.