From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Subject: Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage
Date: Fri, 9 Jun 2017 14:21:44 +0200 [thread overview]
Message-ID: <20170609142144.5f6c916b@gmail.com> (raw)
In-Reply-To: <20170609100917.26660-1-gregory.clement@free-electrons.com>
On Fri, 9 Jun 2017 12:09:17 +0200
Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> In some place in the driver regmap_update_bits was misused. Indeed the
> last argument is not the value of the bit (or group of bits) itself
> but the mask value inside the register.
>
> So when setting the bit N, then the value must be BIT(N) and not 1.
>
> CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
> CC: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
Hi Gregory,
Tested-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Thanks for the prompt fix
Ralph
WARNING: multiple messages have this Message-ID (diff)
From: ralph.sennhauser@gmail.com (Ralph Sennhauser)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage
Date: Fri, 9 Jun 2017 14:21:44 +0200 [thread overview]
Message-ID: <20170609142144.5f6c916b@gmail.com> (raw)
In-Reply-To: <20170609100917.26660-1-gregory.clement@free-electrons.com>
On Fri, 9 Jun 2017 12:09:17 +0200
Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> In some place in the driver regmap_update_bits was misused. Indeed the
> last argument is not the value of the bit (or group of bits) itself
> but the mask value inside the register.
>
> So when setting the bit N, then the value must be BIT(N) and not 1.
>
> CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
> CC: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
Hi Gregory,
Tested-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Thanks for the prompt fix
Ralph
next prev parent reply other threads:[~2017-06-09 12:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:09 [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT
2017-06-09 10:09 ` Gregory CLEMENT
2017-06-09 11:01 ` Thomas Petazzoni
2017-06-09 11:01 ` Thomas Petazzoni
2017-06-09 12:21 ` Ralph Sennhauser [this message]
2017-06-09 12:21 ` Ralph Sennhauser
2017-06-11 21:54 ` Chris Packham
2017-06-11 21:54 ` Chris Packham
2017-06-16 9:16 ` Linus Walleij
2017-06-16 9:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609142144.5f6c916b@gmail.com \
--to=ralph.sennhauser@gmail.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.