From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, marcandre.lureau@redhat.com,
qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org (open list:Block layer core)
Subject: [Qemu-trivial] [PATCH 2/2] qobject: Catch another straggler for use of qdict_put_str()
Date: Fri, 9 Jun 2017 10:20:17 -0500 [thread overview]
Message-ID: <20170609152017.7286-3-eblake@redhat.com> (raw)
In-Reply-To: <20170609152017.7286-1-eblake@redhat.com>
Dan's addition of key-secret improvements in commit 29cf9336 was
developed prior to the addition of QDict scalar insertion macros,
but merged after the general cleanup in commit 46f5ac20.
Patch created mechanically by rerunning:
spatch --sp-file scripts/coccinelle/qobject.cocci \
--macro-file scripts/cocci-macro-file.h --dir . --in-place
Signed-off-by: Eric Blake <eblake@redhat.com>
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 0ad698d..6c972f7 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -355,7 +355,7 @@ static int img_add_key_secrets(void *opaque,
QDict *options = opaque;
if (g_str_has_suffix(name, "key-secret")) {
- qdict_put(options, name, qstring_from_str(value));
+ qdict_put_str(options, name, value);
}
return 0;
--
2.9.4
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, marcandre.lureau@redhat.com,
qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PATCH 2/2] qobject: Catch another straggler for use of qdict_put_str()
Date: Fri, 9 Jun 2017 10:20:17 -0500 [thread overview]
Message-ID: <20170609152017.7286-3-eblake@redhat.com> (raw)
In-Reply-To: <20170609152017.7286-1-eblake@redhat.com>
Dan's addition of key-secret improvements in commit 29cf9336 was
developed prior to the addition of QDict scalar insertion macros,
but merged after the general cleanup in commit 46f5ac20.
Patch created mechanically by rerunning:
spatch --sp-file scripts/coccinelle/qobject.cocci \
--macro-file scripts/cocci-macro-file.h --dir . --in-place
Signed-off-by: Eric Blake <eblake@redhat.com>
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 0ad698d..6c972f7 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -355,7 +355,7 @@ static int img_add_key_secrets(void *opaque,
QDict *options = opaque;
if (g_str_has_suffix(name, "key-secret")) {
- qdict_put(options, name, qstring_from_str(value));
+ qdict_put_str(options, name, value);
}
return 0;
--
2.9.4
next prev parent reply other threads:[~2017-06-09 15:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 15:20 [Qemu-trivial] [PATCH 0/2] qobject coccinelle followups Eric Blake
2017-06-09 15:20 ` [Qemu-devel] " Eric Blake
2017-06-09 15:20 ` [Qemu-trivial] [PATCH 1/2] qobject: Update coccinelle script to catch Q{INC, DEC}REF Eric Blake
2017-06-09 15:20 ` [Qemu-devel] " Eric Blake
2017-06-09 15:28 ` [Qemu-trivial] " Marc-André Lureau
2017-06-09 15:28 ` Marc-André Lureau
2017-06-09 15:31 ` [Qemu-trivial] " Marc-André Lureau
2017-06-09 15:31 ` Marc-André Lureau
2017-06-09 15:33 ` [Qemu-trivial] " Eric Blake
2017-06-09 15:33 ` Eric Blake
2017-06-09 15:36 ` [Qemu-trivial] " Marc-André Lureau
2017-06-09 15:36 ` Marc-André Lureau
2017-06-09 15:40 ` [Qemu-trivial] " Eric Blake
2017-06-09 15:40 ` Eric Blake
2017-06-09 15:20 ` Eric Blake [this message]
2017-06-09 15:20 ` [Qemu-devel] [PATCH 2/2] qobject: Catch another straggler for use of qdict_put_str() Eric Blake
2017-06-11 12:40 ` [Qemu-trivial] " Max Reitz
2017-06-11 12:40 ` [Qemu-devel] " Max Reitz
2017-06-11 21:28 ` [Qemu-trivial] [Qemu-block] " Alberto Garcia
2017-06-11 21:28 ` [Qemu-devel] " Alberto Garcia
2017-07-12 13:35 ` [Qemu-trivial] [PATCH 0/2] qobject coccinelle followups Michael Tokarev
2017-07-12 13:35 ` [Qemu-devel] " Michael Tokarev
2017-07-12 13:56 ` [Qemu-trivial] " Eric Blake
2017-07-12 13:56 ` [Qemu-devel] " Eric Blake
2017-07-12 15:48 ` [Qemu-trivial] " Markus Armbruster
2017-07-12 15:48 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609152017.7286-3-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.