From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Bai Ping <ping.bai@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Zhang Rui <rui.zhang@intel.com>,
Fabio Estevam <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: imx6ul: Add imx6ul-tempmon
Date: Fri, 9 Jun 2017 15:46:38 +0200 [thread overview]
Message-ID: <20170609154638.3b64e6d0@karo-electronics.de> (raw)
In-Reply-To: <1497005895.28352.88.camel@nxp.com>
Hi,
On Fri, 9 Jun 2017 13:58:15 +0300 Leonard Crestez wrote:
> On Thu, 2017-06-08 at 13:45 -0300, Fabio Estevam wrote:
> > On Thu, Jun 8, 2017 at 1:26 PM, Leonard Crestez wrote:
> >
> > >
> > > + tempmon: tempmon {
> > > + compatible = "fsl,imx6ul-tempmon", "fsl,imx6sx-tempmon";
> > > + interrupts = ;
> > > + fsl,tempmon = <&anatop>;
> > > + fsl,tempmon-data = <&ocotp>;
> > > + clocks = <&clks IMX6UL_CLK_PLL3_USB_OTG>;
> > Does the IMX6UL_CLK_PLL3_USB_OTG clock really control tempmon? Please
> > double check.
>
> Yes, as far as I can tell the tempmon block uses the 480 Mhz PLL3 clock
> directly. This is similar to other imx6 SOCs. This PLL is used for
> stuff like USB but not only that. My understanding is the _USB_OTG
> suffix is descriptive, similar to PLL4_AUDIO and PLL6_ENET. Other non-
> usb components use PLL3 (like UART) but through other gates/dividers.
>
> Setting this to IMX6UL_CLK_DUMMY will cause temperature reads to fail.
> Even if PLL3 usually ends up being constantly enabled because of uarts
> this is not true at imx_thermal_probe time (or uarts can be disabled).
>
Since the driver is accessing the OCOTP registers it definitely needs
the IMX6UL_CLK_OCOTP too!
Lothar Waßmann
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: imx6ul: Add imx6ul-tempmon
Date: Fri, 9 Jun 2017 15:46:38 +0200 [thread overview]
Message-ID: <20170609154638.3b64e6d0@karo-electronics.de> (raw)
In-Reply-To: <1497005895.28352.88.camel@nxp.com>
Hi,
On Fri, 9 Jun 2017 13:58:15 +0300 Leonard Crestez wrote:
> On Thu, 2017-06-08 at 13:45 -0300, Fabio Estevam wrote:
> > On Thu, Jun 8, 2017 at 1:26 PM, Leonard Crestez wrote:
> >
> > >
> > > +???????????????????????tempmon: tempmon {
> > > +???????????????????????????????compatible = "fsl,imx6ul-tempmon", "fsl,imx6sx-tempmon";
> > > +???????????????????????????????interrupts = ;
> > > +???????????????????????????????fsl,tempmon = <&anatop>;
> > > +???????????????????????????????fsl,tempmon-data = <&ocotp>;
> > > +???????????????????????????????clocks = <&clks IMX6UL_CLK_PLL3_USB_OTG>;
> > Does the IMX6UL_CLK_PLL3_USB_OTG clock really control tempmon? Please
> > double check.
>
> Yes, as far as I can tell the tempmon block uses the 480 Mhz PLL3 clock
> directly. This is similar to other imx6 SOCs. This PLL is used for
> stuff like USB but not only that. My understanding is the _USB_OTG
> suffix is descriptive, similar to PLL4_AUDIO and PLL6_ENET. Other non-
> usb components use PLL3 (like UART) but through other gates/dividers.
>
> Setting this to?IMX6UL_CLK_DUMMY will cause temperature reads to fail.
> Even if PLL3 usually ends up being constantly enabled because of uarts
> this is not true at imx_thermal_probe time (or uarts can be disabled).
>
Since the driver is accessing the OCOTP registers it definitely needs
the IMX6UL_CLK_OCOTP too!
Lothar Wa?mann
WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>, Bai Ping <ping.bai@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Zhang Rui <rui.zhang@intel.com>, Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: imx6ul: Add imx6ul-tempmon
Date: Fri, 9 Jun 2017 15:46:38 +0200 [thread overview]
Message-ID: <20170609154638.3b64e6d0@karo-electronics.de> (raw)
In-Reply-To: <1497005895.28352.88.camel@nxp.com>
Hi,
On Fri, 9 Jun 2017 13:58:15 +0300 Leonard Crestez wrote:
> On Thu, 2017-06-08 at 13:45 -0300, Fabio Estevam wrote:
> > On Thu, Jun 8, 2017 at 1:26 PM, Leonard Crestez wrote:
> >
> > >
> > > + tempmon: tempmon {
> > > + compatible = "fsl,imx6ul-tempmon", "fsl,imx6sx-tempmon";
> > > + interrupts = ;
> > > + fsl,tempmon = <&anatop>;
> > > + fsl,tempmon-data = <&ocotp>;
> > > + clocks = <&clks IMX6UL_CLK_PLL3_USB_OTG>;
> > Does the IMX6UL_CLK_PLL3_USB_OTG clock really control tempmon? Please
> > double check.
>
> Yes, as far as I can tell the tempmon block uses the 480 Mhz PLL3 clock
> directly. This is similar to other imx6 SOCs. This PLL is used for
> stuff like USB but not only that. My understanding is the _USB_OTG
> suffix is descriptive, similar to PLL4_AUDIO and PLL6_ENET. Other non-
> usb components use PLL3 (like UART) but through other gates/dividers.
>
> Setting this to IMX6UL_CLK_DUMMY will cause temperature reads to fail.
> Even if PLL3 usually ends up being constantly enabled because of uarts
> this is not true at imx_thermal_probe time (or uarts can be disabled).
>
Since the driver is accessing the OCOTP registers it definitely needs
the IMX6UL_CLK_OCOTP too!
Lothar Waßmann
next prev parent reply other threads:[~2017-06-09 13:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 16:26 [PATCH 1/2] ARM: imx_v6_v7_defconfig: Set THERMAL_WRITABLE_TRIPS=y for testing Leonard Crestez
2017-06-08 16:26 ` Leonard Crestez
2017-06-08 16:26 ` Leonard Crestez
2017-06-08 16:26 ` [PATCH 2/2] ARM: dts: imx6ul: Add imx6ul-tempmon Leonard Crestez
2017-06-08 16:26 ` Leonard Crestez
2017-06-08 16:26 ` Leonard Crestez
2017-06-08 16:45 ` Fabio Estevam
2017-06-08 16:45 ` Fabio Estevam
2017-06-09 10:58 ` Leonard Crestez
2017-06-09 10:58 ` Leonard Crestez
2017-06-09 12:18 ` Fabio Estevam
2017-06-09 12:18 ` Fabio Estevam
2017-06-09 13:46 ` Lothar Waßmann [this message]
2017-06-09 13:46 ` Lothar Waßmann
2017-06-09 13:46 ` Lothar Waßmann
2017-06-09 15:34 ` Leonard Crestez
2017-06-09 15:34 ` Leonard Crestez
2017-06-12 10:40 ` Lothar Waßmann
2017-06-12 10:40 ` Lothar Waßmann
2017-06-12 11:47 ` Leonard Crestez
2017-06-12 11:47 ` Leonard Crestez
2017-06-12 13:22 ` Fabio Estevam
2017-06-12 13:22 ` Fabio Estevam
2017-06-12 13:37 ` Lothar Waßmann
2017-06-12 13:37 ` Lothar Waßmann
2017-06-12 13:37 ` Lothar Waßmann
2017-06-12 14:30 ` Fabio Estevam
2017-06-12 14:30 ` Fabio Estevam
2017-06-15 1:35 ` [PATCH 1/2] ARM: imx_v6_v7_defconfig: Set THERMAL_WRITABLE_TRIPS=y for testing Shawn Guo
2017-06-15 1:35 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609154638.3b64e6d0@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=edubezval@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.