All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/qt: enable static build for BR2_PACKAGE_QT_MOUSE_TSLIB
@ 2017-06-08  9:02 Martin Kepplinger
  2017-06-08  9:51 ` Baruch Siach
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Kepplinger @ 2017-06-08  9:02 UTC (permalink / raw)
  To: buildroot

The dependency on !BR2_STATIC_LIBS was here because of tslib not supporing
static builds. But since

   commit 05fadfea1 ("package/tslib: enable statically linked building")

it does and we can remove this dependecy.

Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---
 package/qt/Config.mouse.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/qt/Config.mouse.in b/package/qt/Config.mouse.in
index 07573ebb8..eb9d2c0c2 100644
--- a/package/qt/Config.mouse.in
+++ b/package/qt/Config.mouse.in
@@ -11,7 +11,6 @@ config BR2_PACKAGE_QT_MOUSE_LINUXINPUT
 
 config BR2_PACKAGE_QT_MOUSE_TSLIB
 	bool "tslib"
-	depends on !BR2_STATIC_LIBS # tslib
 	select BR2_PACKAGE_TSLIB
 
 comment "tslib support needs a toolchain w/ dynamic library"
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/qt: enable static build for BR2_PACKAGE_QT_MOUSE_TSLIB
  2017-06-08  9:02 [Buildroot] [PATCH] package/qt: enable static build for BR2_PACKAGE_QT_MOUSE_TSLIB Martin Kepplinger
@ 2017-06-08  9:51 ` Baruch Siach
  2017-06-08 10:03   ` [Buildroot] [PATCH v2] " Martin Kepplinger
  0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2017-06-08  9:51 UTC (permalink / raw)
  To: buildroot

Hi Martin,

On Thu, Jun 08, 2017 at 11:02:59AM +0200, Martin Kepplinger wrote:
> The dependency on !BR2_STATIC_LIBS was here because of tslib not supporing
> static builds. But since
> 
>    commit 05fadfea1 ("package/tslib: enable statically linked building")
> 
> it does and we can remove this dependecy.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
>  package/qt/Config.mouse.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/qt/Config.mouse.in b/package/qt/Config.mouse.in
> index 07573ebb8..eb9d2c0c2 100644
> --- a/package/qt/Config.mouse.in
> +++ b/package/qt/Config.mouse.in
> @@ -11,7 +11,6 @@ config BR2_PACKAGE_QT_MOUSE_LINUXINPUT
>  
>  config BR2_PACKAGE_QT_MOUSE_TSLIB
>  	bool "tslib"
> -	depends on !BR2_STATIC_LIBS # tslib
>  	select BR2_PACKAGE_TSLIB
>  
>  comment "tslib support needs a toolchain w/ dynamic library"

This comment is not correct anymore.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2] package/qt: enable static build for BR2_PACKAGE_QT_MOUSE_TSLIB
  2017-06-08  9:51 ` Baruch Siach
@ 2017-06-08 10:03   ` Martin Kepplinger
  2017-06-11 13:54     ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Kepplinger @ 2017-06-08 10:03 UTC (permalink / raw)
  To: buildroot

The dependency on !BR2_STATIC_LIBS was here because of tslib not supporing
static builds. But since

   commit 05fadfea1 ("package/tslib: enable statically linked building")

it does and we can remove this dependecy.

Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---

v2:
Thanks Baruch Siach for reviewing. I missed removing the dependecy on
BR2_STATIC_LIBS


 package/qt/Config.mouse.in | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/qt/Config.mouse.in b/package/qt/Config.mouse.in
index 07573ebb8..1062facb6 100644
--- a/package/qt/Config.mouse.in
+++ b/package/qt/Config.mouse.in
@@ -11,12 +11,8 @@ config BR2_PACKAGE_QT_MOUSE_LINUXINPUT
 
 config BR2_PACKAGE_QT_MOUSE_TSLIB
 	bool "tslib"
-	depends on !BR2_STATIC_LIBS # tslib
 	select BR2_PACKAGE_TSLIB
 
-comment "tslib support needs a toolchain w/ dynamic library"
-	depends on BR2_STATIC_LIBS
-
 config BR2_PACKAGE_QT_MOUSE_QVFB
 	bool "qvfb"
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2] package/qt: enable static build for BR2_PACKAGE_QT_MOUSE_TSLIB
  2017-06-08 10:03   ` [Buildroot] [PATCH v2] " Martin Kepplinger
@ 2017-06-11 13:54     ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-06-11 13:54 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 8 Jun 2017 12:03:12 +0200, Martin Kepplinger wrote:
> The dependency on !BR2_STATIC_LIBS was here because of tslib not supporing
> static builds. But since
> 
>    commit 05fadfea1 ("package/tslib: enable statically linked building")
> 
> it does and we can remove this dependecy.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-11 13:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-08  9:02 [Buildroot] [PATCH] package/qt: enable static build for BR2_PACKAGE_QT_MOUSE_TSLIB Martin Kepplinger
2017-06-08  9:51 ` Baruch Siach
2017-06-08 10:03   ` [Buildroot] [PATCH v2] " Martin Kepplinger
2017-06-11 13:54     ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.