From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2] nvme: use uuid_t in nvme_ns
Date: Mon, 12 Jun 2017 13:03:57 +0200 [thread overview]
Message-ID: <20170612110357.GA22745@lst.de> (raw)
In-Reply-To: <52228639-aedd-fdb9-0f02-448f8982758a@suse.de>
On Mon, Jun 12, 2017@12:04:18PM +0200, Johannes Thumshirn wrote:
> > So, this reveals two thins:
> > 1) shall we define NVME_NIDT_UUID_LEN to be UUID_LEN or substitute it
> > completely with the latter?
>
> No, we have NVME_NIDT_UUID_LEN but also NVME_NIDT_NGUID_LEN and
> NVME_NIDT_EUI64_LEN.
Yeah, and I'd rather keep the defines for fields defined in the spec
in nvme.h
> I'm not sure the NVMe NGUID is the same as a GUID (a.k.a little endian
> UUID). Quoting from the spec:
It's not at all, the field just has a very unfortunate name in the
spec.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: use uuid_t in nvme_ns
Date: Mon, 12 Jun 2017 13:03:57 +0200 [thread overview]
Message-ID: <20170612110357.GA22745@lst.de> (raw)
In-Reply-To: <52228639-aedd-fdb9-0f02-448f8982758a@suse.de>
On Mon, Jun 12, 2017 at 12:04:18PM +0200, Johannes Thumshirn wrote:
> > So, this reveals two thins:
> > 1) shall we define NVME_NIDT_UUID_LEN to be UUID_LEN or substitute it
> > completely with the latter?
>
> No, we have NVME_NIDT_UUID_LEN but also NVME_NIDT_NGUID_LEN and
> NVME_NIDT_EUI64_LEN.
Yeah, and I'd rather keep the defines for fields defined in the spec
in nvme.h
> I'm not sure the NVMe NGUID is the same as a GUID (a.k.a little endian
> UUID). Quoting from the spec:
It's not at all, the field just has a very unfortunate name in the
spec.
next prev parent reply other threads:[~2017-06-12 11:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 9:12 [PATCH v2] nvme: use uuid_t in nvme_ns Johannes Thumshirn
2017-06-12 9:12 ` Johannes Thumshirn
2017-06-12 9:50 ` Andy Shevchenko
2017-06-12 9:50 ` Andy Shevchenko
2017-06-12 10:04 ` Johannes Thumshirn
2017-06-12 10:04 ` Johannes Thumshirn
2017-06-12 11:03 ` Christoph Hellwig [this message]
2017-06-12 11:03 ` Christoph Hellwig
2017-06-12 13:11 ` Andy Shevchenko
2017-06-12 13:11 ` Andy Shevchenko
2017-06-12 16:06 ` Christoph Hellwig
2017-06-12 16:06 ` Christoph Hellwig
2017-06-15 8:57 ` Sagi Grimberg
2017-06-15 8:57 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612110357.GA22745@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.