All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kevin Hilman <khilman@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [RFT v2 2/8] PM / Domains: Handle safely genpd_syscore_switch() call on non-genpd device
Date: Mon, 12 Jun 2017 17:17:42 +0200	[thread overview]
Message-ID: <20170612151748.7380-3-krzk@kernel.org> (raw)
In-Reply-To: <20170612151748.7380-1-krzk@kernel.org>

genpd_syscore_switch() had two problems:
1. It silently assumed that device, it is being called for, belongs to
   generic power domain and used container_of() on its power domain
   pointer.  Such assumption might not be true always.

2. It iterated over list of generic power domains without holding
   gpd_list_lock mutex thus list could have been modified in the same
   time.

Usage of genpd_lookup_dev() solves both problems as it is safe a call
for non-generic power domains and uses mutex when iterating.

Reported-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested on real hardware.
---
 drivers/base/power/domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 2e8d0f423507..983f086ab235 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1098,8 +1098,8 @@ static void genpd_syscore_switch(struct device *dev, bool suspend)
 {
 	struct generic_pm_domain *genpd;
 
-	genpd = dev_to_genpd(dev);
-	if (!pm_genpd_present(genpd))
+	genpd = genpd_lookup_dev(dev);
+	if (!genpd)
 		return;
 
 	if (suspend) {
-- 
2.9.3

  parent reply	other threads:[~2017-06-12 15:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 15:17 [PATCH v2 0/8] PM / Domains: Bunch of small improvements and fixes Krzysztof Kozlowski
2017-06-12 15:17 ` [PATCH v2 1/8] PM / Domains: Constify genpd pointer Krzysztof Kozlowski
2017-06-13 10:36   ` Ulf Hansson
2017-06-12 15:17 ` Krzysztof Kozlowski [this message]
2017-06-13 10:38   ` [RFT v2 2/8] PM / Domains: Handle safely genpd_syscore_switch() call on non-genpd device Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 3/8] PM / Domains: Add lockdep asserts for domains list mutex Krzysztof Kozlowski
2017-06-12 19:09   ` Ulf Hansson
2017-06-13  7:12     ` Krzysztof Kozlowski
2017-06-13  8:34       ` Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 4/8] PM / Domains: Fix unsafe iteration over modified list of device links Krzysztof Kozlowski
2017-06-13 10:38   ` Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 5/8] PM / Domains: Fix unsafe iteration over modified list of domain providers Krzysztof Kozlowski
2017-06-13 10:38   ` Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 6/8] PM / Domains: Fix unsafe iteration over modified list of domains Krzysztof Kozlowski
2017-06-13 10:39   ` Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 7/8] PM / Domains: Fix missing default_power_down_ok comment Krzysztof Kozlowski
2017-06-13 10:39   ` Ulf Hansson
2017-06-12 15:17 ` [RFC v2 8/8] PM / Domains: Add asserts for PM domain locks Krzysztof Kozlowski
2017-06-27 22:51 ` [PATCH v2 0/8] PM / Domains: Bunch of small improvements and fixes Rafael J. Wysocki
2017-06-28 14:48   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612151748.7380-3-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=khilman@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.