From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>, stable@vger.kernel.org
Subject: [PATCH v2 6/8] PM / Domains: Fix unsafe iteration over modified list of domains
Date: Mon, 12 Jun 2017 17:17:46 +0200 [thread overview]
Message-ID: <20170612151748.7380-7-krzk@kernel.org> (raw)
In-Reply-To: <20170612151748.7380-1-krzk@kernel.org>
of_genpd_remove_last() iterates over list of domains and removes
matching element thus it has to use safe version of list iteration.
Fixes: 17926551c98a ("PM / Domains: Add support for removing nested PM domains by provider")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/base/power/domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index b74b5111957a..33467beaeea4 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1934,14 +1934,14 @@ EXPORT_SYMBOL_GPL(of_genpd_add_subdomain);
*/
struct generic_pm_domain *of_genpd_remove_last(struct device_node *np)
{
- struct generic_pm_domain *gpd, *genpd = ERR_PTR(-ENOENT);
+ struct generic_pm_domain *gpd, *tmp, *genpd = ERR_PTR(-ENOENT);
int ret;
if (IS_ERR_OR_NULL(np))
return ERR_PTR(-EINVAL);
mutex_lock(&gpd_list_lock);
- list_for_each_entry(gpd, &gpd_list, gpd_list_node) {
+ list_for_each_entry_safe(gpd, tmp, &gpd_list, gpd_list_node) {
if (gpd->provider == &np->fwnode) {
ret = genpd_remove(gpd);
genpd = ret ? ERR_PTR(ret) : gpd;
--
2.9.3
next prev parent reply other threads:[~2017-06-12 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 15:17 [PATCH v2 0/8] PM / Domains: Bunch of small improvements and fixes Krzysztof Kozlowski
2017-06-12 15:17 ` [PATCH v2 1/8] PM / Domains: Constify genpd pointer Krzysztof Kozlowski
2017-06-13 10:36 ` Ulf Hansson
2017-06-12 15:17 ` [RFT v2 2/8] PM / Domains: Handle safely genpd_syscore_switch() call on non-genpd device Krzysztof Kozlowski
2017-06-13 10:38 ` Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 3/8] PM / Domains: Add lockdep asserts for domains list mutex Krzysztof Kozlowski
2017-06-12 19:09 ` Ulf Hansson
2017-06-13 7:12 ` Krzysztof Kozlowski
2017-06-13 8:34 ` Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 4/8] PM / Domains: Fix unsafe iteration over modified list of device links Krzysztof Kozlowski
2017-06-13 10:38 ` Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 5/8] PM / Domains: Fix unsafe iteration over modified list of domain providers Krzysztof Kozlowski
2017-06-13 10:38 ` Ulf Hansson
2017-06-12 15:17 ` Krzysztof Kozlowski [this message]
2017-06-13 10:39 ` [PATCH v2 6/8] PM / Domains: Fix unsafe iteration over modified list of domains Ulf Hansson
2017-06-12 15:17 ` [PATCH v2 7/8] PM / Domains: Fix missing default_power_down_ok comment Krzysztof Kozlowski
2017-06-13 10:39 ` Ulf Hansson
2017-06-12 15:17 ` [RFC v2 8/8] PM / Domains: Add asserts for PM domain locks Krzysztof Kozlowski
2017-06-27 22:51 ` [PATCH v2 0/8] PM / Domains: Bunch of small improvements and fixes Rafael J. Wysocki
2017-06-28 14:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612151748.7380-7-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.