From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Jay Zhou <jianjay.zhou@huawei.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
wangxinxin.wang@huawei.com, weidong.huang@huawei.com,
arei.gonglei@huawei.com
Subject: Re: [PATCH RFC] KVM: X86: save and load PVCLOCK_TSC_UNSTABLE_BIT when migration
Date: Mon, 12 Jun 2017 21:52:10 +0200 [thread overview]
Message-ID: <20170612195209.GA16151@potion> (raw)
In-Reply-To: <1497273796-44720-1-git-send-email-jianjay.zhou@huawei.com>
2017-06-12 21:23+0800, Jay Zhou:
> Guest using kvmclock will be hanged when migrating from unstable
> tsc host to stable tsc host occasionally.
> Sometimes, the tsc timestamp saved at the source side will be
> backward when the guest stopped, and this value is transferred
> to the destination side. The guest at the destination side thought
> kvmclock is stable, so the protection mechanism against time
> going backwards is not used.
> When the first time vcpu0 enters the guest at the destination
> side to update the wall clock, the result of
> pvclock_clocksource_read will be backward occasionally,
> which results in the wall clock drift.
>
> Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> ---
Hm, are you using KVM that has e3fd9a93a12a (4.9+)?
If you get a timestamp from KVM_GET_CLOCK() and pass that to
KVM_SET_CLOCK(), then kvmclock should not jump backwards anymore
(it could before 4.9, but only if the host had stable tsc).
A possible source of this bug in when QEMU recomputes the timestamp to
pass to KVM_SET_CLOCK() using TSC and kvmclock page.
Can you provide the values used for KVM_GET_CLOCK and KVM_SET_CLOCK when
the bug occurs?
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Jay Zhou <jianjay.zhou@huawei.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
wangxinxin.wang@huawei.com, weidong.huang@huawei.com,
arei.gonglei@huawei.com
Subject: Re: [Qemu-devel] [PATCH RFC] KVM: X86: save and load PVCLOCK_TSC_UNSTABLE_BIT when migration
Date: Mon, 12 Jun 2017 21:52:10 +0200 [thread overview]
Message-ID: <20170612195209.GA16151@potion> (raw)
In-Reply-To: <1497273796-44720-1-git-send-email-jianjay.zhou@huawei.com>
2017-06-12 21:23+0800, Jay Zhou:
> Guest using kvmclock will be hanged when migrating from unstable
> tsc host to stable tsc host occasionally.
> Sometimes, the tsc timestamp saved at the source side will be
> backward when the guest stopped, and this value is transferred
> to the destination side. The guest at the destination side thought
> kvmclock is stable, so the protection mechanism against time
> going backwards is not used.
> When the first time vcpu0 enters the guest at the destination
> side to update the wall clock, the result of
> pvclock_clocksource_read will be backward occasionally,
> which results in the wall clock drift.
>
> Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> ---
Hm, are you using KVM that has e3fd9a93a12a (4.9+)?
If you get a timestamp from KVM_GET_CLOCK() and pass that to
KVM_SET_CLOCK(), then kvmclock should not jump backwards anymore
(it could before 4.9, but only if the host had stable tsc).
A possible source of this bug in when QEMU recomputes the timestamp to
pass to KVM_SET_CLOCK() using TSC and kvmclock page.
Can you provide the values used for KVM_GET_CLOCK and KVM_SET_CLOCK when
the bug occurs?
Thanks.
next prev parent reply other threads:[~2017-06-12 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 13:23 [PATCH RFC] KVM: X86: save and load PVCLOCK_TSC_UNSTABLE_BIT when migration Jay Zhou
2017-06-12 13:23 ` [Qemu-devel] " Jay Zhou
2017-06-12 19:52 ` Radim Krčmář [this message]
2017-06-12 19:52 ` Radim Krčmář
2017-06-13 12:00 ` Jay Zhou
2017-06-13 12:00 ` [Qemu-devel] " Jay Zhou
2017-06-13 13:52 ` Radim Krčmář
2017-06-13 13:52 ` [Qemu-devel] " Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612195209.GA16151@potion \
--to=rkrcmar@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=jianjay.zhou@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.