From: Peter Xu <peterx@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, drjones@redhat.com,
vijay.kilari@gmail.com, quintela@redhat.com,
qemu-devel@nongnu.org, Vijaya.Kumar@cavium.com,
qemu-arm@nongnu.org, christoffer.dall@linaro.org,
zhaoshenglong@huawei.com, dgilbert@redhat.com,
eric.auger.pro@gmail.com
Subject: Re: [Qemu-arm] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access
Date: Tue, 13 Jun 2017 12:23:49 +0800 [thread overview]
Message-ID: <20170613042349.GC11751@pxdev.xzpeter.org> (raw)
In-Reply-To: <1497023553-18411-2-git-send-email-eric.auger@redhat.com>
On Fri, Jun 09, 2017 at 05:52:30PM +0200, Eric Auger wrote:
> In some circumstances, we don't want to abort if the
> kvm_device_access fails. This will be the case during ITS
> migration, in case the ITS table save/restore fails because
> the guest did not program the vITS correctly. So let's pass an
> error object to the function and return the ioctl value. New
> callers will be able to make a decision upon this returned
> value.
>
> Existing callers pass &error_abort which will cause the
> function to abort on failure.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, peter.maydell@linaro.org,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
vijay.kilari@gmail.com, Vijaya.Kumar@cavium.com,
drjones@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
christoffer.dall@linaro.org, zhaoshenglong@huawei.com,
wei@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access
Date: Tue, 13 Jun 2017 12:23:49 +0800 [thread overview]
Message-ID: <20170613042349.GC11751@pxdev.xzpeter.org> (raw)
In-Reply-To: <1497023553-18411-2-git-send-email-eric.auger@redhat.com>
On Fri, Jun 09, 2017 at 05:52:30PM +0200, Eric Auger wrote:
> In some circumstances, we don't want to abort if the
> kvm_device_access fails. This will be the case during ITS
> migration, in case the ITS table save/restore fails because
> the guest did not program the vITS correctly. So let's pass an
> error object to the function and return the ioctl value. New
> callers will be able to make a decision upon this returned
> value.
>
> Existing callers pass &error_abort which will cause the
> function to abort on failure.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2017-06-13 4:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 15:52 [Qemu-arm] [PATCH v6 0/4] vITS save/restore Eric Auger
2017-06-09 15:52 ` [Qemu-devel] " Eric Auger
2017-06-09 15:52 ` [Qemu-arm] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access Eric Auger
2017-06-09 15:52 ` [Qemu-devel] " Eric Auger
2017-06-12 6:23 ` [Qemu-arm] " Juan Quintela
2017-06-12 6:23 ` [Qemu-devel] " Juan Quintela
2017-06-12 19:14 ` [Qemu-arm] " Auger Eric
2017-06-12 19:14 ` Auger Eric
2017-06-13 4:23 ` Peter Xu [this message]
2017-06-13 4:23 ` Peter Xu
2017-06-09 15:52 ` [Qemu-arm] [PATCH v6 2/4] hw/intc/arm_gicv3_its: Implement state save/restore Eric Auger
2017-06-09 15:52 ` [Qemu-devel] " Eric Auger
2017-06-09 15:52 ` [Qemu-arm] [PATCH v6 3/4] hw/intc/arm_gicv3_kvm: Implement pending table save Eric Auger
2017-06-09 15:52 ` [Qemu-devel] " Eric Auger
2017-06-09 15:52 ` [Qemu-arm] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Allow save/restore Eric Auger
2017-06-09 15:52 ` [Qemu-devel] " Eric Auger
2017-06-13 13:56 ` [Qemu-arm] [PATCH v6 0/4] vITS save/restore Peter Maydell
2017-06-13 13:56 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613042349.GC11751@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=christoffer.dall@linaro.org \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vijay.kilari@gmail.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.