* [lustre-devel] [PATCH v3] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one
@ 2017-06-13 6:28 Roman Storozhenko
2017-06-13 9:25 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Roman Storozhenko @ 2017-06-13 6:28 UTC (permalink / raw)
To: lustre-devel
Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions
considered harmful:
https://lwn.net/Articles/696229/
Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
drivers/staging/lustre/lustre/llite/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
index 13b3592..de5b4bf 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1141,7 +1141,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
}
#if OBD_OCD_VERSION(2, 9, 50, 0) > LUSTRE_VERSION_CODE
- mode = data->ioc_type != 0 ? data->ioc_type : S_IRWXUGO;
+ mode = data->ioc_type != 0 ? data->ioc_type : 0777;
#else
mode = data->ioc_type;
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [lustre-devel] [PATCH v3] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one
2017-06-13 6:28 [lustre-devel] [PATCH v3] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one Roman Storozhenko
@ 2017-06-13 9:25 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-06-13 9:25 UTC (permalink / raw)
To: lustre-devel
On Tue, Jun 13, 2017 at 09:28:30AM +0300, Roman Storozhenko wrote:
> Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions
> considered harmful:
> https://lwn.net/Articles/696229/
>
> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What changed in this version of the patch? You always have to say that
below the --- line, like the documentation says to do.
Please fix, make a v4, and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-13 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-13 6:28 [lustre-devel] [PATCH v3] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one Roman Storozhenko
2017-06-13 9:25 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.