All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: James Smart <james.smart@broadcom.com>
Cc: Roland Dreier <roland@purestorage.com>,
	Sebastian Herbszt <herbszt@gmx.de>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	jsmart2021@gmail.com,
	Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
	target-devel <target-devel@vger.kernel.org>
Subject: Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct
Date: Mon, 12 Jun 2017 23:31:11 -0700	[thread overview]
Message-ID: <20170613063111.GA2212@infradead.org> (raw)
In-Reply-To: <55205e7e-e1c6-5f09-8dd3-338492728dfe@broadcom.com>

Hi James,

I like the plan except for one bit:  The staging tree will be a major
pain due to the rules for applying to it and all the whitespace
cleanup junk you'll get.  I would storngly recommend to you to
do this with a non-mainline tree instead.  I'd be happy to help you
maintaining it if you want.

> Questions:
> a) How best to deal with overlapping pci id's ?  E.g. if we do (1) and we
> have an initiator and target driver, there is a lot of adapters that are
> fully functional for target operation, but were sold as primarily an
> initiator adapter. How could we manage target mode enablement without code
> mod or hard pci id partitioning ?   I know individual pci unbind/bind could
> work, but its been frowned upon as a long term option. Same thing goes for
> module parameters to select which ports do what role.

Let's start with a manual bind for the target driver.  A slightly
more fancy option would be to add the PCI IDs to both and reject
the device with -ENXIO if not configured for the right role.

  reply	other threads:[~2017-06-13  6:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 23:28 [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct James Smart
2017-02-28 16:34 ` Hannes Reinecke
2017-02-28 18:14   ` James Smart
2017-03-01  9:40     ` Hannes Reinecke
2017-03-02 20:08 ` Nicholas A. Bellinger
2017-03-05 16:35   ` Sebastian Herbszt
2017-03-06 17:53     ` Bart Van Assche
2017-05-16 19:59     ` Roland Dreier
2017-06-12 23:08       ` James Smart
2017-06-13  6:31         ` Christoph Hellwig [this message]
2017-06-13  8:29         ` Johannes Thumshirn
2017-06-13 15:34         ` Martin K. Petersen
2017-06-14 11:40         ` Hannes Reinecke
2017-06-14 20:02           ` Sebastian Herbszt
2017-06-16  6:38             ` Hannes Reinecke
2017-03-17  0:10 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170613063111.GA2212@infradead.org \
    --to=hch@infradead.org \
    --cc=herbszt@gmx.de \
    --cc=james.smart@broadcom.com \
    --cc=jsmart2021@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=roland@purestorage.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.