From: Pavel Machek <pavel@ucw.cz>
To: Zhang Bo <bo.zhang@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, rpurdie@rpsys.net,
jacek.anaszewski@gmail.com, linus.walleij@linaro.org,
ulf.hansson@linaro.org, grygorii.strashko@ti.com,
linux-leds@vger.kernel.org
Subject: Re: [[PATCH]] Revert "leds: handle suspend/resume in heartbeat trigger"
Date: Tue, 13 Jun 2017 09:31:24 +0200 [thread overview]
Message-ID: <20170613073124.GA16077@amd> (raw)
In-Reply-To: <1497321560-46817-1-git-send-email-bo.zhang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On Tue 2017-06-13 10:39:20, Zhang Bo wrote:
> This reverts commit 5ab92a7cb82c66bf30685583a38a18538e3807db.
>
> System cannot enter suspend mode because of heartbeat led trigger.
> In autosleep_wq, try_to_suspend function will try to enter suspend
> mode in specific period. it will get wakeup_count then call pm_notifier
> chain callback function and freeze processes.
> Heartbeat_pm_notifier is called and it call led_trigger_unregister to
> change the trigger of led device to none. It will send uevent message
> and the wakeup source count changed. As wakeup_count changed, suspend
> will abort.
>
> Signed-off-by: Zhang Bo <bo.zhang@nxp.com>
Yes, this makes sense. Turning led off should be done at driver level.
As this fixes a regression, it would be kind of nice to get it to
v4.12...
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [[PATCH]] Revert "leds: handle suspend/resume in heartbeat trigger"
Date: Tue, 13 Jun 2017 09:31:24 +0200 [thread overview]
Message-ID: <20170613073124.GA16077@amd> (raw)
In-Reply-To: <1497321560-46817-1-git-send-email-bo.zhang@nxp.com>
On Tue 2017-06-13 10:39:20, Zhang Bo wrote:
> This reverts commit 5ab92a7cb82c66bf30685583a38a18538e3807db.
>
> System cannot enter suspend mode because of heartbeat led trigger.
> In autosleep_wq, try_to_suspend function will try to enter suspend
> mode in specific period. it will get wakeup_count then call pm_notifier
> chain callback function and freeze processes.
> Heartbeat_pm_notifier is called and it call led_trigger_unregister to
> change the trigger of led device to none. It will send uevent message
> and the wakeup source count changed. As wakeup_count changed, suspend
> will abort.
>
> Signed-off-by: Zhang Bo <bo.zhang@nxp.com>
Yes, this makes sense. Turning led off should be done at driver level.
As this fixes a regression, it would be kind of nice to get it to
v4.12...
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170613/75079f2d/attachment.sig>
next prev parent reply other threads:[~2017-06-13 7:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 2:39 [[PATCH]] Revert "leds: handle suspend/resume in heartbeat trigger" Zhang Bo
2017-06-13 2:39 ` Zhang Bo
2017-06-13 7:31 ` Pavel Machek [this message]
2017-06-13 7:31 ` Pavel Machek
2017-06-13 9:35 ` Linus Walleij
2017-06-13 9:35 ` Linus Walleij
2017-07-13 12:03 ` Pavel Machek
2017-07-13 12:03 ` Pavel Machek
2017-07-13 12:46 ` Linus Walleij
2017-07-13 12:46 ` Linus Walleij
2017-06-13 18:44 ` Jacek Anaszewski
2017-06-13 18:44 ` Jacek Anaszewski
2017-08-23 14:02 ` Geert Uytterhoeven
2017-08-23 14:02 ` Geert Uytterhoeven
2017-08-23 19:34 ` Pavel Machek
2017-08-23 19:34 ` Pavel Machek
2017-08-25 8:23 ` Geert Uytterhoeven
2017-08-25 8:23 ` Geert Uytterhoeven
2017-08-25 8:23 ` Geert Uytterhoeven
2017-08-27 12:46 ` Greg KH
2017-08-27 12:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613073124.GA16077@amd \
--to=pavel@ucw.cz \
--cc=bo.zhang@nxp.com \
--cc=grygorii.strashko@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.