All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields
Date: Tue, 13 Jun 2017 12:03:58 +0200	[thread overview]
Message-ID: <20170613100358.GA11444@kroah.com> (raw)
In-Reply-To: <20170606150041.10955-16-ruxandra.radulescu@nxp.com>

On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote:
> Reorder fields in the device's private structure such that
> the ones most used on the hotpath are at the beginning of
> the structure.
> 
> This brings a small performance improvement due to better
> cache usage.

Really?  What kind of performance improvement?  Always be specific.

Please fix up and resend.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Cc: devel@driverdev.osuosl.org, stuyoder@gmail.com, arnd@arndb.de,
	linux-kernel@vger.kernel.org, agraf@suse.de,
	Bharat.Bhushan@nxp.com, bogdan.purcareata@nxp.com,
	linux-arm-kernel@lists.infradead.org, laurentiu.tudor@nxp.com
Subject: Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields
Date: Tue, 13 Jun 2017 12:03:58 +0200	[thread overview]
Message-ID: <20170613100358.GA11444@kroah.com> (raw)
In-Reply-To: <20170606150041.10955-16-ruxandra.radulescu@nxp.com>

On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote:
> Reorder fields in the device's private structure such that
> the ones most used on the hotpath are at the beginning of
> the structure.
> 
> This brings a small performance improvement due to better
> cache usage.

Really?  What kind of performance improvement?  Always be specific.

Please fix up and resend.

thanks,

greg k-h

  reply	other threads:[~2017-06-13 10:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 15:00 [PATCH 00/18] staging: fsl-dpaa2/eth: Code cleanup and minor fixes Ioana Radulescu
2017-06-06 15:00 ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 01/18] staging: fsl-dpaa2/eth: Add "static" keyword where needed Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 02/18] staging: fsl-dpaa2/eth: Initialize variable before use Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 03/18] staging: fsl-dpaa2/eth: Fix return type of ndo_start_xmit Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 04/18] staging: fsl-dpaa2/eth: Remove incorrect error path Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 05/18] staging: fsl-dpaa2/eth: Add error message newlines Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 06/18] staging: fsl-dpaa2/eth: Minor cleanup in dpaa2_eth_set_hash Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 07/18] staging: fsl-dpaa2/eth: Don't use GFP_DMA Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 08/18] staging: fsl-dpaa2/eth: Always call napi_gro_receive() Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 09/18] staging: fsl-dpaa2/eth: Reset dpbp Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 10/18] staging: fsl-dpaa2/eth: Defer probing if no DPIOs found Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 11/18] staging: fsl-dpaa2/eth: Update ethtool stats names Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 12/18] staging: fsl-dpaa2/eth: Add accessor for FAS field Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 13/18] staging: fsl-dpaa2/eth: Remove unused fields from priv struct Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 14/18] staging: fsl-dpaa2/eth: Only store bpid in " Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-13 10:03   ` Greg KH [this message]
2017-06-13 10:03     ` Greg KH
2017-06-14 13:09     ` Ruxandra Ioana Radulescu
2017-06-14 13:09       ` Ruxandra Ioana Radulescu
2017-06-06 15:00 ` [PATCH 16/18] staging: fsl-dpaa2/eth: Errors checking update Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:24   ` Joe Perches
2017-06-06 15:24     ` Joe Perches
2017-06-06 15:00 ` [PATCH 17/18] staging: fsl-dpaa2/eth: Refactor MAC address setup Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu
2017-06-06 15:00 ` [PATCH 18/18] staging: fsl-dpaa2/eth: Update number of netdev queues Ioana Radulescu
2017-06-06 15:00   ` Ioana Radulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170613100358.GA11444@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.