diff for duplicates of <20170613142208.GA23872@lst.de> diff --git a/a/1.txt b/N1/1.txt index 7a18864..76bf162 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,21 +1,17 @@ On Tue, Jun 13, 2017 at 10:17:45AM -0400, Mimi Zohar wrote: -> Calling ->read directly is intentional. ?Commit C0430e49b6e7c "ima: +> Calling ->read directly is intentional. �Commit C0430e49b6e7c "ima: > introduce ima_kernel_read()" replaced the call to kernel_read with > ima_kernel_read(), the non-security checking version of kernel_read(). -> ?Subsequently, commit e3c4abbfa97e "integrity: define a new function +> �Subsequently, commit e3c4abbfa97e "integrity: define a new function > integrity_read_file()" renamed ima_read_file() to > integrity_read_file(). Again, the point is you should not call ->read for in-kernel reads. > Both NFS and OCFS define their own specific read_iter(), -> nfs_file_read() and ocfs2_file_read_iter() respectively. ?As these +> nfs_file_read() and ocfs2_file_read_iter() respectively. �As these > file systems have not yet been converted to use ->read_integrity, the > xfstests fail. So they will need to be converted. The xfstests will not just fail, it will deadlock the calling process with this code. --- -To unsubscribe from this list: send the line "unsubscribe linux-security-module" in -the body of a message to majordomo at vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 39c0ac6..c74cb7f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,32 +2,34 @@ "ref\01497031364-19949-4-git-send-email-zohar@linux.vnet.ibm.com\0" "ref\020170613064658.GB31372@lst.de\0" "ref\01497363465.21594.395.camel@linux.vnet.ibm.com\0" - "From\0hch@lst.de (Christoph Hellwig)\0" - "Subject\0[PATCH 3/4] ima: use existing read file operation method to calculate file hash\0" + "From\0Christoph Hellwig <hch@lst.de>\0" + "Subject\0Re: [PATCH 3/4] ima: use existing read file operation method to calculate file hash\0" "Date\0Tue, 13 Jun 2017 16:22:08 +0200\0" - "To\0linux-security-module@vger.kernel.org\0" + "To\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" + "Cc\0Christoph Hellwig <hch@lst.de>" + Al Viro <viro@zeniv.linux.org.uk> + James Morris <jmorris@namei.org> + linux-fsdevel@vger.kernel.org + linux-ima-devel@lists.sourceforge.net + " linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Tue, Jun 13, 2017 at 10:17:45AM -0400, Mimi Zohar wrote:\n" - "> Calling ->read directly is intentional. ?Commit C0430e49b6e7c \"ima:\n" + "> Calling ->read directly is intentional. \303\257\302\277\302\275Commit C0430e49b6e7c \"ima:\n" "> introduce ima_kernel_read()\" replaced the call to kernel_read with\n" "> ima_kernel_read(), the non-security checking version of kernel_read().\n" - "> ?Subsequently, commit e3c4abbfa97e \"integrity: define a new function\n" + "> \303\257\302\277\302\275Subsequently, commit e3c4abbfa97e \"integrity: define a new function\n" "> integrity_read_file()\" renamed ima_read_file() to\n" "> integrity_read_file().\n" "\n" "Again, the point is you should not call ->read for in-kernel reads.\n" "\n" "> Both NFS and OCFS define their own specific read_iter(),\n" - "> nfs_file_read() and ocfs2_file_read_iter() respectively. ?As these\n" + "> nfs_file_read() and ocfs2_file_read_iter() respectively. \303\257\302\277\302\275As these\n" "> file systems have not yet been converted to use ->read_integrity, the\n" "> xfstests fail.\n" "\n" "So they will need to be converted. The xfstests will not just fail,\n" - "it will deadlock the calling process with this code.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" - "the body of a message to majordomo at vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + it will deadlock the calling process with this code. -b41fdaa2ab51ef710a214cc8f8055e1c0de8735507a0977164ed162af829a899 +27db78b6730300459ea341b4db6740badcbebfa9d2d5900b26c3c11bb81c7689
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.