From: hch@lst.de (Christoph Hellwig)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 3/4] ima: use existing read file operation method to calculate file hash
Date: Tue, 13 Jun 2017 16:22:08 +0200 [thread overview]
Message-ID: <20170613142208.GA23872@lst.de> (raw)
In-Reply-To: <1497363465.21594.395.camel@linux.vnet.ibm.com>
On Tue, Jun 13, 2017 at 10:17:45AM -0400, Mimi Zohar wrote:
> Calling ->read directly is intentional. ?Commit C0430e49b6e7c "ima:
> introduce ima_kernel_read()" replaced the call to kernel_read with
> ima_kernel_read(), the non-security checking version of kernel_read().
> ?Subsequently, commit e3c4abbfa97e "integrity: define a new function
> integrity_read_file()" renamed ima_read_file() to
> integrity_read_file().
Again, the point is you should not call ->read for in-kernel reads.
> Both NFS and OCFS define their own specific read_iter(),
> nfs_file_read() and ocfs2_file_read_iter() respectively. ?As these
> file systems have not yet been converted to use ->read_integrity, the
> xfstests fail.
So they will need to be converted. The xfstests will not just fail,
it will deadlock the calling process with this code.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
James Morris <jmorris@namei.org>,
linux-fsdevel@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 3/4] ima: use existing read file operation method to calculate file hash
Date: Tue, 13 Jun 2017 16:22:08 +0200 [thread overview]
Message-ID: <20170613142208.GA23872@lst.de> (raw)
In-Reply-To: <1497363465.21594.395.camel@linux.vnet.ibm.com>
On Tue, Jun 13, 2017 at 10:17:45AM -0400, Mimi Zohar wrote:
> Calling ->read directly is intentional. �Commit C0430e49b6e7c "ima:
> introduce ima_kernel_read()" replaced the call to kernel_read with
> ima_kernel_read(), the non-security checking version of kernel_read().
> �Subsequently, commit e3c4abbfa97e "integrity: define a new function
> integrity_read_file()" renamed ima_read_file() to
> integrity_read_file().
Again, the point is you should not call ->read for in-kernel reads.
> Both NFS and OCFS define their own specific read_iter(),
> nfs_file_read() and ocfs2_file_read_iter() respectively. �As these
> file systems have not yet been converted to use ->read_integrity, the
> xfstests fail.
So they will need to be converted. The xfstests will not just fail,
it will deadlock the calling process with this code.
next prev parent reply other threads:[~2017-06-13 14:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 18:02 [PATCH 0/4] define new fs integrity_read method Mimi Zohar
2017-06-09 18:02 ` Mimi Zohar
2017-06-09 18:02 ` [PATCH 1/4] ima: use fs method to read integrity data Mimi Zohar
2017-06-09 18:02 ` Mimi Zohar
2017-06-15 23:49 ` kbuild test robot
2017-06-15 23:49 ` kbuild test robot
2017-06-16 6:18 ` Christoph Hellwig
2017-06-16 6:18 ` Christoph Hellwig
2017-06-09 18:02 ` [PATCH 2/4] tmpfs: define integrity_read file operation method Mimi Zohar
2017-06-09 18:02 ` Mimi Zohar
2017-06-09 18:02 ` [PATCH 3/4] ima: use existing read file operation method to calculate file hash Mimi Zohar
2017-06-09 18:02 ` Mimi Zohar
2017-06-13 6:46 ` Christoph Hellwig
2017-06-13 6:46 ` Christoph Hellwig
2017-06-13 14:17 ` Mimi Zohar
2017-06-13 14:17 ` Mimi Zohar
2017-06-13 14:22 ` Christoph Hellwig [this message]
2017-06-13 14:22 ` Christoph Hellwig
2017-06-13 15:07 ` Mimi Zohar
2017-06-13 15:07 ` Mimi Zohar
2017-06-14 7:03 ` Christoph Hellwig
2017-06-14 7:03 ` Christoph Hellwig
2017-07-10 14:03 ` [Linux-ima-devel] " Dmitry Kasatkin
2017-07-10 14:03 ` Dmitry Kasatkin
2017-07-10 15:12 ` Mimi Zohar
2017-07-10 15:12 ` Mimi Zohar
2017-06-09 18:02 ` [PATCH 4/4] ima: use read_iter (generic_file_read_iter) " Mimi Zohar
2017-06-09 18:02 ` Mimi Zohar
2017-07-10 14:07 ` [Linux-ima-devel] " Dmitry Kasatkin
2017-07-10 14:07 ` Dmitry Kasatkin
2017-07-10 15:22 ` Mimi Zohar
2017-07-10 15:22 ` Mimi Zohar
2017-06-09 19:47 ` [PATCH] sample xfstests IMA-appraisal test module Mimi Zohar
2017-06-09 19:47 ` Mimi Zohar
2017-06-09 19:55 ` [PATCH] sample xfstests IMA-appraisal test module (resending) Mimi Zohar
2017-06-09 19:55 ` Mimi Zohar
2017-06-13 6:47 ` Christoph Hellwig
2017-06-13 6:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613142208.GA23872@lst.de \
--to=hch@lst.de \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.