From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Andy Shevchenko" <andy@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
"Joe Perches" <joe@perches.com>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] platform/x86: wmi: Fix printing info about WDG structure
Date: Tue, 13 Jun 2017 09:52:55 -0700 [thread overview]
Message-ID: <20170613165255.GJ27850@fury> (raw)
In-Reply-To: <CAHp75VfyPe=sXU_GCRcM_mqr7W8=Bp4Va0qxv61TyhOMp+0uVA@mail.gmail.com>
On Sat, Jun 10, 2017 at 02:22:50PM +0300, Andy Shevchenko wrote:
> On Sat, Jun 10, 2017 at 1:57 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > object_id and notify_id are in one union structure and their meaning is
> > defined by flags. Therefore do not print notify_id for non-event block and
> > do not print object_id for event block. Remove also reserved member as it
> > does not have any defined meaning or type yet.
> >
> > As object_id and notify_id union members overlaps and have different types,
> > it caused that kernel print to dmesg binary data. This patch eliminates it.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks Pali, nice fix. Queued to testing.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2017-06-13 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 11:51 [PATCH] platform/x86: wmi: Fix printing info about WDG structure Pali Rohár
2017-05-27 13:07 ` Andy Shevchenko
2017-05-27 13:17 ` Pali Rohár
2017-05-27 13:23 ` Pali Rohár
2017-05-27 13:33 ` Andy Shevchenko
2017-05-27 20:48 ` Pali Rohár
2017-05-27 20:49 ` Andy Shevchenko
2017-06-08 15:16 ` Darren Hart
2017-06-08 15:38 ` Joe Perches
2017-06-08 17:42 ` Andy Shevchenko
2017-06-08 17:44 ` Andy Shevchenko
2017-06-08 18:18 ` Pali Rohár
2017-06-09 8:29 ` Pali Rohár
2017-06-09 9:29 ` Andy Shevchenko
2017-06-10 10:57 ` [PATCH v2] " Pali Rohár
2017-06-10 11:22 ` Andy Shevchenko
2017-06-13 16:52 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613165255.GJ27850@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.