From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
qemu-ppc@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device
Date: Wed, 14 Jun 2017 09:36:11 +0800 [thread overview]
Message-ID: <20170614013611.GD13420@umbus> (raw)
In-Reply-To: <1497383329-10393-1-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
On Tue, Jun 13, 2017 at 09:48:49PM +0200, Thomas Huth wrote:
> This way the bridge shows up in the correct section of the
> "-device help" text.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/pci-bridge/dec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c
> index cca9362..eb275e1 100644
> --- a/hw/pci-bridge/dec.c
> +++ b/hw/pci-bridge/dec.c
> @@ -62,6 +62,7 @@ static void dec_21154_pci_bridge_class_init(ObjectClass *klass, void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>
> + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> k->realize = dec_pci_bridge_realize;
> k->exit = pci_bridge_exitfn;
> k->vendor_id = PCI_VENDOR_ID_DEC;
> @@ -118,6 +119,7 @@ static void dec_21154_pci_host_class_init(ObjectClass *klass, void *data)
> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> k->realize = dec_21154_pci_host_realize;
> k->vendor_id = PCI_VENDOR_ID_DEC;
> k->device_id = PCI_DEVICE_ID_DEC_21154;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
qemu-ppc@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device
Date: Wed, 14 Jun 2017 09:36:11 +0800 [thread overview]
Message-ID: <20170614013611.GD13420@umbus> (raw)
In-Reply-To: <1497383329-10393-1-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
On Tue, Jun 13, 2017 at 09:48:49PM +0200, Thomas Huth wrote:
> This way the bridge shows up in the correct section of the
> "-device help" text.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/pci-bridge/dec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c
> index cca9362..eb275e1 100644
> --- a/hw/pci-bridge/dec.c
> +++ b/hw/pci-bridge/dec.c
> @@ -62,6 +62,7 @@ static void dec_21154_pci_bridge_class_init(ObjectClass *klass, void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>
> + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> k->realize = dec_pci_bridge_realize;
> k->exit = pci_bridge_exitfn;
> k->vendor_id = PCI_VENDOR_ID_DEC;
> @@ -118,6 +119,7 @@ static void dec_21154_pci_host_class_init(ObjectClass *klass, void *data)
> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> k->realize = dec_21154_pci_host_realize;
> k->vendor_id = PCI_VENDOR_ID_DEC;
> k->device_id = PCI_DEVICE_ID_DEC_21154;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-14 1:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 19:48 [Qemu-trivial] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device Thomas Huth
2017-06-13 19:48 ` [Qemu-devel] " Thomas Huth
2017-06-13 19:58 ` [Qemu-trivial] " no-reply
2017-06-13 19:58 ` no-reply
2017-06-14 2:19 ` [Qemu-trivial] " Michael S. Tsirkin
2017-06-14 2:19 ` Michael S. Tsirkin
2017-06-14 2:30 ` [Qemu-trivial] " David Gibson
2017-06-14 2:30 ` David Gibson
2017-06-14 4:53 ` [Qemu-trivial] " Fam Zheng
2017-06-14 4:53 ` Fam Zheng
2017-06-14 1:36 ` David Gibson [this message]
2017-06-14 1:36 ` David Gibson
2017-06-19 12:11 ` [Qemu-trivial] " Marcel Apfelbaum
2017-06-19 12:11 ` [Qemu-devel] " Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614013611.GD13420@umbus \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.