All of lore.kernel.org
 help / color / mirror / Atom feed
From: jens.wiklander@linaro.org (Jens Wiklander)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tee: add forward declaration for struct device
Date: Wed, 14 Jun 2017 11:46:11 +0200	[thread overview]
Message-ID: <20170614094610.GA12598@jax> (raw)
In-Reply-To: <2bcbf7b0-7dba-7e72-72fd-4da922e442bb@linaro.org>

On Wed, Jun 14, 2017 at 11:39:50AM +0200, Jerome Forissier wrote:
> [+Arnd]
> 
> Ping?
> 
> Thanks,
> -- 
> Jerome
> 
> On 05/31/2017 01:21 PM, Jerome Forissier wrote:
> > tee_drv.h references struct device, but does not include device.h nor
> > platform_device.h. Therefore, if tee_drv.h is included by some file
> > that does not pull device.h nor platform_device.h beforehand, we have a
> > compile warning. Fix this by adding a forward declaration.
> > 
> > Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> > ---
> >  include/linux/tee_drv.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
> > index 8614713..07bd226 100644
> > --- a/include/linux/tee_drv.h
> > +++ b/include/linux/tee_drv.h
> > @@ -29,6 +29,7 @@
> >  #define TEE_SHM_DMA_BUF		BIT(1)	/* Memory with dma-buf handle */
> >  #define TEE_SHM_EXT_DMA_BUF	BIT(2)	/* Memory with dma-buf handle */
> >  
> > +struct device;
> >  struct tee_device;
> >  struct tee_shm;
> >  struct tee_shm_pool;
> > 

Looks good to me.

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

--
Thanks,
Jens

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Jerome Forissier <jerome.forissier@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, tee-dev@lists.linaro.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] tee: add forward declaration for struct device
Date: Wed, 14 Jun 2017 11:46:11 +0200	[thread overview]
Message-ID: <20170614094610.GA12598@jax> (raw)
In-Reply-To: <2bcbf7b0-7dba-7e72-72fd-4da922e442bb@linaro.org>

On Wed, Jun 14, 2017 at 11:39:50AM +0200, Jerome Forissier wrote:
> [+Arnd]
> 
> Ping?
> 
> Thanks,
> -- 
> Jerome
> 
> On 05/31/2017 01:21 PM, Jerome Forissier wrote:
> > tee_drv.h references struct device, but does not include device.h nor
> > platform_device.h. Therefore, if tee_drv.h is included by some file
> > that does not pull device.h nor platform_device.h beforehand, we have a
> > compile warning. Fix this by adding a forward declaration.
> > 
> > Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> > ---
> >  include/linux/tee_drv.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
> > index 8614713..07bd226 100644
> > --- a/include/linux/tee_drv.h
> > +++ b/include/linux/tee_drv.h
> > @@ -29,6 +29,7 @@
> >  #define TEE_SHM_DMA_BUF		BIT(1)	/* Memory with dma-buf handle */
> >  #define TEE_SHM_EXT_DMA_BUF	BIT(2)	/* Memory with dma-buf handle */
> >  
> > +struct device;
> >  struct tee_device;
> >  struct tee_shm;
> >  struct tee_shm_pool;
> > 

Looks good to me.

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

--
Thanks,
Jens

  reply	other threads:[~2017-06-14  9:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 11:21 [PATCH] tee: add forward declaration for struct device Jerome Forissier
2017-05-31 11:21 ` Jerome Forissier
2017-06-14  9:39 ` Jerome Forissier
2017-06-14  9:39   ` Jerome Forissier
2017-06-14  9:46   ` Jens Wiklander [this message]
2017-06-14  9:46     ` Jens Wiklander
2017-06-14 11:01     ` Arnd Bergmann
2017-06-14 11:01       ` Arnd Bergmann
2017-06-14 11:06       ` Jerome Forissier
2017-06-14 11:06         ` Jerome Forissier
2017-06-14 11:59         ` Arnd Bergmann
2017-06-14 11:59           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614094610.GA12598@jax \
    --to=jens.wiklander@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.