All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 10/11] dt-bindings: orion-mdio: document the new xmdio compatible
Date: Wed, 14 Jun 2017 18:35:37 +0200	[thread overview]
Message-ID: <20170614163537.GO15847@lunn.ch> (raw)
In-Reply-To: <20170614154911.14510-11-antoine.tenart@free-electrons.com>

On Wed, Jun 14, 2017 at 05:49:10PM +0200, Antoine Tenart wrote:
> A new compatible for Marvell xMDIO interfaces was added into the Marvell
> MDIO driver. Document this new compatible.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt
> index ccdabdcc8618..b93a5b5a0472 100644
> --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt
> +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt
> @@ -1,12 +1,12 @@
>  * Marvell MDIO Ethernet Controller interface
>  
>  The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x,
> -MV78xx0, Armada 370 and Armada XP have an identical unit that provides
> -an interface with the MDIO bus. This driver handles this MDIO
> -interface.
> +MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an
> +identical unit that provides an interface with the MDIO bus or
> +with the xMDIO bus. This driver handles these interfaces.

Hi Antoine

This patches is looking good now. One nit. The description above
suggests Kirkwood, Dove, Orion5x, MV78xx0, Armada 370 and Armada XP
all have xmdio. Maybe better wording would be:

The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x,
MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an
identical unit that provides an interface with the MDIO bus.
Additionally, Armada 7k and Armada 8k has a second unit which
provides an interface with the xMDIO bus. This driver handles
these interfaces.

      Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, jason@lakedaemon.net,
	gregory.clement@free-electrons.com,
	sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com,
	thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
	mw@semihalf.com, linux@armlinux.org.uk, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 10/11] dt-bindings: orion-mdio: document the new xmdio compatible
Date: Wed, 14 Jun 2017 18:35:37 +0200	[thread overview]
Message-ID: <20170614163537.GO15847@lunn.ch> (raw)
In-Reply-To: <20170614154911.14510-11-antoine.tenart@free-electrons.com>

On Wed, Jun 14, 2017 at 05:49:10PM +0200, Antoine Tenart wrote:
> A new compatible for Marvell xMDIO interfaces was added into the Marvell
> MDIO driver. Document this new compatible.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt
> index ccdabdcc8618..b93a5b5a0472 100644
> --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt
> +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt
> @@ -1,12 +1,12 @@
>  * Marvell MDIO Ethernet Controller interface
>  
>  The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x,
> -MV78xx0, Armada 370 and Armada XP have an identical unit that provides
> -an interface with the MDIO bus. This driver handles this MDIO
> -interface.
> +MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an
> +identical unit that provides an interface with the MDIO bus or
> +with the xMDIO bus. This driver handles these interfaces.

Hi Antoine

This patches is looking good now. One nit. The description above
suggests Kirkwood, Dove, Orion5x, MV78xx0, Armada 370 and Armada XP
all have xmdio. Maybe better wording would be:

The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x,
MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an
identical unit that provides an interface with the MDIO bus.
Additionally, Armada 7k and Armada 8k has a second unit which
provides an interface with the xMDIO bus. This driver handles
these interfaces.

      Andrew

  reply	other threads:[~2017-06-14 16:35 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 15:49 [PATCH v4 00/11] net: mvmdio: add xMDIO xSMI support Antoine Tenart
2017-06-14 15:49 ` Antoine Tenart
2017-06-14 15:49 ` [PATCH v4 01/11] net: mvmdio: reorder headers alphabetically Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 15:49 ` [PATCH v4 02/11] net: mvmdio: use tabs for defines Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 15:49 ` [PATCH v4 03/11] net: mvmdio: use GENMASK for masks Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-19 11:57   ` David Laight
2017-06-19 11:57     ` David Laight
2017-06-19 14:49     ` David Miller
2017-06-19 14:49       ` David Miller
2017-06-14 15:49 ` [PATCH v4 04/11] net: mvmdio: remove duplicate locking Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 17:01   ` Florian Fainelli
2017-06-14 17:01     ` Florian Fainelli
2017-06-14 15:49 ` [PATCH v4 05/11] net: mvmdio: introduce an ops structure Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 17:02   ` Florian Fainelli
2017-06-14 17:02     ` Florian Fainelli
2017-06-14 15:49 ` [PATCH v4 06/11] net: mvmdio: put the poll intervals in the " Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 17:02   ` Florian Fainelli
2017-06-14 17:02     ` Florian Fainelli
2017-06-14 15:49 ` [PATCH v4 07/11] net: mvmdio: check the MII_ADDR_C45 bit is not set for smi operations Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 17:02   ` Florian Fainelli
2017-06-14 17:02     ` Florian Fainelli
2017-06-14 15:49 ` [PATCH v4 08/11] net: mvmdio: add xmdio xsmi support Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 17:03   ` Florian Fainelli
2017-06-14 17:03     ` Florian Fainelli
2017-06-14 15:49 ` [PATCH v4 09/11] net: mvmdio: simplify the smi read and write error paths Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 17:04   ` Florian Fainelli
2017-06-14 17:04     ` Florian Fainelli
2017-06-14 15:49 ` [PATCH v4 10/11] dt-bindings: orion-mdio: document the new xmdio compatible Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart
2017-06-14 16:35   ` Andrew Lunn [this message]
2017-06-14 16:35     ` Andrew Lunn
2017-06-15  6:55     ` Antoine Tenart
2017-06-15  6:55       ` Antoine Tenart
2017-06-15 13:12       ` Andrew Lunn
2017-06-15 13:12         ` Andrew Lunn
2017-06-15 13:22         ` Antoine Tenart
2017-06-15 13:22           ` Antoine Tenart
2017-06-14 15:49 ` [PATCH v4 11/11] arm64: marvell: dts: add xmdio nodes for 7k/8k Antoine Tenart
2017-06-14 15:49   ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614163537.GO15847@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.