From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/12] coresight tmc: Expose DBA and AXICTL
Date: Wed, 14 Jun 2017 11:50:42 -0600 [thread overview]
Message-ID: <20170614175042.GB22030@xps15> (raw)
In-Reply-To: <1497278211-5001-7-git-send-email-suzuki.poulose@arm.com>
On Mon, Jun 12, 2017 at 03:36:45PM +0100, Suzuki K Poulose wrote:
> Expose DBALO,DBAHI and AXICTL registers
Why is this needed? I fear we are exposing internal kernel information.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-tmc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
> index 7025982..fd5a2e0 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc.c
> @@ -228,9 +228,11 @@ coresight_tmc_simple_func(ffcr, TMC_FFCR);
> coresight_tmc_simple_func(mode, TMC_MODE);
> coresight_tmc_simple_func(pscr, TMC_PSCR);
> coresight_tmc_simple_func(devid, CORESIGHT_DEVID);
> +coresight_tmc_simple_func(axictl, TMC_AXICTL);
>
> coresight_simple_reg64(struct tmc_drvdata, rrp, TMC_RRP, TMC_RRPHI);
> coresight_simple_reg64(struct tmc_drvdata, rwp, TMC_RWP, TMC_RWPHI);
> +coresight_simple_reg64(struct tmc_drvdata, dba, TMC_DBALO, TMC_DBAHI);
>
> static struct attribute *coresight_tmc_mgmt_attrs[] = {
> &dev_attr_rsz.attr,
> @@ -244,6 +246,8 @@ static struct attribute *coresight_tmc_mgmt_attrs[] = {
> &dev_attr_mode.attr,
> &dev_attr_pscr.attr,
> &dev_attr_devid.attr,
> + &dev_attr_dba.attr,
> + &dev_attr_axictl.attr,
> NULL,
> };
>
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/12] coresight tmc: Expose DBA and AXICTL
Date: Wed, 14 Jun 2017 11:50:42 -0600 [thread overview]
Message-ID: <20170614175042.GB22030@xps15> (raw)
In-Reply-To: <1497278211-5001-7-git-send-email-suzuki.poulose@arm.com>
On Mon, Jun 12, 2017 at 03:36:45PM +0100, Suzuki K Poulose wrote:
> Expose DBALO,DBAHI and AXICTL registers
Why is this needed? I fear we are exposing internal kernel information.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-tmc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
> index 7025982..fd5a2e0 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc.c
> @@ -228,9 +228,11 @@ coresight_tmc_simple_func(ffcr, TMC_FFCR);
> coresight_tmc_simple_func(mode, TMC_MODE);
> coresight_tmc_simple_func(pscr, TMC_PSCR);
> coresight_tmc_simple_func(devid, CORESIGHT_DEVID);
> +coresight_tmc_simple_func(axictl, TMC_AXICTL);
>
> coresight_simple_reg64(struct tmc_drvdata, rrp, TMC_RRP, TMC_RRPHI);
> coresight_simple_reg64(struct tmc_drvdata, rwp, TMC_RWP, TMC_RWPHI);
> +coresight_simple_reg64(struct tmc_drvdata, dba, TMC_DBALO, TMC_DBAHI);
>
> static struct attribute *coresight_tmc_mgmt_attrs[] = {
> &dev_attr_rsz.attr,
> @@ -244,6 +246,8 @@ static struct attribute *coresight_tmc_mgmt_attrs[] = {
> &dev_attr_mode.attr,
> &dev_attr_pscr.attr,
> &dev_attr_devid.attr,
> + &dev_attr_dba.attr,
> + &dev_attr_axictl.attr,
> NULL,
> };
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-06-14 17:50 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 14:36 [PATCH 00/12] coresight: Support for ARM Coresight SoC-600 Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 01/12] coresight replicator: Cleanup programmable replicator naming Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-13 16:55 ` Mathieu Poirier
2017-06-13 16:55 ` Mathieu Poirier
2017-06-13 16:55 ` Mathieu Poirier
2017-06-13 17:56 ` Suzuki K Poulose
2017-06-13 17:56 ` Suzuki K Poulose
2017-06-18 14:04 ` Rob Herring
2017-06-18 14:04 ` Rob Herring
2017-06-20 16:44 ` Mathieu Poirier
2017-06-20 16:44 ` Mathieu Poirier
2017-06-20 16:44 ` Mathieu Poirier
2017-06-22 3:21 ` Rob Herring
2017-06-22 3:21 ` Rob Herring
2017-06-22 3:21 ` Rob Herring
2017-06-12 14:36 ` [PATCH 02/12] arm64: dts: juno: Use the new coresight replicator string Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 03/12] coresight: Extend the PIDR mask to cover relevant bits in PIDR2 Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-13 17:53 ` Mathieu Poirier
2017-06-13 17:53 ` Mathieu Poirier
2017-06-13 17:55 ` Suzuki K Poulose
2017-06-13 17:55 ` Suzuki K Poulose
2017-06-13 19:06 ` Mathieu Poirier
2017-06-13 19:06 ` Mathieu Poirier
2017-06-12 14:36 ` [PATCH 04/12] coresight: Add support for reading 64bit registers Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-13 17:45 ` Mathieu Poirier
2017-06-13 17:45 ` Mathieu Poirier
2017-06-13 17:57 ` Suzuki K Poulose
2017-06-13 17:57 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 05/12] coresight tmc: Add helpers for accessing " Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-14 17:49 ` Mathieu Poirier
2017-06-14 17:49 ` Mathieu Poirier
2017-06-15 10:13 ` Suzuki K Poulose
2017-06-15 10:13 ` Suzuki K Poulose
2017-06-15 13:29 ` Mike Leach
2017-06-15 13:29 ` Mike Leach
2017-06-15 14:24 ` Mathieu Poirier
2017-06-15 14:24 ` Mathieu Poirier
2017-06-12 14:36 ` [PATCH 06/12] coresight tmc: Expose DBA and AXICTL Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-14 17:50 ` Mathieu Poirier [this message]
2017-06-14 17:50 ` Mathieu Poirier
2017-06-15 10:19 ` Suzuki K Poulose
2017-06-15 10:19 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 07/12] coresight replicator: Expose replicator management registers Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-14 17:54 ` Mathieu Poirier
2017-06-14 17:54 ` Mathieu Poirier
2017-06-15 10:23 ` Suzuki K Poulose
2017-06-15 10:23 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 08/12] coresight tmc: Handle configuration types properly Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-14 17:59 ` Mathieu Poirier
2017-06-14 17:59 ` Mathieu Poirier
2017-06-15 10:25 ` Suzuki K Poulose
2017-06-15 10:25 ` Suzuki K Poulose
2017-06-15 14:33 ` Mathieu Poirier
2017-06-15 14:33 ` Mathieu Poirier
2017-06-12 14:36 ` [PATCH 09/12] coresight tmc: Add capability information Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-14 18:22 ` Mathieu Poirier
2017-06-14 18:22 ` Mathieu Poirier
2017-06-15 10:30 ` Suzuki K Poulose
2017-06-15 10:30 ` Suzuki K Poulose
2017-06-15 14:37 ` Mathieu Poirier
2017-06-15 14:37 ` Mathieu Poirier
2017-06-12 14:36 ` [PATCH 10/12] coresight tmc: Support for save-restore in ETR Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 11/12] coresight tmc: Add support for Coresight SoC 600 TMC Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
2017-06-14 18:25 ` Mathieu Poirier
2017-06-14 18:25 ` Mathieu Poirier
2017-06-15 10:31 ` Suzuki K Poulose
2017-06-15 10:31 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 12/12] coresight: Add support for Coresight SoC 600 components Suzuki K Poulose
2017-06-12 14:36 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614175042.GB22030@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.