From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfrm: Oops on error in pfkey_msg2xfrm_state()
Date: Thu, 15 Jun 2017 11:56:58 +0000 [thread overview]
Message-ID: <20170615115658.GG2631@secunet.com> (raw)
In-Reply-To: <20170614103405.GI29394@elgon.mountain>
On Wed, Jun 14, 2017 at 01:34:05PM +0300, Dan Carpenter wrote:
> There are some missing error codes here so we accidentally return NULL
> instead of an error pointer. It results in a NULL pointer dereference.
>
> Fixes: df71837d5024 ("[LSM-IPSec]: Security association restriction.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] xfrm: Oops on error in pfkey_msg2xfrm_state()
Date: Thu, 15 Jun 2017 13:56:58 +0200 [thread overview]
Message-ID: <20170615115658.GG2631@secunet.com> (raw)
In-Reply-To: <20170614103405.GI29394@elgon.mountain>
On Wed, Jun 14, 2017 at 01:34:05PM +0300, Dan Carpenter wrote:
> There are some missing error codes here so we accidentally return NULL
> instead of an error pointer. It results in a NULL pointer dereference.
>
> Fixes: df71837d5024 ("[LSM-IPSec]: Security association restriction.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied, thanks!
next prev parent reply other threads:[~2017-06-15 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 10:34 [PATCH] xfrm: Oops on error in pfkey_msg2xfrm_state() Dan Carpenter
2017-06-14 10:34 ` Dan Carpenter
2017-06-15 11:56 ` Steffen Klassert [this message]
2017-06-15 11:56 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615115658.GG2631@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.