[renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git drivers-for-v4.13
head:   895c7e91d84c0f0e207ad909482ed70b5f3c806f
commit: 895c7e91d84c0f0e207ad909482ed70b5f3c806f [3/3] soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 895c7e91d84c0f0e207ad909482ed70b5f3c806f
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   drivers/soc/renesas/rcar-sysc.c: In function 'rcar_sysc_pd_setup':
>> drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared (first use in this function)
      genpd->flags |= GENPD_FLAG_ALWAYS_ON;
                      ^~~~~~~~~~~~~~~~~~~~
   drivers/soc/renesas/rcar-sysc.c:209:19: note: each undeclared identifier is reported only once for each function it appears in

vim +/GENPD_FLAG_ALWAYS_ON +209 drivers/soc/renesas/rcar-sysc.c

   203		if (pd->flags & PD_CPU) {
   204			/*
   205			 * This domain contains a CPU core and therefore it should
   206			 * only be turned off if the CPU is not in use.
   207			 */
   208			pr_debug("PM domain %s contains %s\n", name, "CPU");
 > 209			genpd->flags |= GENPD_FLAG_ALWAYS_ON;
   210		} else if (pd->flags & PD_SCU) {
   211			/*
   212			 * This domain contains an SCU and cache-controller, and

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 46813 bytes --]

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Geert Uytterhoeven]

Hi Simon,

On Wed, Jun 14, 2017 at 1:04 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git drivers-for-v4.13
> head:   895c7e91d84c0f0e207ad909482ed70b5f3c806f
> commit: 895c7e91d84c0f0e207ad909482ed70b5f3c806f [3/3] soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 6.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 895c7e91d84c0f0e207ad909482ed70b5f3c806f
>         # save the attached .config to linux build tree
>         make.cross ARCH=ia64
>
> All errors (new ones prefixed by >>):
>
>    drivers/soc/renesas/rcar-sysc.c: In function 'rcar_sysc_pd_setup':
>>> drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared (first use in this function)
>       genpd->flags |= GENPD_FLAG_ALWAYS_ON;

Looks like your drivers-for-v4.13 is based on v4.11-rc1
(renesas-fixes-for-v4.12) instead of v4.12-rc1.
Can you please rebase it?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Simon Horman]

On Wed, Jun 14, 2017 at 01:31:41PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Jun 14, 2017 at 1:04 PM, kbuild test robot
> <fengguang.wu@intel.com> wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git drivers-for-v4.13
> > head:   895c7e91d84c0f0e207ad909482ed70b5f3c806f
> > commit: 895c7e91d84c0f0e207ad909482ed70b5f3c806f [3/3] soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON
> > config: ia64-allmodconfig (attached as .config)
> > compiler: ia64-linux-gcc (GCC) 6.2.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 895c7e91d84c0f0e207ad909482ed70b5f3c806f
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=ia64
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/soc/renesas/rcar-sysc.c: In function 'rcar_sysc_pd_setup':
> >>> drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared (first use in this function)
> >       genpd->flags |= GENPD_FLAG_ALWAYS_ON;
> 
> Looks like your drivers-for-v4.13 is based on v4.11-rc1
> (renesas-fixes-for-v4.12) instead of v4.12-rc1.
> Can you please rebase it?

It is based on renesas-fixes-for-v4.12 because I was under the impression
that the patch there is a dependency for (other) patches in renesas drivers.
Is that the case? If so I think the correct (new) base would be v4.12-rc2.

> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Geert Uytterhoeven]

Hi Simon,

On Thu, Jun 15, 2017 at 3:45 PM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Jun 14, 2017 at 01:31:41PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Jun 14, 2017 at 1:04 PM, kbuild test robot
>> <fengguang.wu@intel.com> wrote:
>> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git drivers-for-v4.13
>> > head:   895c7e91d84c0f0e207ad909482ed70b5f3c806f
>> > commit: 895c7e91d84c0f0e207ad909482ed70b5f3c806f [3/3] soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON
>> > config: ia64-allmodconfig (attached as .config)
>> > compiler: ia64-linux-gcc (GCC) 6.2.0
>> > reproduce:
>> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> >         chmod +x ~/bin/make.cross
>> >         git checkout 895c7e91d84c0f0e207ad909482ed70b5f3c806f
>> >         # save the attached .config to linux build tree
>> >         make.cross ARCH=ia64
>> >
>> > All errors (new ones prefixed by >>):
>> >
>> >    drivers/soc/renesas/rcar-sysc.c: In function 'rcar_sysc_pd_setup':
>> >>> drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared (first use in this function)
>> >       genpd->flags |= GENPD_FLAG_ALWAYS_ON;
>>
>> Looks like your drivers-for-v4.13 is based on v4.11-rc1
>> (renesas-fixes-for-v4.12) instead of v4.12-rc1.
>> Can you please rebase it?
>
> It is based on renesas-fixes-for-v4.12 because I was under the impression
> that the patch there is a dependency for (other) patches in renesas drivers.
> Is that the case? If so I think the correct (new) base would be v4.12-rc2.

"soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON" in drivers-for-v4.13
depends on commit ffaa42e8a40b7f10 ("PM / Domains: Enable users of genpd
to specify always on PM domains") in v4.12-rc1.

It does not depend on anything else that's only in fixes-for-v4.12.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Simon Horman]

On Thu, Jun 15, 2017 at 04:08:56PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Jun 15, 2017 at 3:45 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Jun 14, 2017 at 01:31:41PM +0200, Geert Uytterhoeven wrote:
> >> On Wed, Jun 14, 2017 at 1:04 PM, kbuild test robot
> >> <fengguang.wu@intel.com> wrote:
> >> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git drivers-for-v4.13
> >> > head:   895c7e91d84c0f0e207ad909482ed70b5f3c806f
> >> > commit: 895c7e91d84c0f0e207ad909482ed70b5f3c806f [3/3] soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON
> >> > config: ia64-allmodconfig (attached as .config)
> >> > compiler: ia64-linux-gcc (GCC) 6.2.0
> >> > reproduce:
> >> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >> >         chmod +x ~/bin/make.cross
> >> >         git checkout 895c7e91d84c0f0e207ad909482ed70b5f3c806f
> >> >         # save the attached .config to linux build tree
> >> >         make.cross ARCH=ia64
> >> >
> >> > All errors (new ones prefixed by >>):
> >> >
> >> >    drivers/soc/renesas/rcar-sysc.c: In function 'rcar_sysc_pd_setup':
> >> >>> drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared (first use in this function)
> >> >       genpd->flags |= GENPD_FLAG_ALWAYS_ON;
> >>
> >> Looks like your drivers-for-v4.13 is based on v4.11-rc1
> >> (renesas-fixes-for-v4.12) instead of v4.12-rc1.
> >> Can you please rebase it?
> >
> > It is based on renesas-fixes-for-v4.12 because I was under the impression
> > that the patch there is a dependency for (other) patches in renesas drivers.
> > Is that the case? If so I think the correct (new) base would be v4.12-rc2.
> 
> "soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON" in drivers-for-v4.13
> depends on commit ffaa42e8a40b7f10 ("PM / Domains: Enable users of genpd
> to specify always on PM domains") in v4.12-rc1.
> 
> It does not depend on anything else that's only in fixes-for-v4.12.

Ok, that is clear. But for some reason I thought that

"soc: renesas: Rework Kconfig and Makefile logic" depends on
"soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing"

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Geert Uytterhoeven]

Hi Simon,

On Thu, Jun 15, 2017 at 4:20 PM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Jun 15, 2017 at 04:08:56PM +0200, Geert Uytterhoeven wrote:
>> On Thu, Jun 15, 2017 at 3:45 PM, Simon Horman <horms@verge.net.au> wrote:
>> depends on commit ffaa42e8a40b7f10 ("PM / Domains: Enable users of genpd
>> to specify always on PM domains") in v4.12-rc1.
>>
>> It does not depend on anything else that's only in fixes-for-v4.12.
>
> Ok, that is clear. But for some reason I thought that
>
> "soc: renesas: Rework Kconfig and Makefile logic" depends on
> "soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing"

Yes, it does, as the former reworks the dummy provided by the latter.

But "soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON" does not depend
on any of these.

But now I understand the issue you're facing: drivers-for-v4.13 depends both on
commits in v4.12-rc1, and on fixes still destined for v4.12.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Simon Horman]

On Thu, Jun 15, 2017 at 04:31:48PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Jun 15, 2017 at 4:20 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Jun 15, 2017 at 04:08:56PM +0200, Geert Uytterhoeven wrote:
> >> On Thu, Jun 15, 2017 at 3:45 PM, Simon Horman <horms@verge.net.au> wrote:
> >> depends on commit ffaa42e8a40b7f10 ("PM / Domains: Enable users of genpd
> >> to specify always on PM domains") in v4.12-rc1.
> >>
> >> It does not depend on anything else that's only in fixes-for-v4.12.
> >
> > Ok, that is clear. But for some reason I thought that
> >
> > "soc: renesas: Rework Kconfig and Makefile logic" depends on
> > "soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing"
> 
> Yes, it does, as the former reworks the dummy provided by the latter.
> 
> But "soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON" does not depend
> on any of these.
> 
> But now I understand the issue you're facing: drivers-for-v4.13 depends both on
> commits in v4.12-rc1, and on fixes still destined for v4.12.

Yes, that is the one.

I think the simplest solution is to base drivers-for-v4.13 on a merge of
v4.12-rc1 and fixes-for-v4.13.

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Simon Horman]

On Thu, Jun 15, 2017 at 08:52:31PM +0200, Simon Horman wrote:
> On Thu, Jun 15, 2017 at 04:31:48PM +0200, Geert Uytterhoeven wrote:
> > Hi Simon,
> > 
> > On Thu, Jun 15, 2017 at 4:20 PM, Simon Horman <horms@verge.net.au> wrote:
> > > On Thu, Jun 15, 2017 at 04:08:56PM +0200, Geert Uytterhoeven wrote:
> > >> On Thu, Jun 15, 2017 at 3:45 PM, Simon Horman <horms@verge.net.au> wrote:
> > >> depends on commit ffaa42e8a40b7f10 ("PM / Domains: Enable users of genpd
> > >> to specify always on PM domains") in v4.12-rc1.
> > >>
> > >> It does not depend on anything else that's only in fixes-for-v4.12.
> > >
> > > Ok, that is clear. But for some reason I thought that
> > >
> > > "soc: renesas: Rework Kconfig and Makefile logic" depends on
> > > "soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing"
> > 
> > Yes, it does, as the former reworks the dummy provided by the latter.
> > 
> > But "soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON" does not depend
> > on any of these.
> > 
> > But now I understand the issue you're facing: drivers-for-v4.13 depends both on
> > commits in v4.12-rc1, and on fixes still destined for v4.12.
> 
> Yes, that is the one.
> 
> I think the simplest solution is to base drivers-for-v4.13 on a merge of
> v4.12-rc1 and fixes-for-v4.13.

For now I have gone with separate branches, this seems to be yet simpler.

Re: [renesas:drivers-for-v4.13 3/3] drivers/soc/renesas/rcar-sysc.c:209:19: error: 'GENPD_FLAG_ALWAYS_ON' undeclared

[Geert Uytterhoeven]

Hi Simon,

On Thu, Jun 15, 2017 at 9:15 PM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Jun 15, 2017 at 08:52:31PM +0200, Simon Horman wrote:
>> On Thu, Jun 15, 2017 at 04:31:48PM +0200, Geert Uytterhoeven wrote:
>> > On Thu, Jun 15, 2017 at 4:20 PM, Simon Horman <horms@verge.net.au> wrote:
>> > > On Thu, Jun 15, 2017 at 04:08:56PM +0200, Geert Uytterhoeven wrote:
>> > >> On Thu, Jun 15, 2017 at 3:45 PM, Simon Horman <horms@verge.net.au> wrote:
>> > >> depends on commit ffaa42e8a40b7f10 ("PM / Domains: Enable users of genpd
>> > >> to specify always on PM domains") in v4.12-rc1.
>> > >>
>> > >> It does not depend on anything else that's only in fixes-for-v4.12.
>> > >
>> > > Ok, that is clear. But for some reason I thought that
>> > >
>> > > "soc: renesas: Rework Kconfig and Makefile logic" depends on
>> > > "soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing"
>> >
>> > Yes, it does, as the former reworks the dummy provided by the latter.
>> >
>> > But "soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON" does not depend
>> > on any of these.
>> >
>> > But now I understand the issue you're facing: drivers-for-v4.13 depends both on
>> > commits in v4.12-rc1, and on fixes still destined for v4.12.
>>
>> Yes, that is the one.
>>
>> I think the simplest solution is to base drivers-for-v4.13 on a merge of
>> v4.12-rc1 and fixes-for-v4.13.
>
> For now I have gone with separate branches, this seems to be yet simpler.

Thanks, that's also an acceptable solution.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds