All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] ext2: support EXT4_FEATURE_INCOMPAT_ENCRYPT
Date: Thu, 15 Jun 2017 12:42:18 -0700	[thread overview]
Message-ID: <20170615194218.GA581@zzz> (raw)
In-Reply-To: <CAEaD8JM4Ou5MoLQrL9s0HQYD=zCF9ajJFx18JdP54YhX5r00cw@mail.gmail.com>

Hi Vladimir,

On Thu, Jun 15, 2017 at 11:12:32AM +0000, Vladimir 'phcoder' Serbinenko wrote:
> Good. Thank you for doing this. Please don't mark obscure error messages
> for translation (N_). In this patch no string needs translation. Would it
> also be possible to add some tests?

Thanks for the review; I've sent v2 which removes the N_() calls and adds an
ext4_encrypt test to grub-fs-tester.

One caveat is that formatting and mounting a filesystem with '-O encrypt' is
only possible with e2fsprogs v1.43+ and Linux v4.1+.  Perhaps those should be
detected as a prerequisite?  I don't think there's a good way to detect the
encryption support other than trying it and seeing if it works, though.

Eric


      reply	other threads:[~2017-06-15 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  5:36 [PATCH] ext2: support EXT4_FEATURE_INCOMPAT_ENCRYPT Eric Biggers
2017-06-15 11:12 ` Vladimir 'phcoder' Serbinenko
2017-06-15 19:42   ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615194218.GA581@zzz \
    --to=ebiggers3@gmail.com \
    --cc=ebiggers@google.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.