From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] nvme-pci: Split __nvme_process_cq to poll and handle
Date: Fri, 16 Jun 2017 09:04:09 +0200 [thread overview]
Message-ID: <20170616070408.GA7672@lst.de> (raw)
In-Reply-To: <1497548508-29447-2-git-send-email-sagi@grimberg.me>
I like this split, but I think the patch as-is is not easily
verifyable. Can you break it out by splitting out one helper
at a time, e.g.
patch 1: introduce nvme_ring_cq_doorbell
patch 2: introduce nvme_handle_cqe
patch 3: introduce nvme_read_cqe
Also there seems ot be no reason in the this patch to change the
__nvme_process_cq and nvme_process_cq return values.
next prev parent reply other threads:[~2017-06-16 7:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 17:41 [PATCH 0/3] refactor nvme-pci cq processing Sagi Grimberg
2017-06-15 17:41 ` [PATCH 1/3] nvme-pci: Split __nvme_process_cq to poll and handle Sagi Grimberg
2017-06-16 7:04 ` Christoph Hellwig [this message]
2017-06-15 17:41 ` [PATCH 2/3] nvme-pci: Add budget to __nvme_process_cq Sagi Grimberg
2017-06-16 7:04 ` Christoph Hellwig
2017-06-18 9:27 ` Sagi Grimberg
2017-06-15 17:41 ` [PATCH 3/3] nvme-pci: open-code polling logic in nvme_poll Sagi Grimberg
2017-06-16 7:05 ` Christoph Hellwig
2017-06-18 9:29 ` Sagi Grimberg
2017-06-18 13:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616070408.GA7672@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.