From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme-pci: open-code polling logic in nvme_poll
Date: Sun, 18 Jun 2017 15:12:30 +0200 [thread overview]
Message-ID: <20170618131229.GA32384@lst.de> (raw)
In-Reply-To: <8d592838-8681-16bf-a561-8c5feee08efa@grimberg.me>
On Sun, Jun 18, 2017@12:29:33PM +0300, Sagi Grimberg wrote:
>
>>> static int __nvme_poll(struct nvme_queue *nvmeq, unsigned int tag)
>>> {
>>> + struct nvme_completion cqe;
>>> + int found = 0, consumed = 0;
>>
>> found should be a bool.
>
> I'm returning found back from ->poll() callout so
> I think I'll keep it int, unless you want me to modify
> poll_fn signature?
Let's keep it as-is for now.
prev parent reply other threads:[~2017-06-18 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 17:41 [PATCH 0/3] refactor nvme-pci cq processing Sagi Grimberg
2017-06-15 17:41 ` [PATCH 1/3] nvme-pci: Split __nvme_process_cq to poll and handle Sagi Grimberg
2017-06-16 7:04 ` Christoph Hellwig
2017-06-15 17:41 ` [PATCH 2/3] nvme-pci: Add budget to __nvme_process_cq Sagi Grimberg
2017-06-16 7:04 ` Christoph Hellwig
2017-06-18 9:27 ` Sagi Grimberg
2017-06-15 17:41 ` [PATCH 3/3] nvme-pci: open-code polling logic in nvme_poll Sagi Grimberg
2017-06-16 7:05 ` Christoph Hellwig
2017-06-18 9:29 ` Sagi Grimberg
2017-06-18 13:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618131229.GA32384@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.