From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v5 for-4.13 2/7] mlx5e: don't assume anything on the irq affinity mappings of the device
Date: Fri, 16 Jun 2017 11:45:47 +0200 [thread overview]
Message-ID: <20170616094547.GA12547@lst.de> (raw)
In-Reply-To: <1497533594-11579-3-git-send-email-sagi@grimberg.me>
On Thu, Jun 15, 2017@04:33:09PM +0300, Sagi Grimberg wrote:
> mlx5e currently assumes that irq affinity is really spread first
> irq vectors across device home node cpus, with the new generic affinity
> mappings this is no longer the case, hence mlxe should not rely on
> this anymore.
Looks fine, but the explanation sounds a bit short - only spreading
the vectors of the single node sounds rather odd, so there needs to
be an explanation of why this was done before and isn't valid anymore.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Saeed Mahameed
<saeedm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v5 for-4.13 2/7] mlx5e: don't assume anything on the irq affinity mappings of the device
Date: Fri, 16 Jun 2017 11:45:47 +0200 [thread overview]
Message-ID: <20170616094547.GA12547@lst.de> (raw)
In-Reply-To: <1497533594-11579-3-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
On Thu, Jun 15, 2017 at 04:33:09PM +0300, Sagi Grimberg wrote:
> mlx5e currently assumes that irq affinity is really spread first
> irq vectors across device home node cpus, with the new generic affinity
> mappings this is no longer the case, hence mlxe should not rely on
> this anymore.
Looks fine, but the explanation sounds a bit short - only spreading
the vectors of the single node sounds rather odd, so there needs to
be an explanation of why this was done before and isn't valid anymore.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-16 9:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 13:33 [PATCH v5 for-4.13 0/7] Automatic affinity settings for nvme over rdma Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
2017-06-15 13:33 ` [PATCH v5 for-4.13 1/7] mlx5: convert to generic pci_alloc_irq_vectors Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
2017-06-15 13:33 ` [PATCH v5 for-4.13 2/7] mlx5e: don't assume anything on the irq affinity mappings of the device Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
2017-06-16 9:45 ` Christoph Hellwig [this message]
2017-06-16 9:45 ` Christoph Hellwig
2017-06-15 13:33 ` [PATCH v5 for-4.13 3/7] mlx5: move affinity hints assignments to generic code Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
2017-06-16 9:47 ` Christoph Hellwig
2017-06-16 9:47 ` Christoph Hellwig
2017-06-18 8:02 ` Sagi Grimberg
2017-06-18 8:02 ` Sagi Grimberg
2017-06-15 13:33 ` [PATCH v5 for-4.13 4/7] RDMA/core: expose affinity mappings per completion vector Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
2017-06-15 13:33 ` [PATCH v5 for-4.13 5/7] mlx5: support ->get_vector_affinity Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
2017-06-15 13:33 ` [PATCH v5 for-4.13 6/7] block: Add rdma affinity based queue mapping helper Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
2017-06-15 13:33 ` [PATCH v5 for-4.13 7/7] nvme-rdma: use intelligent affinity based queue mappings Sagi Grimberg
2017-06-15 13:33 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616094547.GA12547@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.