From: Jerome Glisse <j.glisse-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
Cc: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Ken Wang <Qingqing.Wang-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 02/23] drm/amdgpu: change wptr to 64 bits
Date: Fri, 16 Jun 2017 12:28:09 -0400 [thread overview]
Message-ID: <20170616162808.GA3868@gmail.com> (raw)
In-Reply-To: <2aa692b0-a42c-de15-91f0-0b5142d70ce9-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
On Thu, Mar 09, 2017 at 10:57:27AM +0100, Christian König wrote:
> Am 09.03.2017 um 04:44 schrieb Alex Deucher:
> > From: Ken Wang <Qingqing.Wang@amd.com>
> >
> > Newer asics use 64 bit wptrs
>
> We need a better patch description. Newer asics doesn't use 64bit wptrs, but
> rather need them!
>
> E.g. if the wptr is now smaller than the rptr that doesn't indicate a wrap
> around any more.
What does it means ? Doesn't make sense, you are allocating 1TB command
buffer and know you will never run out of space ? ;)
Either we are talking about a ring buffer and then wptr < rptr means wrap
around or we are talking about something new that is not a ring buffer.
64 bits or 32 bits doesn't matter from ring buffer point of view. So i
am puzzle about what this new thing is. Anywhere i can read about this
new command buffer thingy ? Because from where i stand it looks like it
would be better to be something else than a ring buffer if there is no
wrap around.
Cheers,
Jérôme
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-06-16 16:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 3:44 [PATCH 00/23] Prep patches for new asics Alex Deucher
[not found] ` <1489031093-4720-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-09 3:44 ` [PATCH 01/23] drm/amdgpu: init aperture definitions Alex Deucher
[not found] ` <1489031093-4720-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-09 9:41 ` Christian König
2017-03-09 3:44 ` [PATCH 02/23] drm/amdgpu: change wptr to 64 bits Alex Deucher
[not found] ` <1489031093-4720-3-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-09 9:57 ` Christian König
[not found] ` <2aa692b0-a42c-de15-91f0-0b5142d70ce9-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-06-16 16:28 ` Jerome Glisse [this message]
[not found] ` <20170616162808.GA3868-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-16 18:00 ` Christian König
2017-03-09 3:44 ` [PATCH 03/23] drm/amdgpu: add 64bit wb functions Alex Deucher
2017-03-09 3:44 ` [PATCH 04/23] drm/amdgpu: add 64bit doorbell functions Alex Deucher
2017-03-09 3:44 ` [PATCH 05/23] drm/amdgpu: switch ih handling to two levels Alex Deucher
[not found] ` <1489031093-4720-6-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-09 10:03 ` Christian König
2017-03-09 3:44 ` [PATCH 06/23] drm/amdgpu/ih: store the full context id Alex Deucher
2017-03-09 3:44 ` [PATCH 07/23] drm/amdgpu: expand pte flags to uint64_t Alex Deucher
2017-03-09 3:44 ` [PATCH 08/23] drm/amdgpu: add a ucode size member into firmware info Alex Deucher
2017-03-09 3:44 ` [PATCH 09/23] drm/amdgpu: set GART PTE asic specific flags Alex Deucher
2017-03-09 3:44 ` [PATCH 10/23] drm/amdgpu: add a callback to set vm mapping flags Alex Deucher
2017-03-09 3:44 ` [PATCH 11/23] drm/amdgpu: check function points valid before use Alex Deucher
[not found] ` <1489031093-4720-12-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-09 10:07 ` Christian König
2017-03-09 3:44 ` [PATCH 12/23] drm/amdgpu: add asic callback to get memsize register Alex Deucher
2017-03-09 3:44 ` [PATCH 13/23] drm/amdgpu: add DRM MGCG header Alex Deucher
2017-03-09 3:44 ` [PATCH 14/23] drm/amdgpu: add DF MGCG flag Alex Deucher
2017-03-09 3:44 ` [PATCH 15/23] drm/amdgpu: add a ring func for end command Alex Deucher
2017-03-09 3:44 ` [PATCH 16/23] drm/amdgpu: move amdgpu_uvd structure to uvd header Alex Deucher
2017-03-09 3:44 ` [PATCH 17/23] drm/amdgpu: move amdgpu_vce structure to vce header Alex Deucher
2017-03-09 3:44 ` [PATCH 18/23] drm/amdgpu: add uvd enc rings Alex Deucher
2017-03-09 3:44 ` [PATCH 19/23] drm/amdgpu: add uvd enc run queue Alex Deucher
2017-03-09 3:44 ` [PATCH 20/23] drm/amdgpu: add uvd enc ring type and functions Alex Deucher
2017-03-09 3:44 ` [PATCH 21/23] uapi/drm: add AMDGPU_HW_IP_UVD_ENC Alex Deucher
2017-03-09 3:44 ` [PATCH 22/23] drm/amdgpu: add AMDGPU_HW_IP_UVD_ENC to info query Alex Deucher
2017-03-09 3:44 ` [PATCH 23/23] drm/amdgpu: get cs support of AMDGPU_HW_IP_UVD_ENC Alex Deucher
2017-03-09 10:11 ` [PATCH 00/23] Prep patches for new asics Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616162808.GA3868@gmail.com \
--to=j.glisse-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Qingqing.Wang-5C7GfCeVMHo@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.