All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH 0/8] future/QC: Cosmetic fixes and improvements
Date: Fri, 16 Jun 2017 21:32:44 -0700	[thread overview]
Message-ID: <20170617043244.GH3721@linux.vnet.ibm.com> (raw)
In-Reply-To: <8919b898-9e43-8f72-39ce-5d31dc84f45d@gmail.com>

On Sat, Jun 17, 2017 at 12:54:47PM +0900, Akira Yokosawa wrote:
> >From e5738e83414b3c3d30d616543bb2f70cbb80bcca Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Sat, 17 Jun 2017 10:44:54 +0900
> Subject: [PATCH 0/8] future/QC: Cosmetic fixes and improvements
> 
> Hi Paul,
> 
> This patch set mostly fixes and improves LaTeX source of QC section.
> 
> Patch 1 adds patterns in hyphen2endash.sh.
> 
> Patch 2 gives consistent looks to tables as in other tables in
> perfbook.
> 
> Patch 3 fixes typos in SI unit symbols and usage of math mode.
> 
> Patch 4 Adds whitespaces between numerical values and unit symbols.
> This is recommended in NIST style guide (referred to in the change
> log). Since this section treats topics covering quantum mechanics,
> I want it to have a similar look as a scientific paper.
> In other parts of perfbbok, I have quite a few places I want to add
> whitespaces, but I'm not sure that matches your preference.
> If you'd like such changes, I can produce patches to do so.
> 
> Patch 5 uses axis names "X-axis", "Y-axis", and "Z-axis" in the
> lists of "Programming Model" section. I also tried other forms of
> "x-axis", "x axis", and "X axis", but "X-axis" is my preference.
> 
> Patch 6 seems a trivial grammatical fix, but might be unnecessary.
> I'm not sure.
> 
> Patch 7 gives representation of ket commonly used in quantum mechanics
> papers.
> 
> Patch 8 changes the look of QC operators. Special treatment of
> dagger symbol in description labels might be excessive, but
> it gives better result in my point of view.
> 
> So, I'm not sure you like patches 4--8. Please try and push as
> much as you like. And feel free to ask me a respin of the patches
> you don't like as is.

The all look good, so I queued and pushed them, thank you!  I also
queued a change to fix my failure to define "qubit" at first use.

It would be good to have a consistent and professional look, so please
do feel free to make similar fixes elsewhere.

I am going to have to make myself some sort of cheat sheet to get
all this right, though!  ;-)

							Thanx, Paul

>             Thanks, Akira
> --
> Akira Yokosawa (8):
>   hyphen2endash: Add patterns for QC section
>   future/QC: Tweak appearance of tables
>   future/QC: Fix typo in unit symbol and usage of math mode
>   future/QC: Add narrow space before unit symbol
>   future/QC: Use consistent axis names
>   future/QC: Add missing 'has' in description list
>   future/QC: Use \ket{} macro for |0> and |1>
>   future/QC: Denote QC operators as such
> 
>  future/QC.tex              | 123 +++++++++++++++++++++++----------------------
>  perfbook.tex               |   5 ++
>  utilities/hyphen2endash.sh |   8 +++
>  3 files changed, 76 insertions(+), 60 deletions(-)
> 
> -- 
> 2.7.4
> 


      parent reply	other threads:[~2017-06-17  4:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17  3:54 [PATCH 0/8] future/QC: Cosmetic fixes and improvements Akira Yokosawa
2017-06-17  3:56 ` [PATCH 1/8] hyphen2endash: Add patterns for QC section Akira Yokosawa
2017-06-17  3:57 ` [PATCH 2/8] future/QC: Tweak appearance of tables Akira Yokosawa
2017-06-17  3:58 ` [PATCH 3/8] future/QC: Fix typo in unit symbol and usage of math mode Akira Yokosawa
2017-06-17  3:59 ` [PATCH 4/8] future/QC: Add narrow space before unit symbol Akira Yokosawa
2017-06-17  4:00 ` [PATCH 5/8] future/QC: Use consistent axis names Akira Yokosawa
2017-06-17  4:01 ` [PATCH 6/8] future/QC: Add missing 'has' in description list Akira Yokosawa
2017-06-17  4:02 ` [PATCH 7/8] future/QC: Use \ket{} macro for |0> and |1> Akira Yokosawa
2017-06-17  4:04 ` [PATCH 8/8] future/QC: Denote QC operators as such Akira Yokosawa
2017-06-17  4:32 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170617043244.GH3721@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.